[INFO] fetching crate fibers_transport 0.1.3... [INFO] checking fibers_transport-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fibers_transport 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fibers_transport 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fibers_transport 0.1.3 [INFO] finished tweaking crates.io crate fibers_transport 0.1.3 [INFO] tweaked toml for crates.io crate fibers_transport 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding splay_tree v0.2.10 (latest: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding trackable v0.2.24 (latest: v1.3.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d03490dfe3bd275791ea75a37fa5257d65a497e6bf5b565c1649c12d7ac494d5 [INFO] running `Command { std: "docker" "start" "-a" "d03490dfe3bd275791ea75a37fa5257d65a497e6bf5b565c1649c12d7ac494d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d03490dfe3bd275791ea75a37fa5257d65a497e6bf5b565c1649c12d7ac494d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d03490dfe3bd275791ea75a37fa5257d65a497e6bf5b565c1649c12d7ac494d5", kill_on_drop: false }` [INFO] [stdout] d03490dfe3bd275791ea75a37fa5257d65a497e6bf5b565c1649c12d7ac494d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7a813879abc9326412644d7cb3fec14d65e86013bf1bd461071122f9c128dcc [INFO] running `Command { std: "docker" "start" "-a" "a7a813879abc9326412644d7cb3fec14d65e86013bf1bd461071122f9c128dcc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking nbchan v0.1.3 [INFO] [stderr] Checking splay_tree v0.2.10 [INFO] [stderr] Checking factory v0.1.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking fibers v0.1.13 [INFO] [stderr] Checking fibers_global v0.1.2 [INFO] [stderr] Compiling trackable_derive v1.0.0 [INFO] [stderr] Checking trackable v1.3.0 [INFO] [stderr] Checking trackable v0.2.24 [INFO] [stderr] Checking bytecodec v0.4.15 [INFO] [stderr] Checking fibers_transport v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn wait_send(transporter: T) -> impl Future { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | WaitSend(Some(transporter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 37 | transporter: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> impl Future { [INFO] [stdout] 39 | WaitRecv(Some(transporter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 66 | let (peer, item) = { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let t = self.0.as_mut().expect("Cannot poll WaitRecv twice"); [INFO] [stdout] 68 | match track!(t.poll_recv())? { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | track_panic!(ErrorKind::Other, "Transporter unexpectedly terminated") [INFO] [stdout] | --------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | } [INFO] [stdout] 73 | Async::Ready(Some((peer, item))) => (peer, item), [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let transporter = self.0.take().expect("never fails"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Ok(Async::Ready((transporter, peer, item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ErrorKind::IoError.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_peer.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 51 | fn start_send(&mut self, peer: Self::PeerAddr, item: Self::SendItem) -> Result<()> { [INFO] [stdout] | -------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | self.inner.start_send(self.interior_peer.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let inner = Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | RcTransporter(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn with_inner_ref(&self, f: F) -> U [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | f(&self.0.borrow().transporter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn with_inner_mut(&mut self, f: F) -> U [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | f(&mut self.0.borrow_mut().transporter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn finish(self, stream: TcpStream) -> Result> { [INFO] [stdout] | ---- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let _ = stream.set_nodelay(true); [INFO] [stdout] 59 | let peer_addr = track!(stream.peer_addr().map_err(Error::from))?; [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_addr = track!(stream.local_addr().map_err(Error::from))?; [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Ok(TcpTransporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | stream: BufferedIo::new(stream, self.buf_size, self.buf_size), [INFO] [stdout] 63 | | peer_addr, [INFO] [stdout] 64 | | local_addr, [INFO] [stdout] ... | [INFO] [stdout] 67 | | outgoing_queue: VecDeque::new(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | / TcpStream::connect(peer) [INFO] [stdout] 77 | | .map_err(|e| track!(Error::from(e))) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | .and_then(move |stream| track!(self.finish(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn from_stream(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | TcpTransporterBuilder::new().finish(stream) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_listener.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn finish(self, listener: RawTcpListener) -> Result> { [INFO] [stdout] | ---- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let local_addr = track!(listener.local_addr().map_err(Error::from))?; [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | incoming: listener.incoming(), [INFO] [stdout] 50 | | local_addr, [INFO] [stdout] 51 | | encoder_factory: self.encoder_factory, [INFO] [stdout] 52 | | decoder_factory: self.decoder_factory, [INFO] [stdout] 53 | | client_futures: Vec::new(), [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_listener.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 59 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | .and_then(move |listener| track!(self.finish(listener))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn finish(self, socket: UdpSocket) -> Result> { [INFO] [stdout] | ---- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let local_addr = track!(socket.local_addr().map_err(Error::from))?; [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let recv_from = socket.clone().recv_from(vec![0; self.buf_size]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(UdpTransporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | socket, [INFO] [stdout] 60 | | local_addr, [INFO] [stdout] 61 | | encoder: self.encoder, [INFO] [stdout] ... | [INFO] [stdout] 65 | | recv_from, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn bind(self, addr: SocketAddr) -> impl Future, Error = Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | / UdpSocket::bind(addr) [INFO] [stdout] 73 | | .map_err(|e| track!(Error::from(e))) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn bind(self, addr: SocketAddr) -> impl Future, Error = Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | .and_then(move |socket| track!(self.finish(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn from_socket(socket: UdpSocket) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | UdpTransporterBuilder::new().finish(socket) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fibers_transport` (lib) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:32:14 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn wait_send(transporter: T) -> impl Future { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | WaitSend(Some(transporter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:39:14 [INFO] [stdout] | [INFO] [stdout] 37 | transporter: T, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | ) -> impl Future { [INFO] [stdout] 39 | WaitRecv(Some(transporter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 66 | let (peer, item) = { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let t = self.0.as_mut().expect("Cannot poll WaitRecv twice"); [INFO] [stdout] 68 | match track!(t.poll_recv())? { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | track_panic!(ErrorKind::Other, "Transporter unexpectedly terminated") [INFO] [stdout] | --------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | } [INFO] [stdout] 73 | Async::Ready(Some((peer, item))) => (peer, item), [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let transporter = self.0.take().expect("never fails"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Ok(Async::Ready((transporter, peer, item))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ErrorKind::IoError.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_peer.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 51 | fn start_send(&mut self, peer: Self::PeerAddr, item: Self::SendItem) -> Result<()> { [INFO] [stdout] | -------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | self.inner.start_send(self.interior_peer.clone(), item) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let inner = Inner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | RcTransporter(Rc::new(RefCell::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn with_inner_ref(&self, f: F) -> U [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | f(&self.0.borrow().transporter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/share.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn with_inner_mut(&mut self, f: F) -> U [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | f(&mut self.0.borrow_mut().transporter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn finish(self, stream: TcpStream) -> Result> { [INFO] [stdout] | ---- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let _ = stream.set_nodelay(true); [INFO] [stdout] 59 | let peer_addr = track!(stream.peer_addr().map_err(Error::from))?; [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let local_addr = track!(stream.local_addr().map_err(Error::from))?; [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Ok(TcpTransporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | stream: BufferedIo::new(stream, self.buf_size, self.buf_size), [INFO] [stdout] 63 | | peer_addr, [INFO] [stdout] 64 | | local_addr, [INFO] [stdout] ... | [INFO] [stdout] 67 | | outgoing_queue: VecDeque::new(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | / TcpStream::connect(peer) [INFO] [stdout] 77 | | .map_err(|e| track!(Error::from(e))) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | .and_then(move |stream| track!(self.finish(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn from_stream(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | TcpTransporterBuilder::new().finish(stream) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_listener.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn finish(self, listener: RawTcpListener) -> Result> { [INFO] [stdout] | ---- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let local_addr = track!(listener.local_addr().map_err(Error::from))?; [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | incoming: listener.incoming(), [INFO] [stdout] 50 | | local_addr, [INFO] [stdout] 51 | | encoder_factory: self.encoder_factory, [INFO] [stdout] 52 | | decoder_factory: self.decoder_factory, [INFO] [stdout] 53 | | client_futures: Vec::new(), [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp_listener.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 59 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | .and_then(move |listener| track!(self.finish(listener))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn finish(self, socket: UdpSocket) -> Result> { [INFO] [stdout] | ---- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let local_addr = track!(socket.local_addr().map_err(Error::from))?; [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let recv_from = socket.clone().recv_from(vec![0; self.buf_size]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(UdpTransporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | socket, [INFO] [stdout] 60 | | local_addr, [INFO] [stdout] 61 | | encoder: self.encoder, [INFO] [stdout] ... | [INFO] [stdout] 65 | | recv_from, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn bind(self, addr: SocketAddr) -> impl Future, Error = Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | / UdpSocket::bind(addr) [INFO] [stdout] 73 | | .map_err(|e| track!(Error::from(e))) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn bind(self, addr: SocketAddr) -> impl Future, Error = Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | .and_then(move |socket| track!(self.finish(socket))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn from_socket(socket: UdpSocket) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | UdpTransporterBuilder::new().finish(socket) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fibers_transport` (lib test) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "a7a813879abc9326412644d7cb3fec14d65e86013bf1bd461071122f9c128dcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7a813879abc9326412644d7cb3fec14d65e86013bf1bd461071122f9c128dcc", kill_on_drop: false }` [INFO] [stdout] a7a813879abc9326412644d7cb3fec14d65e86013bf1bd461071122f9c128dcc