[INFO] fetching crate ffmpeg-sidecar 1.1.1... [INFO] checking ffmpeg-sidecar-1.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ffmpeg-sidecar 1.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ffmpeg-sidecar 1.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ffmpeg-sidecar 1.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ffmpeg-sidecar 1.1.1 [INFO] tweaked toml for crates.io crate ffmpeg-sidecar 1.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate ffmpeg-sidecar 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd2a66efd974524ddc743d3f38ea3fe2ad53c046a757c2ce9ccf4b8668358cd6 [INFO] running `Command { std: "docker" "start" "-a" "fd2a66efd974524ddc743d3f38ea3fe2ad53c046a757c2ce9ccf4b8668358cd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd2a66efd974524ddc743d3f38ea3fe2ad53c046a757c2ce9ccf4b8668358cd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd2a66efd974524ddc743d3f38ea3fe2ad53c046a757c2ce9ccf4b8668358cd6", kill_on_drop: false }` [INFO] [stdout] fd2a66efd974524ddc743d3f38ea3fe2ad53c046a757c2ce9ccf4b8668358cd6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83a1b87b72ffefe2c84620d8e0d8ed87ad4487c8c5eac952bb1f47c9fa16c5ab [INFO] running `Command { std: "docker" "start" "-a" "83a1b87b72ffefe2c84620d8e0d8ed87ad4487c8c5eac952bb1f47c9fa16c5ab", kill_on_drop: false }` [INFO] [stderr] Checking ffmpeg-sidecar v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 28 | let stderr = child.take_stderr().context("No stderr channel\n - Did you call `take_stderr` elsewhere?\n - Did you forget to call `.st... [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (tx, rx) = sync_channel::(0); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | spawn_stderr_thread(stderr, tx.clone()); [INFO] [stdout] 31 | let stdout = child.take_stdout(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | rx, [INFO] [stdout] 35 | | tx: Some(tx), [INFO] [stdout] 36 | | stdout, [INFO] [stdout] 37 | | metadata: FfmpegMetadata::new(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 182 | stdout: ChildStdout, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | tx: SyncSender, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 188 | | // Filter streams which are sent to stdout [INFO] [stdout] 189 | | let stdout_output_streams = output_streams.iter().filter(|stream| { [INFO] [stdout] 190 | | outputs [INFO] [stdout] ... | [INFO] [stdout] 284 | | tx.send(FfmpegEvent::Done).ok(); [INFO] [stdout] 285 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:292:22 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn spawn_stderr_thread(stderr: ChildStderr, tx: SyncSender) -> JoinHandle<()> { [INFO] [stdout] | ------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 293 | | let reader = BufReader::new(stderr); [INFO] [stdout] 294 | | let mut parser = FfmpegLogParser::new(reader); [INFO] [stdout] 295 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_parser.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new(inner: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Self { [INFO] [stdout] 114 | reader: BufReader::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffmpeg-sidecar` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 28 | let stderr = child.take_stderr().context("No stderr channel\n - Did you call `take_stderr` elsewhere?\n - Did you forget to call `.st... [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (tx, rx) = sync_channel::(0); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | spawn_stderr_thread(stderr, tx.clone()); [INFO] [stdout] 31 | let stdout = child.take_stdout(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 34 | | rx, [INFO] [stdout] 35 | | tx: Some(tx), [INFO] [stdout] 36 | | stdout, [INFO] [stdout] 37 | | metadata: FfmpegMetadata::new(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 182 | stdout: ChildStdout, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | tx: SyncSender, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 188 | | // Filter streams which are sent to stdout [INFO] [stdout] 189 | | let stdout_output_streams = output_streams.iter().filter(|stream| { [INFO] [stdout] 190 | | outputs [INFO] [stdout] ... | [INFO] [stdout] 284 | | tx.send(FfmpegEvent::Done).ok(); [INFO] [stdout] 285 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:292:22 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn spawn_stderr_thread(stderr: ChildStderr, tx: SyncSender) -> JoinHandle<()> { [INFO] [stdout] | ------------------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | std::thread::spawn(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 293 | | let reader = BufReader::new(stderr); [INFO] [stdout] 294 | | let mut parser = FfmpegLogParser::new(reader); [INFO] [stdout] 295 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_parser.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new(inner: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Self { [INFO] [stdout] 114 | reader: BufReader::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffmpeg-sidecar` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "83a1b87b72ffefe2c84620d8e0d8ed87ad4487c8c5eac952bb1f47c9fa16c5ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83a1b87b72ffefe2c84620d8e0d8ed87ad4487c8c5eac952bb1f47c9fa16c5ab", kill_on_drop: false }` [INFO] [stdout] 83a1b87b72ffefe2c84620d8e0d8ed87ad4487c8c5eac952bb1f47c9fa16c5ab