[INFO] fetching crate ffi-convert-derive 0.6.1... [INFO] checking ffi-convert-derive-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ffi-convert-derive 0.6.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ffi-convert-derive 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ffi-convert-derive 0.6.1 [INFO] finished tweaking crates.io crate ffi-convert-derive 0.6.1 [INFO] tweaked toml for crates.io crate ffi-convert-derive 0.6.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a813e526fe302b3333e577457d04558a6f6afe1204e720042f1f07c0b895c447 [INFO] running `Command { std: "docker" "start" "-a" "a813e526fe302b3333e577457d04558a6f6afe1204e720042f1f07c0b895c447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a813e526fe302b3333e577457d04558a6f6afe1204e720042f1f07c0b895c447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a813e526fe302b3333e577457d04558a6f6afe1204e720042f1f07c0b895c447", kill_on_drop: false }` [INFO] [stdout] a813e526fe302b3333e577457d04558a6f6afe1204e720042f1f07c0b895c447 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f82256c433031cbfbe58c626a8aba9193e73de8aea12b93650d55393a260196 [INFO] running `Command { std: "docker" "start" "-a" "3f82256c433031cbfbe58c626a8aba9193e73de8aea12b93650d55393a260196", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ffi-convert-derive v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `type_params` is never read [INFO] [stdout] --> src/utils.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Field<'a> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub type_params: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asrust.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 115 | let field_name = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let init = input.parse()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(ExtraFieldsArgs { field_name, init }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cdrop.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 9 | let fields = parse_struct_fields(&input.data); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | [INFO] [stdout] 11 | let do_drop_fields = fields [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let c_drop_impl = quote!( [INFO] [stdout] | _________-----------___- [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | impl CDrop for # struct_name { [INFO] [stdout] 53 | | fn do_drop(&mut self) -> Result<(), ffi_convert::CDropError> { [INFO] [stdout] 54 | | use ffi_convert::RawPointerConverter; [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let drop_impl = quote!( [INFO] [stdout] | _________---------___- [INFO] [stdout] | |_________|___________| [INFO] [stdout] | |_________|___________| [INFO] [stdout] | |_________|___________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | | impl Drop for # struct_name { [INFO] [stdout] 63 | | fn drop(&mut self) { [INFO] [stdout] 64 | | let _ = self.do_drop(); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | / { [INFO] [stdout] 70 | if disable_drop_impl { [INFO] [stdout] 71 | quote! { [INFO] [stdout] 72 | # c_drop_impl [INFO] [stdout] ... [INFO] [stdout] 79 | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffi-convert-derive` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `type_params` is never read [INFO] [stdout] --> src/utils.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct Field<'a> { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | pub type_params: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asrust.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 115 | let field_name = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let init = input.parse()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(ExtraFieldsArgs { field_name, init }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cdrop.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 9 | let fields = parse_struct_fields(&input.data); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | [INFO] [stdout] 11 | let do_drop_fields = fields [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let c_drop_impl = quote!( [INFO] [stdout] | _________-----------___- [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | |_________|_____________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | impl CDrop for # struct_name { [INFO] [stdout] 53 | | fn do_drop(&mut self) -> Result<(), ffi_convert::CDropError> { [INFO] [stdout] 54 | | use ffi_convert::RawPointerConverter; [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | let drop_impl = quote!( [INFO] [stdout] | _________---------___- [INFO] [stdout] | |_________|___________| [INFO] [stdout] | |_________|___________| [INFO] [stdout] | |_________|___________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | | impl Drop for # struct_name { [INFO] [stdout] 63 | | fn drop(&mut self) { [INFO] [stdout] 64 | | let _ = self.do_drop(); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | / { [INFO] [stdout] 70 | if disable_drop_impl { [INFO] [stdout] 71 | quote! { [INFO] [stdout] 72 | # c_drop_impl [INFO] [stdout] ... [INFO] [stdout] 79 | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 179 | let type_path = syn::parse_str::("std::mod1::mod2::Foo").unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | [INFO] [stdout] 181 | let (transformed_type_path, extracted_type_param) = [INFO] [stdout] | --------------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | assert_eq!(extracted_type_param.unwrap().args.len(), 2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:203:13 [INFO] [stdout] | [INFO] [stdout] 195 | let original_path = syn::parse_str::("std::module1::module2::Hello") [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | .expect("Could not parse str into syn::Path"); [INFO] [stdout] 197 | let (transformed_path, extracted_type_params) = [INFO] [stdout] | ---------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | / TypeArrayOrTypePath::TypePath( [INFO] [stdout] 204 | | syn::parse_str::("std::module1::module2::Hello").unwrap() [INFO] [stdout] 205 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ffi-convert-derive` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3f82256c433031cbfbe58c626a8aba9193e73de8aea12b93650d55393a260196", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f82256c433031cbfbe58c626a8aba9193e73de8aea12b93650d55393a260196", kill_on_drop: false }` [INFO] [stdout] 3f82256c433031cbfbe58c626a8aba9193e73de8aea12b93650d55393a260196