[INFO] fetching crate ferrostar 0.9.1... [INFO] checking ferrostar-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ferrostar 0.9.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ferrostar 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ferrostar 0.9.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ferrostar 0.9.1 [INFO] tweaked toml for crates.io crate ferrostar 0.9.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 160 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.15.4 (latest: v0.18.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding rstest v0.21.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.21.0 (latest: v0.22.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 771c6661edda22afe5ce10e1ad91edf2eb8509b18731df88ab30e4bdeeb34b0f [INFO] running `Command { std: "docker" "start" "-a" "771c6661edda22afe5ce10e1ad91edf2eb8509b18731df88ab30e4bdeeb34b0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "771c6661edda22afe5ce10e1ad91edf2eb8509b18731df88ab30e4bdeeb34b0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "771c6661edda22afe5ce10e1ad91edf2eb8509b18731df88ab30e4bdeeb34b0f", kill_on_drop: false }` [INFO] [stdout] 771c6661edda22afe5ce10e1ad91edf2eb8509b18731df88ab30e4bdeeb34b0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9db978e9cc292cd8fb9431b9dbd0553a446b577bf78b2f2f923484161948520b [INFO] running `Command { std: "docker" "start" "-a" "9db978e9cc292cd8fb9431b9dbd0553a446b577bf78b2f2f923484161948520b", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling uniffi_checksum_derive v0.28.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking camino v1.1.9 [INFO] [stderr] Compiling bytes v1.7.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking uniffi_core v0.28.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.43 [INFO] [stderr] Compiling uniffi_meta v0.28.1 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Checking spade v2.12.0 [INFO] [stderr] Checking polyline v0.11.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking wasm-bindgen-test v0.3.43 [INFO] [stderr] Compiling bincode v1.3.3 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking geo v0.28.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling rstest_macros v0.21.0 [INFO] [stderr] Compiling uniffi_macros v0.28.1 [INFO] [stderr] Checking rstest v0.21.0 [INFO] [stderr] Checking uniffi v0.28.1 [INFO] [stderr] Checking ferrostar v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/routing_adapters/valhalla.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/routing_adapters/valhalla.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/routing_adapters/osrm/models.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct RouteResponse { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RouteResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing_adapters/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 153 | let request_generator = Arc::new(ValhallaHttpRequestGenerator::with_costing_options_json( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let response_parser = Arc::new(OsrmResponseParser::new(6)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(Self::new(request_generator, response_parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ferrostar` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `serialize` is never used [INFO] [stdout] --> src/models.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn serialize(time: &SystemTime, serializer: S) -> Result [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `deserialize` is never used [INFO] [stdout] --> src/models.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn deserialize<'de, D>(deserializer: D) -> Result [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code` is never read [INFO] [stdout] --> src/routing_adapters/osrm/models.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct RouteResponse { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub code: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RouteResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routing_adapters/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 153 | let request_generator = Arc::new(ValhallaHttpRequestGenerator::with_costing_options_json( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let response_parser = Arc::new(OsrmResponseParser::new(6)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(Self::new(request_generator, response_parser)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ferrostar` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9db978e9cc292cd8fb9431b9dbd0553a446b577bf78b2f2f923484161948520b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9db978e9cc292cd8fb9431b9dbd0553a446b577bf78b2f2f923484161948520b", kill_on_drop: false }` [INFO] [stdout] 9db978e9cc292cd8fb9431b9dbd0553a446b577bf78b2f2f923484161948520b