[INFO] fetching crate ferris-finder 0.2.1... [INFO] checking ferris-finder-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ferris-finder 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ferris-finder 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ferris-finder 0.2.1 [INFO] finished tweaking crates.io crate ferris-finder 0.2.1 [INFO] tweaked toml for crates.io crate ferris-finder 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate ferris-finder 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9cd43c4887af1aa3648ebe7490edb5587c9771fc867995677927749ddb8ab594 [INFO] running `Command { std: "docker" "start" "-a" "9cd43c4887af1aa3648ebe7490edb5587c9771fc867995677927749ddb8ab594", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9cd43c4887af1aa3648ebe7490edb5587c9771fc867995677927749ddb8ab594", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cd43c4887af1aa3648ebe7490edb5587c9771fc867995677927749ddb8ab594", kill_on_drop: false }` [INFO] [stdout] 9cd43c4887af1aa3648ebe7490edb5587c9771fc867995677927749ddb8ab594 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6457362d28a9712c71d874426cae04d0c6479d7636c36280af4b96f5f61b0814 [INFO] running `Command { std: "docker" "start" "-a" "6457362d28a9712c71d874426cae04d0c6479d7636c36280af4b96f5f61b0814", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Checking smallvec v1.8.1 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.14 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling serde v1.0.138 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking gimli v0.27.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking object v0.30.3 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking tracing-subscriber v0.3.15 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking base64 v0.21.0 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Compiling backtrace v0.3.67 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking addr2line v0.19.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.19 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking ferris-finder v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `category` is never read [INFO] [stdout] --> src/ucd.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CharEntry { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub category: GeneralCategory, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CharEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 38 | running_flag: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | mut stdout: io::Stdout, [INFO] [stdout] 40 | event_receiver: sync::mpsc::Receiver, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | data: Box<[ucd::CharEntry]>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let terminal = match tui::Terminal::new(backend) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(terminal) => terminal, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | }; [INFO] [stdout] 54 | let table_data = App::table_items_from_data(&data.par_iter().collect::>()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | running_flag, [INFO] [stdout] 60 | | terminal, [INFO] [stdout] 61 | | event_receiver, [INFO] [stdout] ... | [INFO] [stdout] 66 | | exit_buffer: None, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ucd.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 14 | let data_entry = ucd_line.trim().split(';').collect::>(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let name = if is_ferris { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let unicode_1_name = (*(data_entry.get(10)?)).into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Some(CharEntry { [INFO] [stdout] | ______________^ [INFO] [stdout] 71 | | codepoint, [INFO] [stdout] 72 | | name, [INFO] [stdout] 73 | | category, [INFO] [stdout] 74 | | unicode_1_name, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `category` is never read [INFO] [stdout] --> src/ucd.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CharEntry { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub category: GeneralCategory, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CharEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 38 | running_flag: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | mut stdout: io::Stdout, [INFO] [stdout] 40 | event_receiver: sync::mpsc::Receiver, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | data: Box<[ucd::CharEntry]>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let terminal = match tui::Terminal::new(backend) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Ok(terminal) => terminal, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | }; [INFO] [stdout] 54 | let table_data = App::table_items_from_data(&data.par_iter().collect::>()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(App { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | running_flag, [INFO] [stdout] 60 | | terminal, [INFO] [stdout] 61 | | event_receiver, [INFO] [stdout] ... | [INFO] [stdout] 66 | | exit_buffer: None, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ucd.rs:70:14 [INFO] [stdout] | [INFO] [stdout] 14 | let data_entry = ucd_line.trim().split(';').collect::>(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let name = if is_ferris { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let unicode_1_name = (*(data_entry.get(10)?)).into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Some(CharEntry { [INFO] [stdout] | ______________^ [INFO] [stdout] 71 | | codepoint, [INFO] [stdout] 72 | | name, [INFO] [stdout] 73 | | category, [INFO] [stdout] 74 | | unicode_1_name, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ferris-finder` (bin "ferris-finder" test) due to 3 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ferris-finder` (bin "ferris-finder") due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6457362d28a9712c71d874426cae04d0c6479d7636c36280af4b96f5f61b0814", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6457362d28a9712c71d874426cae04d0c6479d7636c36280af4b96f5f61b0814", kill_on_drop: false }` [INFO] [stdout] 6457362d28a9712c71d874426cae04d0c6479d7636c36280af4b96f5f61b0814