[INFO] fetching crate feophant 0.9.0... [INFO] checking feophant-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate feophant 0.9.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate feophant 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate feophant 0.9.0 [INFO] finished tweaking crates.io crate feophant 0.9.0 [INFO] tweaked toml for crates.io crate feophant 0.9.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate feophant 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9790ecbc040f78bfbe357327331c52aaa382e08f1985cb204ff022438f6188e1 [INFO] running `Command { std: "docker" "start" "-a" "9790ecbc040f78bfbe357327331c52aaa382e08f1985cb204ff022438f6188e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9790ecbc040f78bfbe357327331c52aaa382e08f1985cb204ff022438f6188e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9790ecbc040f78bfbe357327331c52aaa382e08f1985cb204ff022438f6188e1", kill_on_drop: false }` [INFO] [stdout] 9790ecbc040f78bfbe357327331c52aaa382e08f1985cb204ff022438f6188e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 125f29e2857f43dfd6371173ee8be6d81485ab41a5ee6bb9bfef65779f43b1fa [INFO] running `Command { std: "docker" "start" "-a" "125f29e2857f43dfd6371173ee8be6d81485ab41a5ee6bb9bfef65779f43b1fa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling tokio v1.7.1 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.1 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking cache-padded v1.1.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling minimal-lexical v0.1.2 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking fastrand v1.5.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking futures-lite v1.12.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking polling v2.1.0 [INFO] [stderr] Checking raw-cpuid v10.2.0 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Checking cpufeatures v0.1.5 [INFO] [stderr] Checking event-listener v2.5.1 [INFO] [stderr] Compiling moka v0.6.1 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking scheduled-thread-pool v0.2.5 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking async-lock v2.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Checking moka-cht v0.4.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking siphasher v0.3.6 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.10.1 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling hex-literal v0.3.1 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking lru v0.6.6 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking quanta v0.9.3 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking async-io v1.6.0 [INFO] [stderr] Checking postgres-protocol v0.6.1 [INFO] [stderr] Checking simplelog v0.10.0 [INFO] [stderr] Checking postgres-types v0.2.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Compiling tokio-macros v1.2.0 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking tokio-stream v0.1.6 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking tokio-test v0.4.2 [INFO] [stderr] Checking feophant v0.9.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-postgres v0.7.2 [INFO] [stdout] warning: unused imports: `BytesMut` and `Bytes` [INFO] [stdout] --> src/engine/io/row_formats/item_pointer.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | use bytes::{Buf, BufMut, Bytes, BytesMut}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::TryFrom` [INFO] [stdout] --> src/engine/io/row_formats/item_pointer.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::convert::TryFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stdout] warning: unused variable: `o` [INFO] [stdout] --> src/engine/io/visible_row_manager.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | Ok(o) => return Ok(true), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_o` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `page_offset` [INFO] [stdout] --> src/engine/io/index_manager.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let (page_guard, page_offset, mut leaf) = [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_page_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prior_offset` is assigned to, but never used [INFO] [stdout] --> src/engine/io/index_manager/find_leaf.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut prior_offset = PageOffset(0); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_prior_offset` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `prior_offset` is never read [INFO] [stdout] --> src/engine/io/index_manager/find_leaf.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | prior_offset = offset; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stdout] warning: unused variable: `k` [INFO] [stdout] --> src/engine/io/index_formats/btree_leaf.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | .flat_map(|(k, v)| v.clone()) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_k` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/engine/objects/types/base_sql_types.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | BaseSqlTypesMapper::Array(a) => todo!("Bed time, need to fix!"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `search` is never used [INFO] [stdout] --> src/engine/io/index_formats/btree_leaf.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 30 | impl BTreeLeaf { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | pub fn search(&self, range: R) -> Vec [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_constraint` is never used [INFO] [stdout] --> src/engine/objects/constraints/parse_constraint.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn parse_constraint<'a, E: ParseError<&'a str> + ContextError<&'a str>>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `WhereEntry` is never used [INFO] [stdout] --> src/engine/objects/query_tree.rs:68:10 [INFO] [stdout] | [INFO] [stdout] 68 | pub enum WhereEntry {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WhereEntry` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `file_manager` is never read [INFO] [stdout] --> src/feophant.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct FeOphant { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 28 | file_manager: Arc, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/network_frame.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 28 | let mut buffer = BytesMut::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | NetworkFrame::new(b'C', buffer.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/network_frame.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 72 | let mut buffer = BytesMut::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok(NetworkFrame::new(b'T', buffer.freeze())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/network_frame.rs:114:33 [INFO] [stdout] | [INFO] [stdout] 102 | let mut buffer = BytesMut::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | NetworkFrame::new(b'E', buffer.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constants/system_tables/pg_attribute.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 64 | let columns = get_columns(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let index = get_index(&columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Arc::new(Table::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 67 | | ID, [INFO] [stdout] 68 | | NAME.to_string(), [INFO] [stdout] 69 | | get_columns(), [INFO] [stdout] ... | [INFO] [stdout] 74 | | vec![index], [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constants/system_tables/pg_class.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 43 | let columns = get_columns(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let index = get_index(&columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Arc::new(Table::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 46 | | ID, [INFO] [stdout] 47 | | NAME.to_string(), [INFO] [stdout] 48 | | columns, [INFO] [stdout] ... | [INFO] [stdout] 53 | | vec![index], [INFO] [stdout] 54 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constants/system_tables/pg_constraint.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 64 | let columns = get_columns(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let index = get_index(&columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Arc::new(Table::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 67 | | ID, [INFO] [stdout] 68 | | NAME.to_string(), [INFO] [stdout] 69 | | columns, [INFO] [stdout] ... | [INFO] [stdout] 74 | | vec![index], [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constants/system_tables/pg_index.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 64 | let columns = get_columns(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let index = get_index(&columns); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Arc::new(Table::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 67 | | ID, [INFO] [stdout] 68 | | NAME.to_string(), [INFO] [stdout] 69 | | columns, [INFO] [stdout] ... | [INFO] [stdout] 74 | | vec![index], [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(file_manager: Arc, tran_manager: TransactionManager) -> Engine { [INFO] [stdout] | ------------------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let fsm = FreeSpaceManager::new(file_manager.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let vis_row_man = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | VisibleRowManager::new(RowManager::new(file_manager.clone(), fsm), tran_manager); [INFO] [stdout] 57 | let index_manager = IndexManager::new(file_manager); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let con_man = ConstraintManager::new(index_manager, vis_row_man.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Engine { [INFO] [stdout] 60 | analyzer: Analyzer::new(vis_row_man), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(file_manager: Arc, tran_manager: TransactionManager) -> Engine { [INFO] [stdout] | ------------------------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let fsm = FreeSpaceManager::new(file_manager.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let vis_row_man = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | VisibleRowManager::new(RowManager::new(file_manager.clone(), fsm), tran_manager); [INFO] [stdout] 57 | let index_manager = IndexManager::new(file_manager); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let con_man = ConstraintManager::new(index_manager, vis_row_man.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | executor: Executor::new(con_man), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/engine.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 108 | matches!(parse_tree.deref(), ParseTree::CreateTable(_)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseTree` does not implement `Deref`, so calling `deref` on `&ParseTree` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 108 - matches!(parse_tree.deref(), ParseTree::CreateTable(_)) [INFO] [stdout] 108 + matches!(parse_tree, ParseTree::CreateTable(_)) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseTree`, implement `Clone` for it [INFO] [stdout] --> src/engine/objects/parse_tree.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 + #[derive(Clone)] [INFO] [stdout] 5 | pub enum ParseTree { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/analyzer.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(vis_row_man: VisibleRowManager) -> Analyzer { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Analyzer { [INFO] [stdout] 28 | dl: DefinitionLookup::new(vis_row_man), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/analyzer.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 156 | provided: Vec<(Attribute, Option)>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | ) -> Result<(SqlTypeDefinition, SqlTuple), AnalyzerError> { [INFO] [stdout] 158 | let mut tbl_cols = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Ok((SqlTypeDefinition(tbl_cols), SqlTuple(val_cols))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/block_layer/file_manager2.rs:93:59 [INFO] [stdout] | [INFO] [stdout] 92 | let handle = FileOperations::open_path(&data_dir, &page_id, file_number).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok::>, FileManager2Error>(Arc::new(Mutex::const_new(handle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/block_layer/file_manager2.rs:125:69 [INFO] [stdout] | [INFO] [stdout] 123 | let handle = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | FileOperations::open_path(&data_dir, &page_id, file_number).await?; [INFO] [stdout] 125 | Ok::>, FileOperationsError>(Arc::new(Mutex::const_new( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 126 | | handle, [INFO] [stdout] 127 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/block_layer/file_manager2.rs:170:69 [INFO] [stdout] | [INFO] [stdout] 168 | let handle = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | FileOperations::open_path(&data_dir, &page_id, file_number).await?; [INFO] [stdout] 170 | Ok::>, FileOperationsError>(Arc::new(Mutex::const_new( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 171 | | handle, [INFO] [stdout] 172 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/block_layer/file_manager2.rs:207:59 [INFO] [stdout] | [INFO] [stdout] 206 | let handle = FileOperations::open_path(&data_dir, &page_id, file_number).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Ok::>, FileManager2Error>(Arc::new(Mutex::const_new(handle))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/index_formats/split_branch.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 22 | let middle = keys[middle_index].clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | [INFO] [stdout] 24 | let mut right_keys = vec![middle.clone(); keys.len() - middle_index - 1]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut right_pointers = vec![pointers[0].clone(); pointers.len() - middle_index - 1]; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok((middle, right_keys, right_pointers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/page_formats/page_data.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 110 | let mut rows: Vec = Vec::with_capacity(page_header.get_item_count()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(PageData { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | page, [INFO] [stdout] 126 | | page_header, [INFO] [stdout] 127 | | item_ids, [INFO] [stdout] 128 | | rows, [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/io/row_formats/row_data.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn parse(table: Arc, row_buffer: &mut impl Buf) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(RowData::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | table.sql_type.clone(), [INFO] [stdout] 104 | | min, [INFO] [stdout] 105 | | max, [INFO] [stdout] 106 | | item_pointer, [INFO] [stdout] 107 | | user_data, [INFO] [stdout] 108 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/objects/types/parse_type.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 26 | let sql_type = match matched { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok((input, sql_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/objects/types/sql_type_definition.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | .map(|a| (a.name.clone(), a.sql_type.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `feophant` (lib) due to 21 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "125f29e2857f43dfd6371173ee8be6d81485ab41a5ee6bb9bfef65779f43b1fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "125f29e2857f43dfd6371173ee8be6d81485ab41a5ee6bb9bfef65779f43b1fa", kill_on_drop: false }` [INFO] [stdout] 125f29e2857f43dfd6371173ee8be6d81485ab41a5ee6bb9bfef65779f43b1fa