[INFO] fetching crate fennec-vfs 0.1.8... [INFO] checking fennec-vfs-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fennec-vfs 0.1.8 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fennec-vfs 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fennec-vfs 0.1.8 [INFO] finished tweaking crates.io crate fennec-vfs 0.1.8 [INFO] tweaked toml for crates.io crate fennec-vfs 0.1.8 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding proptest-state-machine v0.1.0 (latest: v0.3.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b4bbc83a43051dfe7b753b46d80b2bf285e30b053f26fd8bca0165dda5d065c [INFO] running `Command { std: "docker" "start" "-a" "1b4bbc83a43051dfe7b753b46d80b2bf285e30b053f26fd8bca0165dda5d065c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b4bbc83a43051dfe7b753b46d80b2bf285e30b053f26fd8bca0165dda5d065c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b4bbc83a43051dfe7b753b46d80b2bf285e30b053f26fd8bca0165dda5d065c", kill_on_drop: false }` [INFO] [stdout] 1b4bbc83a43051dfe7b753b46d80b2bf285e30b053f26fd8bca0165dda5d065c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0b10230c3620f8867423b1045a7983b359d0648e40f94133b5b417f51381a45 [INFO] running `Command { std: "docker" "start" "-a" "b0b10230c3620f8867423b1045a7983b359d0648e40f94133b5b417f51381a45", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking fennec-common v0.1.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking proptest-state-machine v0.1.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking fennec-vfs v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 84 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Arc::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:560:38 [INFO] [stdout] | [INFO] [stdout] 560 | ... content: f.content.as_ref().unwrap_or(&EMPTY_CONTENT).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:581:38 [INFO] [stdout] | [INFO] [stdout] 581 | ... content: f [INFO] [stdout] | ________________________________^ [INFO] [stdout] 582 | | ... .content [INFO] [stdout] 583 | | ... .as_ref() [INFO] [stdout] 584 | | ... .expect("content must be set on all files in a package directory") [INFO] [stdout] 585 | | ... .clone(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:646:71 [INFO] [stdout] | [INFO] [stdout] 646 | ... entry.metadata().ok().and_then(|meta| meta.modified().ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fennec-vfs` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:88:12 [INFO] [stdout] | [INFO] [stdout] 84 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Arc::from(s)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:560:38 [INFO] [stdout] | [INFO] [stdout] 560 | ... content: f.content.as_ref().unwrap_or(&EMPTY_CONTENT).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:581:38 [INFO] [stdout] | [INFO] [stdout] 581 | ... content: f [INFO] [stdout] | ________________________________^ [INFO] [stdout] 582 | | ... .content [INFO] [stdout] 583 | | ... .as_ref() [INFO] [stdout] 584 | | ... .expect("content must be set on all files in a package directory") [INFO] [stdout] 585 | | ... .clone(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:646:71 [INFO] [stdout] | [INFO] [stdout] 646 | ... entry.metadata().ok().and_then(|meta| meta.modified().ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fennec-vfs` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b0b10230c3620f8867423b1045a7983b359d0648e40f94133b5b417f51381a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0b10230c3620f8867423b1045a7983b359d0648e40f94133b5b417f51381a45", kill_on_drop: false }` [INFO] [stdout] b0b10230c3620f8867423b1045a7983b359d0648e40f94133b5b417f51381a45