[INFO] fetching crate fedimint-portalloc 0.4.2-rc.3... [INFO] checking fedimint-portalloc-0.4.2-rc.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fedimint-portalloc 0.4.2-rc.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fedimint-portalloc 0.4.2-rc.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fedimint-portalloc 0.4.2-rc.3 [INFO] finished tweaking crates.io crate fedimint-portalloc 0.4.2-rc.3 [INFO] tweaked toml for crates.io crate fedimint-portalloc 0.4.2-rc.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 229 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding backon v0.4.4 (latest: v1.1.0) [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin v0.30.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (latest: v0.14.0) [INFO] [stderr] Adding bitcoin_hashes v0.12.0 (latest: v0.14.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniscript v10.2.0 (latest: v12.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding secp256k1 v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1 v0.27.0 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1-sys v0.8.1 (latest: v0.10.0) [INFO] [stderr] Adding secp256k1-zkp v0.9.2 (latest: v0.11.0) [INFO] [stderr] Adding secp256k1-zkp-sys v0.8.1 (latest: v0.10.0) [INFO] [stderr] Adding send_wrapper v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b380b09b8043c665ab85d033776c488da582a0c8e03ac64df24bcfde86c28bf1 [INFO] running `Command { std: "docker" "start" "-a" "b380b09b8043c665ab85d033776c488da582a0c8e03ac64df24bcfde86c28bf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b380b09b8043c665ab85d033776c488da582a0c8e03ac64df24bcfde86c28bf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b380b09b8043c665ab85d033776c488da582a0c8e03ac64df24bcfde86c28bf1", kill_on_drop: false }` [INFO] [stdout] b380b09b8043c665ab85d033776c488da582a0c8e03ac64df24bcfde86c28bf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 893a6b5194906e111e6abaa6a62b0b48a239b14f3f681f24c81aa90d6dc3b3b4 [INFO] running `Command { std: "docker" "start" "-a" "893a6b5194906e111e6abaa6a62b0b48a239b14f3f681f24c81aa90d6dc3b3b4", kill_on_drop: false }` [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Compiling secp256k1-sys v0.8.1 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling bitcoin v0.30.2 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bitcoin_hashes v0.12.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling secp256k1-zkp-sys v0.8.1 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking pairing v0.23.0 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking bitmaps v3.2.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking imbl-sized-chunks v0.1.2 [INFO] [stderr] Checking bls12_381 v0.8.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking jsonrpsee-types v0.24.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking secp256k1 v0.27.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.2.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking backon v0.4.4 [INFO] [stderr] Checking base64-url v3.0.0 [INFO] [stderr] Checking serdect v0.2.0 [INFO] [stderr] Checking jsonrpsee-core v0.24.3 [INFO] [stderr] Checking macro_rules_attribute v0.2.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking fedimint-threshold-crypto v0.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking imbl v3.0.0 [INFO] [stderr] Compiling fedimint-derive v0.4.2-rc.3 [INFO] [stderr] Checking fedimint-logging v0.4.2-rc.3 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking secp256k1-zkp v0.9.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking lightning v0.0.123 [INFO] [stderr] Checking miniscript v10.2.0 [INFO] [stderr] Checking lightning-invoice v0.31.0 [INFO] [stderr] Checking fedimint-core v0.4.2-rc.3 [INFO] [stderr] Checking fedimint-portalloc v0.4.2-rc.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let lock = util::open_lock_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | path, [INFO] [stdout] 28 | | lock_file: lock, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn with_lock(&mut self, f: impl FnOnce(&mut LockedRoot) -> Result) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | f(&mut LockedRoot::new(&self.path, &mut self.lock_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn store_to_file_with(path: &Path, f: F) -> io::Result> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fedimint-portalloc` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let lock = util::open_lock_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | path, [INFO] [stdout] 28 | | lock_file: lock, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn with_lock(&mut self, f: impl FnOnce(&mut LockedRoot) -> Result) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | f(&mut LockedRoot::new(&self.path, &mut self.lock_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn store_to_file_with(path: &Path, f: F) -> io::Result> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let mut file = std::fs::OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fedimint-portalloc` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "893a6b5194906e111e6abaa6a62b0b48a239b14f3f681f24c81aa90d6dc3b3b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "893a6b5194906e111e6abaa6a62b0b48a239b14f3f681f24c81aa90d6dc3b3b4", kill_on_drop: false }` [INFO] [stdout] 893a6b5194906e111e6abaa6a62b0b48a239b14f3f681f24c81aa90d6dc3b3b4