[INFO] fetching crate feattle-core 2.0.0... [INFO] checking feattle-core-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate feattle-core 2.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate feattle-core 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate feattle-core 2.0.0 [INFO] finished tweaking crates.io crate feattle-core 2.0.0 [INFO] tweaked toml for crates.io crate feattle-core 2.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84b427f693a7f1402793c8400307fea99d1ea0f95395a228a07c69027fc88948 [INFO] running `Command { std: "docker" "start" "-a" "84b427f693a7f1402793c8400307fea99d1ea0f95395a228a07c69027fc88948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84b427f693a7f1402793c8400307fea99d1ea0f95395a228a07c69027fc88948", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84b427f693a7f1402793c8400307fea99d1ea0f95395a228a07c69027fc88948", kill_on_drop: false }` [INFO] [stdout] 84b427f693a7f1402793c8400307fea99d1ea0f95395a228a07c69027fc88948 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f7fd8c512de247b50a6aeba1777701798db09232946e10d7c8dc5462112a0f0 [INFO] running `Command { std: "docker" "start" "-a" "1f7fd8c512de247b50a6aeba1777701798db09232946e10d7c8dc5462112a0f0", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking feattle-core v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/__internal.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(persistence: Arc, feattles_struct: FS) -> Self { [INFO] [stdout] | ----------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | inner_feattles: RwLock::new(InnerFeattles { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 68 | | last_reload: LastReload::Never, [INFO] [stdout] 69 | | current_values: None, [INFO] [stdout] 70 | | feattles_struct, [INFO] [stdout] 71 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/__internal.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(key: &'static str, description: &'static str, default: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | value: default.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:218:19 [INFO] [stdout] | [INFO] [stdout] 216 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | SerializedFormat { [INFO] [stdout] 218 | kind: SerializedFormatKind::List(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:241:19 [INFO] [stdout] | [INFO] [stdout] 239 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | SerializedFormat { [INFO] [stdout] 241 | kind: SerializedFormatKind::Set(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:286:19 [INFO] [stdout] | [INFO] [stdout] 284 | let fv = V::serialized_format(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | SerializedFormat { [INFO] [stdout] 286 | kind: SerializedFormatKind::Map(fk.kind, Box::new(fv.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:314:19 [INFO] [stdout] | [INFO] [stdout] 312 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | SerializedFormat { [INFO] [stdout] 314 | kind: SerializedFormatKind::Optional(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_reading.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn parsing(error: E) -> FromJsonError { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | FromJsonError::ParseError { [INFO] [stdout] 24 | cause: Box::new(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `feattle-core` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/__internal.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(persistence: Arc, feattles_struct: FS) -> Self { [INFO] [stdout] | ----------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | inner_feattles: RwLock::new(InnerFeattles { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 68 | | last_reload: LastReload::Never, [INFO] [stdout] 69 | | current_values: None, [INFO] [stdout] 70 | | feattles_struct, [INFO] [stdout] 71 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/__internal.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(key: &'static str, description: &'static str, default: T) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | value: default.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:218:19 [INFO] [stdout] | [INFO] [stdout] 216 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | SerializedFormat { [INFO] [stdout] 218 | kind: SerializedFormatKind::List(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:241:19 [INFO] [stdout] | [INFO] [stdout] 239 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | SerializedFormat { [INFO] [stdout] 241 | kind: SerializedFormatKind::Set(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:286:19 [INFO] [stdout] | [INFO] [stdout] 284 | let fv = V::serialized_format(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | SerializedFormat { [INFO] [stdout] 286 | kind: SerializedFormatKind::Map(fk.kind, Box::new(fv.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feattle_value.rs:314:19 [INFO] [stdout] | [INFO] [stdout] 312 | let f = T::serialized_format(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | SerializedFormat { [INFO] [stdout] 314 | kind: SerializedFormatKind::Optional(Box::new(f.kind)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_reading.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn parsing(error: E) -> FromJsonError { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | FromJsonError::ParseError { [INFO] [stdout] 24 | cause: Box::new(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:38 [INFO] [stdout] | [INFO] [stdout] 428 | self.get_error().map(|_| self.0.lock().current.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:439:26 [INFO] [stdout] | [INFO] [stdout] 439 | .map(|_| self.0.lock().history.get(key).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:154:23 [INFO] [stdout] | [INFO] [stdout] 153 | fn new(persistence: __internal::Arc) -> Self { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | $name(__internal::FeattlesImpl::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 155 | | persistence, [INFO] [stdout] 156 | | __Feattles { [INFO] [stdout] 157 | | $( [INFO] [stdout] ... | [INFO] [stdout] 164 | | }, [INFO] [stdout] 165 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | / feattles! { [INFO] [stdout] 446 | | struct Config { [INFO] [stdout] 447 | | /// A [INFO] [stdout] 448 | | a: i32, [INFO] [stdout] 449 | | b: i32 = 17 [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `feattles` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `feattle-core` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "1f7fd8c512de247b50a6aeba1777701798db09232946e10d7c8dc5462112a0f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f7fd8c512de247b50a6aeba1777701798db09232946e10d7c8dc5462112a0f0", kill_on_drop: false }` [INFO] [stdout] 1f7fd8c512de247b50a6aeba1777701798db09232946e10d7c8dc5462112a0f0