[INFO] fetching crate fcode 1.0.0... [INFO] checking fcode-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fcode 1.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate fcode 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fcode 1.0.0 [INFO] finished tweaking crates.io crate fcode 1.0.0 [INFO] tweaked toml for crates.io crate fcode 1.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate fcode 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a3e66d735bf8fe97b818e20726b24b251807f722209f0a9dba46f16e3e48e126 [INFO] running `Command { std: "docker" "start" "-a" "a3e66d735bf8fe97b818e20726b24b251807f722209f0a9dba46f16e3e48e126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a3e66d735bf8fe97b818e20726b24b251807f722209f0a9dba46f16e3e48e126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3e66d735bf8fe97b818e20726b24b251807f722209f0a9dba46f16e3e48e126", kill_on_drop: false }` [INFO] [stdout] a3e66d735bf8fe97b818e20726b24b251807f722209f0a9dba46f16e3e48e126 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69d99d0382c2067c894aed7761b881b9d82c1f9cd10ce34f61f064b44ba7ffcb [INFO] running `Command { std: "docker" "start" "-a" "69d99d0382c2067c894aed7761b881b9d82c1f9cd10ce34f61f064b44ba7ffcb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.63 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling prost-derive v0.7.0 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking prost v0.7.0 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking bincode v1.3.2 [INFO] [stderr] Checking fcode v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 99 | let value = T::deserialize(&mut de)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let consumed = data.len() - de.remaining_len(); [INFO] [stdout] 101 | Ok((value, consumed)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:332:21 [INFO] [stdout] | [INFO] [stdout] 326 | fn deserialize_seq>(self, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | visitor.visit_seq(SeqRead { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 333 | | d: self, [INFO] [stdout] 334 | | nread: n, [INFO] [stdout] 335 | | nreturn: n, [INFO] [stdout] 336 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:346:21 [INFO] [stdout] | [INFO] [stdout] 340 | fn deserialize_tuple>(self, len: usize, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | visitor.visit_seq(SeqRead { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 347 | | d: self, [INFO] [stdout] 348 | | nread: n, [INFO] [stdout] 349 | | nreturn: std::cmp::min(n, len), [INFO] [stdout] 350 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:373:21 [INFO] [stdout] | [INFO] [stdout] 364 | fn deserialize_map>(self, visitor: V) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | visitor.visit_map(SeqRead { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 374 | | d: self, [INFO] [stdout] 375 | | nread: n, [INFO] [stdout] 376 | | nreturn: n / 2, [INFO] [stdout] 377 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:427:6 [INFO] [stdout] | [INFO] [stdout] 416 | fn variant_seed>(self, seed: V) -> Result<(V::Value, Self::Variant)> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | let val = seed.deserialize(d)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 427 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 428 | | val, [INFO] [stdout] 429 | | SeqRead { [INFO] [stdout] 430 | | d: self, [INFO] [stdout] ... | [INFO] [stdout] 433 | | }, [INFO] [stdout] 434 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:468:6 [INFO] [stdout] | [INFO] [stdout] 461 | fn next_element_seed>(&mut self, seed: T) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 468 | Ok(Some(seed.deserialize(&mut *self.d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:511:6 [INFO] [stdout] | [INFO] [stdout] 504 | fn next_key_seed>(&mut self, seed: T) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | Ok(Some(seed.deserialize(&mut *self.d)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fcode` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "69d99d0382c2067c894aed7761b881b9d82c1f9cd10ce34f61f064b44ba7ffcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69d99d0382c2067c894aed7761b881b9d82c1f9cd10ce34f61f064b44ba7ffcb", kill_on_drop: false }` [INFO] [stdout] 69d99d0382c2067c894aed7761b881b9d82c1f9cd10ce34f61f064b44ba7ffcb