[INFO] fetching crate fbt-lib 0.1.18... [INFO] checking fbt-lib-0.1.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fbt-lib 0.1.18 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate fbt-lib 0.1.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fbt-lib 0.1.18 [INFO] finished tweaking crates.io crate fbt-lib 0.1.18 [INFO] tweaked toml for crates.io crate fbt-lib 0.1.18 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 140 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding comrak v0.7.0 (latest: v0.27.0) [INFO] [stderr] Adding diffy v0.2.2 (latest: v0.4.0) [INFO] [stderr] Adding fancy-regex v0.7.1 (latest: v0.13.0) [INFO] [stderr] Adding ftd v0.1.18 (latest: v0.2.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding lazy_static v0.1.16 (latest: v1.5.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding quick-xml v0.32.0 (latest: v0.36.1) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding syntect v4.6.0 (latest: v5.2.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding typed-arena v1.7.0 (latest: v2.0.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 68dbccd14f7b201f79902f359880eeb6194c87ff0b78a5fcb43a0c4205de76f6 [INFO] running `Command { std: "docker" "start" "-a" "68dbccd14f7b201f79902f359880eeb6194c87ff0b78a5fcb43a0c4205de76f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "68dbccd14f7b201f79902f359880eeb6194c87ff0b78a5fcb43a0c4205de76f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68dbccd14f7b201f79902f359880eeb6194c87ff0b78a5fcb43a0c4205de76f6", kill_on_drop: false }` [INFO] [stdout] 68dbccd14f7b201f79902f359880eeb6194c87ff0b78a5fcb43a0c4205de76f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4b696efb1125cf59fe99eaf90db8daa95c242ad7153869ac1d7df79d697c46c [INFO] running `Command { std: "docker" "start" "-a" "e4b696efb1125cf59fe99eaf90db8daa95c242ad7153869ac1d7df79d697c46c", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking typed-arena v1.7.0 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking css-color-parser v0.1.2 [INFO] [stderr] Checking diffy v0.2.2 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking twoway v0.2.2 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking include_dir v0.7.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fancy-regex v0.7.1 [INFO] [stderr] Checking format_num v0.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking comrak v0.7.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking syntect v4.6.0 [INFO] [stderr] Checking ftd v0.1.18 [INFO] [stderr] Checking fbt-lib v0.1.18 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:430:17 [INFO] [stdout] | [INFO] [stdout] 293 | Err(e) => return err(crate::Failure::CmdFileInvalid { error: e }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Err(e) if e.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | Err(e) => return err(crate::Failure::CantReadCmdFile { error: e }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | if let Err(e) = std::fs::remove_dir_all(&fbt) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | if let Err(e) = std::fs::create_dir_all(&fbt) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | if let Err(e) = crate::copy_dir::copy_dir_all(&input, &dir) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let mut child = match config.cmd().current_dir(&dir).spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | Err(io) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Err(io) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | result: match crate::dir_diff::diff(output, reference) { [INFO] [stdout] | _________________^ [INFO] [stdout] 431 | | Ok(Some(diff)) => { [INFO] [stdout] 432 | | return err(crate::Failure::OutputMismatch { diff }); [INFO] [stdout] 433 | | } [INFO] [stdout] 434 | | Ok(None) => Ok(true), [INFO] [stdout] 435 | | Err(e) => return err(crate::Failure::DirDiffError { error: e }), [INFO] [stdout] 436 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 283 | let err = |e: crate::Failure| crate::Case { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | id: id_.to_string(), [INFO] [stdout] 285 | result: Err(e), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:430:17 [INFO] [stdout] | [INFO] [stdout] 293 | Err(e) => return err(crate::Failure::CmdFileInvalid { error: e }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Err(e) if e.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | Err(e) => return err(crate::Failure::CantReadCmdFile { error: e }), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | if let Err(e) = std::fs::remove_dir_all(&fbt) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | if let Err(e) = std::fs::create_dir_all(&fbt) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | if let Err(e) = crate::copy_dir::copy_dir_all(&input, &dir) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let mut child = match config.cmd().current_dir(&dir).spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | Err(io) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Err(io) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | result: match crate::dir_diff::diff(output, reference) { [INFO] [stdout] | _________________^ [INFO] [stdout] 431 | | Ok(Some(diff)) => { [INFO] [stdout] 432 | | return err(crate::Failure::OutputMismatch { diff }); [INFO] [stdout] 433 | | } [INFO] [stdout] 434 | | Ok(None) => Ok(true), [INFO] [stdout] 435 | | Err(e) => return err(crate::Failure::DirDiffError { error: e }), [INFO] [stdout] 436 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 283 | let err = |e: crate::Failure| crate::Case { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | id: id_.to_string(), [INFO] [stdout] 285 | result: Err(e), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fbt-lib` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `fbt-lib` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "e4b696efb1125cf59fe99eaf90db8daa95c242ad7153869ac1d7df79d697c46c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4b696efb1125cf59fe99eaf90db8daa95c242ad7153869ac1d7df79d697c46c", kill_on_drop: false }` [INFO] [stdout] e4b696efb1125cf59fe99eaf90db8daa95c242ad7153869ac1d7df79d697c46c