[INFO] fetching crate fatfs 0.3.6... [INFO] checking fatfs-0.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fatfs 0.3.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fatfs 0.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fatfs 0.3.6 [INFO] finished tweaking crates.io crate fatfs 0.3.6 [INFO] tweaked toml for crates.io crate fatfs 0.3.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate fatfs 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a74a8d2a19ca41020596dfe3e91b46d3671ff374c09f8f39c208520e0c0fde2 [INFO] running `Command { std: "docker" "start" "-a" "0a74a8d2a19ca41020596dfe3e91b46d3671ff374c09f8f39c208520e0c0fde2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a74a8d2a19ca41020596dfe3e91b46d3671ff374c09f8f39c208520e0c0fde2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a74a8d2a19ca41020596dfe3e91b46d3671ff374c09f8f39c208520e0c0fde2", kill_on_drop: false }` [INFO] [stdout] 0a74a8d2a19ca41020596dfe3e91b46d3671ff374c09f8f39c208520e0c0fde2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47166239942f6ec7311f5615d628a42e7632e7b52fefa114c522261b4ca55cac [INFO] running `Command { std: "docker" "start" "-a" "47166239942f6ec7311f5615d628a42e7632e7b52fefa114c522261b4ca55cac", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking fscommon v0.1.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.23 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking fatfs v0.3.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | impl From for chrono::Date { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | impl From> for Date { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | chrono::Date::::from(date_time.date).and_hms_milli( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | fn from(date: chrono::Date) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/time.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | Local.ymd(date.year as i32, date.month as u32, date.day as u32) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms_milli`: Use and_hms_milli_opt() instead [INFO] [stdout] --> src/time.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | chrono::Date::::from(date_time.date).and_hms_milli( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/time.rs:110:40 [INFO] [stdout] | [INFO] [stdout] 110 | date: Date::from(date_time.date()), [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/time.rs:140:41 [INFO] [stdout] | [INFO] [stdout] 140 | Date::from(chrono::Local::now().date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:81:29 [INFO] [stdout] | [INFO] [stdout] 81 | impl From for chrono::Date { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | impl From> for Date { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | chrono::Date::::from(date_time.date).and_hms_milli( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime` instead [INFO] [stdout] --> src/time.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | fn from(date: chrono::Date) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 198 | Ok(e.to_file()) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 437 | let mut stream = self.find_free_entries(num_entries)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | Ok((stream, start_pos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn new(mut disk: T, options: FsOptions) -> io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Ok(FileSystem { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | disk: RefCell::new(disk), [INFO] [stdout] 346 | | options, [INFO] [stdout] 347 | | fat_type, [INFO] [stdout] ... | [INFO] [stdout] 353 | | current_status_flags: Cell::new(status_flags), [INFO] [stdout] 354 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fatfs` (lib) due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead [INFO] [stdout] --> src/time.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | Local.ymd(date.year as i32, date.month as u32, date.day as u32) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::Date::::and_hms_milli`: Use and_hms_milli_opt() instead [INFO] [stdout] --> src/time.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | chrono::Date::::from(date_time.date).and_hms_milli( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/time.rs:110:40 [INFO] [stdout] | [INFO] [stdout] 110 | date: Date::from(date_time.date()), [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::DateTime::::date`: Use `date_naive()` instead [INFO] [stdout] --> src/time.rs:140:41 [INFO] [stdout] | [INFO] [stdout] 140 | Date::from(chrono::Local::now().date()) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 198 | Ok(e.to_file()) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 437 | let mut stream = self.find_free_entries(num_entries)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | Ok((stream, start_pos)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn new(mut disk: T, options: FsOptions) -> io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Ok(FileSystem { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | disk: RefCell::new(disk), [INFO] [stdout] 346 | | options, [INFO] [stdout] 347 | | fat_type, [INFO] [stdout] ... | [INFO] [stdout] 353 | | current_status_flags: Cell::new(status_flags), [INFO] [stdout] 354 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fatfs` (lib test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "47166239942f6ec7311f5615d628a42e7632e7b52fefa114c522261b4ca55cac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47166239942f6ec7311f5615d628a42e7632e7b52fefa114c522261b4ca55cac", kill_on_drop: false }` [INFO] [stdout] 47166239942f6ec7311f5615d628a42e7632e7b52fefa114c522261b4ca55cac