[INFO] fetching crate fastping-rs 0.2.4... [INFO] checking fastping-rs-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fastping-rs 0.2.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate fastping-rs 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fastping-rs 0.2.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate fastping-rs 0.2.4 [INFO] tweaked toml for crates.io crate fastping-rs 0.2.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate fastping-rs 0.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd97f964fe84b547ce50a182b91be43e2c08cf0b823edfeeb66dadff8c9e2e8d [INFO] running `Command { std: "docker" "start" "-a" "dd97f964fe84b547ce50a182b91be43e2c08cf0b823edfeeb66dadff8c9e2e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd97f964fe84b547ce50a182b91be43e2c08cf0b823edfeeb66dadff8c9e2e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd97f964fe84b547ce50a182b91be43e2c08cf0b823edfeeb66dadff8c9e2e8d", kill_on_drop: false }` [INFO] [stdout] dd97f964fe84b547ce50a182b91be43e2c08cf0b823edfeeb66dadff8c9e2e8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c99f3256ade99e38ce2bc3ed41fd7ce6be1a68a3e4e5215af85d5b65e20a8988 [INFO] running `Command { std: "docker" "start" "-a" "c99f3256ade99e38ce2bc3ed41fd7ce6be1a68a3e4e5215af85d5b65e20a8988", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling serde v1.0.89 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling rustix v0.38.17 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Compiling pnet v0.34.0 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking pnet_macros_support v0.34.0 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking pnet_sys v0.34.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking pnet_datalink v0.34.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling pnet_macros v0.34.0 [INFO] [stderr] Checking pnet_packet v0.34.0 [INFO] [stderr] Checking pnet_transport v0.34.0 [INFO] [stderr] Checking fastping-rs v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:422:29 [INFO] [stdout] | [INFO] [stdout] 422 | ... _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:422:29 [INFO] [stdout] | [INFO] [stdout] 410 | ... PingResult::Idle { addr } => { [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 413 | ... PingResult::Receive { addr, rtt: _ } => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 422 | ... _ => { [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 80 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let (tx, rx) = match transport_channel(4096, protocol) { [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok((tx, rx)) => (tx, rx), [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (txv6, rxv6) = match transport_channel(4096, protocolv6) { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Ok((txv6, rxv6)) => (txv6, rxv6), [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let (thread_tx, thread_rx) = channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let mut pinger = Pinger { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok((pinger, receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastping-rs` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 80 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let (tx, rx) = match transport_channel(4096, protocol) { [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok((tx, rx)) => (tx, rx), [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let (txv6, rxv6) = match transport_channel(4096, protocolv6) { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Ok((txv6, rxv6)) => (txv6, rxv6), [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let (thread_tx, thread_rx) = channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let mut pinger = Pinger { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok((pinger, receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastping-rs` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "c99f3256ade99e38ce2bc3ed41fd7ce6be1a68a3e4e5215af85d5b65e20a8988", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c99f3256ade99e38ce2bc3ed41fd7ce6be1a68a3e4e5215af85d5b65e20a8988", kill_on_drop: false }` [INFO] [stdout] c99f3256ade99e38ce2bc3ed41fd7ce6be1a68a3e4e5215af85d5b65e20a8988