[INFO] fetching crate fastmod 0.4.4... [INFO] checking fastmod-0.4.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fastmod 0.4.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fastmod 0.4.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fastmod 0.4.4 [INFO] finished tweaking crates.io crate fastmod 0.4.4 [INFO] tweaked toml for crates.io crate fastmod 0.4.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate fastmod 0.4.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57f7472915d0631ca86f0f72c811db43100d93ca3e9d95d8f45e740e3d5715a9 [INFO] running `Command { std: "docker" "start" "-a" "57f7472915d0631ca86f0f72c811db43100d93ca3e9d95d8f45e740e3d5715a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57f7472915d0631ca86f0f72c811db43100d93ca3e9d95d8f45e740e3d5715a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57f7472915d0631ca86f0f72c811db43100d93ca3e9d95d8f45e740e3d5715a9", kill_on_drop: false }` [INFO] [stdout] 57f7472915d0631ca86f0f72c811db43100d93ca3e9d95d8f45e740e3d5715a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48c3ddcba93b3ace0af3a4d7039976c56007a82838603ed23aae9745968ebfc8 [INFO] running `Command { std: "docker" "start" "-a" "48c3ddcba93b3ace0af3a4d7039976c56007a82838603ed23aae9745968ebfc8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking grep-matcher v0.1.7 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking memmap2 v0.9.0 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking crossterm v0.24.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking rprompt v1.0.5 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking assert_cmd v1.0.8 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking grep-searcher v0.1.13 [INFO] [stderr] Checking grep-regex v0.1.12 [INFO] [stderr] Checking grep-cli v0.1.10 [INFO] [stderr] Checking ignore v0.4.21 [INFO] [stderr] Checking grep-printer v0.1.7 [INFO] [stderr] Checking grep v0.2.13 [INFO] [stderr] Checking fastmod v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:557:22 [INFO] [stdout] | [INFO] [stdout] 550 | let walk = walk_builder_with_file_set(dirs.clone(), file_set.clone())? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let thread_matcher = matcher.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | thread::spawn(|| { [INFO] [stdout] 557 | walk.run(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 558 | | let mut searcher = make_searcher(); [INFO] [stdout] 559 | | let tx = tx.clone(); [INFO] [stdout] 560 | | let matcher = thread_matcher.clone(); [INFO] [stdout] ... | [INFO] [stdout] 586 | | }) [INFO] [stdout] 587 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:561:26 [INFO] [stdout] | [INFO] [stdout] 554 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let thread_matcher = matcher.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let matcher = thread_matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | Box::new(move |result| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 562 | | let dirent = match result { [INFO] [stdout] 563 | | Ok(d) => d, [INFO] [stdout] 564 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 585 | | WalkState::Continue [INFO] [stdout] 586 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:679:22 [INFO] [stdout] | [INFO] [stdout] 664 | let matcher = matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 665 | let visited = Arc::new(visited); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 668 | let changed_files_inner = changed_files.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | let regex = regex.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 674 | let matcher = matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 675 | let subst = subst.to_string(); [INFO] [stdout] 676 | let visited = visited.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 677 | let changed_files = changed_files_inner.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 678 | let mut searcher = make_searcher(); [INFO] [stdout] 679 | Box::new(move |result| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 680 | | let dirent = match result { [INFO] [stdout] 681 | | Ok(d) => d, [INFO] [stdout] 682 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 714 | | WalkState::Continue [INFO] [stdout] 715 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastmod` (bin "fastmod") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:557:22 [INFO] [stdout] | [INFO] [stdout] 550 | let walk = walk_builder_with_file_set(dirs.clone(), file_set.clone())? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let thread_matcher = matcher.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | thread::spawn(|| { [INFO] [stdout] 557 | walk.run(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 558 | | let mut searcher = make_searcher(); [INFO] [stdout] 559 | | let tx = tx.clone(); [INFO] [stdout] 560 | | let matcher = thread_matcher.clone(); [INFO] [stdout] ... | [INFO] [stdout] 586 | | }) [INFO] [stdout] 587 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:561:26 [INFO] [stdout] | [INFO] [stdout] 554 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | let thread_matcher = matcher.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | let matcher = thread_matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | Box::new(move |result| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 562 | | let dirent = match result { [INFO] [stdout] 563 | | Ok(d) => d, [INFO] [stdout] 564 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 585 | | WalkState::Continue [INFO] [stdout] 586 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:679:22 [INFO] [stdout] | [INFO] [stdout] 664 | let matcher = matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 665 | let visited = Arc::new(visited); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 668 | let changed_files_inner = changed_files.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | let regex = regex.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 674 | let matcher = matcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 675 | let subst = subst.to_string(); [INFO] [stdout] 676 | let visited = visited.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 677 | let changed_files = changed_files_inner.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 678 | let mut searcher = make_searcher(); [INFO] [stdout] 679 | Box::new(move |result| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 680 | | let dirent = match result { [INFO] [stdout] 681 | | Ok(d) => d, [INFO] [stdout] 682 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 714 | | WalkState::Continue [INFO] [stdout] 715 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastmod` (bin "fastmod" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "48c3ddcba93b3ace0af3a4d7039976c56007a82838603ed23aae9745968ebfc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48c3ddcba93b3ace0af3a4d7039976c56007a82838603ed23aae9745968ebfc8", kill_on_drop: false }` [INFO] [stdout] 48c3ddcba93b3ace0af3a4d7039976c56007a82838603ed23aae9745968ebfc8