[INFO] fetching crate faster-build 0.5.0... [INFO] checking faster-build-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate faster-build 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate faster-build 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate faster-build 0.5.0 [INFO] finished tweaking crates.io crate faster-build 0.5.0 [INFO] tweaked toml for crates.io crate faster-build 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate faster-build 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3669e7624b58c4fd645204fa2ddc211335e3b07d07fab4bbb7a1abe527959a08 [INFO] running `Command { std: "docker" "start" "-a" "3669e7624b58c4fd645204fa2ddc211335e3b07d07fab4bbb7a1abe527959a08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3669e7624b58c4fd645204fa2ddc211335e3b07d07fab4bbb7a1abe527959a08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3669e7624b58c4fd645204fa2ddc211335e3b07d07fab4bbb7a1abe527959a08", kill_on_drop: false }` [INFO] [stdout] 3669e7624b58c4fd645204fa2ddc211335e3b07d07fab4bbb7a1abe527959a08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6e4b0c12568b020d70c4a29144408b70b75213574ce7ff46a41373d02bd1e2b [INFO] running `Command { std: "docker" "start" "-a" "e6e4b0c12568b020d70c4a29144408b70b75213574ce7ff46a41373d02bd1e2b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling snap v1.0.5 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking fixedbitset v0.4.1 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking petgraph v0.6.0 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking filetime v0.2.16 [INFO] [stderr] Checking shared_child v0.3.5 [INFO] [stderr] Checking nix v0.24.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking os_pipe v0.9.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking duct v0.13.5 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indicatif v0.17.0-rc.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking ctrlc v3.2.2 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking faster-build v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 284 | fn read_config

(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | serde_yaml::from_str(&contents).context("Failed to parse config file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 76 | | run_worker( [INFO] [stdout] 77 | | workdir, [INFO] [stdout] 78 | | &global_env, [INFO] [stdout] ... | [INFO] [stdout] 84 | | ) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | job_rx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:81:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | done_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | abort_rx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faster-build` (bin "faster") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 284 | fn read_config

(path: P) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | serde_yaml::from_str(&contents).context("Failed to parse config file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:75:27 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 76 | | run_worker( [INFO] [stdout] 77 | | workdir, [INFO] [stdout] 78 | | &global_env, [INFO] [stdout] ... | [INFO] [stdout] 84 | | ) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | job_rx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:81:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | done_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 68 | let job_rx = job_rx.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let done_tx = done_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let abort_rx = abort_rx.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let progress = progress.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | abort_rx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `faster-build` (bin "faster" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "e6e4b0c12568b020d70c4a29144408b70b75213574ce7ff46a41373d02bd1e2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6e4b0c12568b020d70c4a29144408b70b75213574ce7ff46a41373d02bd1e2b", kill_on_drop: false }` [INFO] [stdout] e6e4b0c12568b020d70c4a29144408b70b75213574ce7ff46a41373d02bd1e2b