[INFO] fetching crate fastanvil 0.31.0... [INFO] checking fastanvil-0.31.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fastanvil 0.31.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fastanvil 0.31.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fastanvil 0.31.0 [INFO] finished tweaking crates.io crate fastanvil 0.31.0 [INFO] tweaked toml for crates.io crate fastanvil 0.31.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate fastanvil 0.31.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d65cdc1fb33c3ed42c0a8362d0943861d26b2cbc1878474f6f25a34b84bf1c6 [INFO] running `Command { std: "docker" "start" "-a" "6d65cdc1fb33c3ed42c0a8362d0943861d26b2cbc1878474f6f25a34b84bf1c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d65cdc1fb33c3ed42c0a8362d0943861d26b2cbc1878474f6f25a34b84bf1c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d65cdc1fb33c3ed42c0a8362d0943861d26b2cbc1878474f6f25a34b84bf1c6", kill_on_drop: false }` [INFO] [stdout] 6d65cdc1fb33c3ed42c0a8362d0943861d26b2cbc1878474f6f25a34b84bf1c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a414b41550490163485b9a1c830e3989cdddc4ef15f76859814ebfa32f07c312 [INFO] running `Command { std: "docker" "start" "-a" "a414b41550490163485b9a1c830e3989cdddc4ef15f76859814ebfa32f07c312", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Compiling winnow v0.5.15 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking serde_bytes v0.11.12 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking fastnbt v2.4.4 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking fastanvil v0.31.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 34 | let file = match std::fs::File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let region = Region::from_stream(file).map_err(|e| LoaderError(e.to_string()))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | Ok(Some(region)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 61 | .filter(|path| fs::metadata(path).unwrap().len() > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java/pre13/mod.rs:56:14 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn set_custom_block_callback(f: CustomBlockCallback) -> CustomBlockCallback { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | std::mem::replace( [INFO] [stdout] 56 | &mut *CUSTOM_BLOCK_CALLBACK [INFO] [stdout] | ______________^ [INFO] [stdout] 57 | | .get_or_init(|| RwLock::new(Box::new(|_block_id, _data_value| None))) [INFO] [stdout] 58 | | .write() [INFO] [stdout] 59 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java/pre13/mod.rs:57:41 [INFO] [stdout] | [INFO] [stdout] 57 | .get_or_init(|| RwLock::new(Box::new(|_block_id, _data_value| None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java/pre13/mod.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 66 | .get_or_init(|| RwLock::new(Box::new(|_block_id, _data_value| None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/java/section_tower.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 48 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let sections: Vec = Deserialize::deserialize(deserializer)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | sections, [INFO] [stdout] 103 | | map: sparse_sections, [INFO] [stdout] 104 | | y_min: 16 * min, [INFO] [stdout] 105 | | y_max: 16 * (max + 1), [INFO] [stdout] 106 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/region.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 306 | pub fn new(mut stream: S) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | stream, [INFO] [stdout] 312 | | offsets: vec![2], // 2 is the end of the header [INFO] [stdout] 313 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastanvil` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a414b41550490163485b9a1c830e3989cdddc4ef15f76859814ebfa32f07c312", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a414b41550490163485b9a1c830e3989cdddc4ef15f76859814ebfa32f07c312", kill_on_drop: false }` [INFO] [stdout] a414b41550490163485b9a1c830e3989cdddc4ef15f76859814ebfa32f07c312