[INFO] fetching crate fart-cli 0.4.0... [INFO] checking fart-cli-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fart-cli 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fart-cli 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fart-cli 0.4.0 [INFO] finished tweaking crates.io crate fart-cli 0.4.0 [INFO] tweaked toml for crates.io crate fart-cli 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate fart-cli 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff6f13440c310526ca2cb9c3462dfad1201d820ea8d47a70c88eb04e48479d5b [INFO] running `Command { std: "docker" "start" "-a" "ff6f13440c310526ca2cb9c3462dfad1201d820ea8d47a70c88eb04e48479d5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff6f13440c310526ca2cb9c3462dfad1201d820ea8d47a70c88eb04e48479d5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff6f13440c310526ca2cb9c3462dfad1201d820ea8d47a70c88eb04e48479d5b", kill_on_drop: false }` [INFO] [stdout] ff6f13440c310526ca2cb9c3462dfad1201d820ea8d47a70c88eb04e48479d5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91f309cb61f26e70c8fcd4d2af45af66ebdb3299025ef21d0e759eaecb6f1cac [INFO] running `Command { std: "docker" "start" "-a" "91f309cb61f26e70c8fcd4d2af45af66ebdb3299025ef21d0e759eaecb6f1cac", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Checking futures-sink-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking futures-core-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling indexmap v1.3.0 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking futures-util-preview v0.3.0-alpha.19 [INFO] [stderr] Checking futures-channel-preview v0.3.0-alpha.19 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling hyper v0.12.35 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking data-encoding v2.1.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Compiling doc-comment v0.3.1 [INFO] [stderr] Compiling escargot v0.5.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking float-cmp v0.5.3 [INFO] [stderr] Checking filetime v0.2.8 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking broadcaster v0.2.6 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking mime v0.3.14 [INFO] [stderr] Checking route-recognizer v0.1.13 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking async-std v1.3.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking tokio-executor v0.1.9 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking notify v4.0.14 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-threadpool v0.1.17 [INFO] [stderr] Checking tokio-timer v0.2.12 [INFO] [stderr] Checking bytes v0.5.3 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking tokio-reactor v0.1.11 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking predicates v1.0.2 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking quickcheck v0.9.0 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling structopt-derive v0.3.5 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking structopt v0.3.5 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking http-service v0.4.0 [INFO] [stderr] Checking http-service-hyper v0.4.1 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking serde_qs v0.5.2 [INFO] [stderr] Checking tide v0.4.0 [INFO] [stderr] Checking fart-cli v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn build(dir: P, args: I, output: &mut Output) -> Result<()> [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | process::Command::new("cargo") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn run(dir: P, args: I, envs: E, output: &mut Output) -> Result<()> [INFO] [stdout] | ------ ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | process::Command::new("cargo") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_ext.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 54 | fn pipe_output(r: R, mut output: Output) -> thread::JoinHandle<()> [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 59 | | let do_read = move || -> Result<()> { [INFO] [stdout] 60 | | let mut r = io::BufReader::new(r); [INFO] [stdout] 61 | | io::copy(&mut r, &mut output)?; [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn add_all

(dir: P, output: &mut Output) -> Result<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 9 | process::Command::new("git") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn commit

(dir: P, msg: &str, output: &mut Output) -> Result<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | process::Command::new("git") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/mod.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 153 | fn call(&self, _cx: tide::Request) -> Self::Fut { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | futures::future::ready( [INFO] [stdout] 155 | / tide::Response::new(200) [INFO] [stdout] 156 | | .body_string(self.body.to_string()) [INFO] [stdout] 157 | | .set_header("Content-Type", self.content_type), [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serve/events.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 128 | let data = futures::ready!(self.as_mut().poll_fill_buf(cx))?; [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Poll::Ready(Ok(n)) [INFO] [stdout] | ^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new

(project: P) -> Watcher [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | output: Output::Inherit, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new

(project: P) -> Watcher [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | on_start: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watcher.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new

(project: P) -> Watcher [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | on_finish: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fart-cli` (bin "fart") due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "91f309cb61f26e70c8fcd4d2af45af66ebdb3299025ef21d0e759eaecb6f1cac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91f309cb61f26e70c8fcd4d2af45af66ebdb3299025ef21d0e759eaecb6f1cac", kill_on_drop: false }` [INFO] [stdout] 91f309cb61f26e70c8fcd4d2af45af66ebdb3299025ef21d0e759eaecb6f1cac