[INFO] fetching crate fancy-regex 0.13.0... [INFO] checking fancy-regex-0.13.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fancy-regex 0.13.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate fancy-regex 0.13.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fancy-regex 0.13.0 [INFO] finished tweaking crates.io crate fancy-regex 0.13.0 [INFO] tweaked toml for crates.io crate fancy-regex 0.13.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate fancy-regex 0.13.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7888cdd939928bf5895b3bf88073c879f79af7415ed67b671f0c36181730b3d8 [INFO] running `Command { std: "docker" "start" "-a" "7888cdd939928bf5895b3bf88073c879f79af7415ed67b671f0c36181730b3d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7888cdd939928bf5895b3bf88073c879f79af7415ed67b671f0c36181730b3d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7888cdd939928bf5895b3bf88073c879f79af7415ed67b671f0c36181730b3d8", kill_on_drop: false }` [INFO] [stdout] 7888cdd939928bf5895b3bf88073c879f79af7415ed67b671f0c36181730b3d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80cd70ea54381a8dd3ff7900b2218a4d7e0683c791c6388c154f95e19be70b65 [INFO] running `Command { std: "docker" "start" "-a" "80cd70ea54381a8dd3ff7900b2218a4d7e0683c791c6388c154f95e19be70b65", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling proc-macro2 v1.0.23 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Checking memchr v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking regex-syntax v0.8.0 [INFO] [stderr] Compiling io-lifetimes v1.0.1 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking either v1.0.0 [INFO] [stderr] Compiling rustix v0.37.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking dtoa v0.4.0 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking ciborium-io v0.2.0 [INFO] [stderr] Checking itoa v0.3.0 [INFO] [stderr] Checking linux-raw-sys v0.3.0 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking num-traits v0.1.32 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking ciborium-ll v0.2.0 [INFO] [stderr] Checking aho-corasick v1.0.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking same-file v1.0.1 [INFO] [stderr] Checking bit-vec v0.5.1 [INFO] [stderr] Checking walkdir v2.3.0 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Checking anes v0.1.4 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling memoffset v0.5.0 [INFO] [stderr] Checking clap v4.0.0 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking bit-set v0.5.0 [INFO] [stderr] Compiling quote v1.0.0 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking num_cpus v1.2.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking is-terminal v0.4.6 [INFO] [stderr] Checking regex v1.10.0 [INFO] [stderr] Checking fancy-regex v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking env_logger v0.8.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:365:14 [INFO] [stdout] | [INFO] [stdout] 345 | let captures = match self.0.re.captures_from_pos(self.0.text, self.0.last_end) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | Ok(Some(captures)) => captures, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | Some(Ok(captures)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 500 | let raw_tree = Expr::parse_tree(&options.pattern)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 504 | let tree = ExprTree { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | let prog = compile(&info)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | Ok(Regex { [INFO] [stdout] | ____________^ [INFO] [stdout] 543 | | inner: RegexImpl::Fancy { [INFO] [stdout] 544 | | prog, [INFO] [stdout] 545 | | n_groups: info.end_group, [INFO] [stdout] ... | [INFO] [stdout] 548 | | named_groups: Arc::new(tree.named_groups), [INFO] [stdout] 549 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:764:28 [INFO] [stdout] | [INFO] [stdout] 758 | let named_groups = self.named_groups.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 761 | let mut locations = inner.create_captures(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 764 | inner: CapturesImpl::Wrap { text, locations }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:778:32 [INFO] [stdout] | [INFO] [stdout] 758 | let named_groups = self.named_groups.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 778 | inner: CapturesImpl::Fancy { text, saves }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:520:8 [INFO] [stdout] | [INFO] [stdout] 517 | let mut c = Compiler::new(info.end_group); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 520 | Ok(c.b.build()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:573:12 [INFO] [stdout] | [INFO] [stdout] 571 | let compiled = compile_inner(&self.re, options)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | [INFO] [stdout] 573 | Ok(Insn::Delegate { [INFO] [stdout] | ____________^ [INFO] [stdout] 574 | | inner: compiled, [INFO] [stdout] 575 | | start_group, [INFO] [stdout] 576 | | end_group, [INFO] [stdout] 577 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 70 | let (ix, expr) = p.parse_re(0, 0)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(ExprTree { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | expr, [INFO] [stdout] 79 | | backrefs: Default::default(), [INFO] [stdout] 80 | | named_groups: p.named_groups, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 96 | let (ix, child) = self.parse_branch(ix, depth)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Ok((ix, child)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 136 | let (ix, child) = self.parse_atom(ix, depth)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok((ix, child)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:587:12 [INFO] [stdout] | [INFO] [stdout] 581 | let class = Expr::Delegate { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 587 | Ok((ix, class)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:643:12 [INFO] [stdout] | [INFO] [stdout] 636 | let (ix, child) = self.parse_re(ix, depth)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | let ix = self.check_for_close_paren(ix)?; [INFO] [stdout] 638 | let result = match (la, skip) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | Ok((ix, result)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:780:12 [INFO] [stdout] | [INFO] [stdout] 732 | let (mut next, condition) = if is_digit(b) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 742 | let (end, child) = self.parse_re(next, depth)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let if_true: Expr; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | let mut if_false: Expr = Expr::Empty; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 773 | let inner_condition = if let Expr::Backref(group) = condition { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 780 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 781 | | after, [INFO] [stdout] 782 | | if if_true == Expr::Empty && if_false == Expr::Empty { [INFO] [stdout] 783 | | inner_condition [INFO] [stdout] ... | [INFO] [stdout] 790 | | }, [INFO] [stdout] 791 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fancy-regex` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "80cd70ea54381a8dd3ff7900b2218a4d7e0683c791c6388c154f95e19be70b65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80cd70ea54381a8dd3ff7900b2218a4d7e0683c791c6388c154f95e19be70b65", kill_on_drop: false }` [INFO] [stdout] 80cd70ea54381a8dd3ff7900b2218a4d7e0683c791c6388c154f95e19be70b65