[INFO] fetching crate fallacy-hash 0.1.0... [INFO] checking fallacy-hash-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fallacy-hash 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fallacy-hash 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fallacy-hash 0.1.0 [INFO] finished tweaking crates.io crate fallacy-hash 0.1.0 [INFO] tweaked toml for crates.io crate fallacy-hash 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b0d1200a128093ef8dfbbb6dca1e2bc20c4183e6bcda47f83c73bdc4fb9a04b [INFO] running `Command { std: "docker" "start" "-a" "7b0d1200a128093ef8dfbbb6dca1e2bc20c4183e6bcda47f83c73bdc4fb9a04b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b0d1200a128093ef8dfbbb6dca1e2bc20c4183e6bcda47f83c73bdc4fb9a04b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b0d1200a128093ef8dfbbb6dca1e2bc20c4183e6bcda47f83c73bdc4fb9a04b", kill_on_drop: false }` [INFO] [stdout] 7b0d1200a128093ef8dfbbb6dca1e2bc20c4183e6bcda47f83c73bdc4fb9a04b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be66f7f4bfd36ea54b9debe0d188ffba0907055c5f442824483cd30b46dedf0c [INFO] running `Command { std: "docker" "start" "-a" "be66f7f4bfd36ea54b9debe0d188ffba0907055c5f442824483cd30b46dedf0c", kill_on_drop: false }` [INFO] [stderr] Compiling fallacy-alloc v0.1.0 [INFO] [stderr] Checking fallacy-hash v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn with_hasher(hash_builder: S) -> HashMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | HashMap(StdHashMap::with_hasher(hash_builder)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 184 | let mut m = StdHashMap::with_hasher(Default::default()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | m.try_reserve(capacity)?; [INFO] [stdout] 186 | Ok(HashMap(m)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn try_with_capacity_and_hasher(capacity: usize, hash_builder: S) -> Result, AllocError> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let mut m = StdHashMap::with_hasher(hash_builder); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | m.try_reserve(capacity)?; [INFO] [stdout] 206 | Ok(HashMap(m)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn try_entry(&mut self, key: K) -> Result, AllocError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | self.0.try_reserve(1)?; [INFO] [stdout] 227 | Ok(self.0.entry(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn try_insert(&mut self, k: K, v: V) -> Result, AllocError> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.0.try_reserve(1)?; [INFO] [stdout] 296 | Ok(self.0.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn with_hasher(hasher: S) -> HashSet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | HashSet(StdHashSet::with_hasher(hasher)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | let mut set = StdHashSet::with_hasher(Default::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | set.try_reserve(capacity)?; [INFO] [stdout] 133 | Ok(HashSet(set)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn try_with_capacity_and_hasher(capacity: usize, hasher: S) -> Result, AllocError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut set = StdHashSet::with_hasher(hasher); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | set.try_reserve(capacity)?; [INFO] [stdout] 153 | Ok(HashSet(set)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn replace(&mut self, value: T) -> Result, AllocError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | self.0.try_reserve(1)?; [INFO] [stdout] 214 | Ok(self.0.replace(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fallacy-hash` (lib test) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn with_hasher(hash_builder: S) -> HashMap { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | HashMap(StdHashMap::with_hasher(hash_builder)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 184 | let mut m = StdHashMap::with_hasher(Default::default()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | m.try_reserve(capacity)?; [INFO] [stdout] 186 | Ok(HashMap(m)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn try_with_capacity_and_hasher(capacity: usize, hash_builder: S) -> Result, AllocError> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let mut m = StdHashMap::with_hasher(hash_builder); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | m.try_reserve(capacity)?; [INFO] [stdout] 206 | Ok(HashMap(m)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn try_entry(&mut self, key: K) -> Result, AllocError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | self.0.try_reserve(1)?; [INFO] [stdout] 227 | Ok(self.0.entry(key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn try_insert(&mut self, k: K, v: V) -> Result, AllocError> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.0.try_reserve(1)?; [INFO] [stdout] 296 | Ok(self.0.insert(k, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn with_hasher(hasher: S) -> HashSet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | HashSet(StdHashSet::with_hasher(hasher)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | let mut set = StdHashSet::with_hasher(Default::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | set.try_reserve(capacity)?; [INFO] [stdout] 133 | Ok(HashSet(set)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn try_with_capacity_and_hasher(capacity: usize, hasher: S) -> Result, AllocError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut set = StdHashSet::with_hasher(hasher); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | set.try_reserve(capacity)?; [INFO] [stdout] 153 | Ok(HashSet(set)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn replace(&mut self, value: T) -> Result, AllocError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | self.0.try_reserve(1)?; [INFO] [stdout] 214 | Ok(self.0.replace(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fallacy-hash` (lib) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "be66f7f4bfd36ea54b9debe0d188ffba0907055c5f442824483cd30b46dedf0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be66f7f4bfd36ea54b9debe0d188ffba0907055c5f442824483cd30b46dedf0c", kill_on_drop: false }` [INFO] [stdout] be66f7f4bfd36ea54b9debe0d188ffba0907055c5f442824483cd30b46dedf0c