[INFO] fetching crate falcon-rust 0.1.2... [INFO] checking falcon-rust-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate falcon-rust 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate falcon-rust 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate falcon-rust 0.1.2 [INFO] finished tweaking crates.io crate falcon-rust 0.1.2 [INFO] tweaked toml for crates.io crate falcon-rust 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d83da20f3a41d6022d70e91b1c0f62c216f95c65e3b93f2b48b89c4b4a06c8f2 [INFO] running `Command { std: "docker" "start" "-a" "d83da20f3a41d6022d70e91b1c0f62c216f95c65e3b93f2b48b89c4b4a06c8f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d83da20f3a41d6022d70e91b1c0f62c216f95c65e3b93f2b48b89c4b4a06c8f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d83da20f3a41d6022d70e91b1c0f62c216f95c65e3b93f2b48b89c4b4a06c8f2", kill_on_drop: false }` [INFO] [stdout] d83da20f3a41d6022d70e91b1c0f62c216f95c65e3b93f2b48b89c4b4a06c8f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d760dcc787465e9f6898029623f79cf6917d3ce53184319f90ace5ee48bb6b0 [INFO] running `Command { std: "docker" "start" "-a" "3d760dcc787465e9f6898029623f79cf6917d3ce53184319f90ace5ee48bb6b0", kill_on_drop: false }` [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking falcon-rust v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated functions `power_of_two_inverse`, `primitive_root_of_unity`, `bitreverse_index`, `bitreversed_powers`, `bitreversed_powers_inverse`, and `bitreverse_array` are never used [INFO] [stdout] --> src/cyclotomic_fourier.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) trait CyclotomicFourier [INFO] [stdout] | ----------------- associated functions in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn power_of_two_inverse(n: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | fn primitive_root_of_unity(n: usize) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | fn bitreverse_index(arg: usize, n: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | fn bitreversed_powers(n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn bitreversed_powers_inverse(n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | fn bitreverse_array(array: &mut [T]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|(s, (l, h))| s.clone() - (l.clone() + h.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|(s, (l, h))| s.clone() - (l.clone() + h.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn map G>(&self, closure: C) -> Polynomial { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Polynomial::::new(self.coefficients.iter().map(closure).collect_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:252:22 [INFO] [stdout] | [INFO] [stdout] 241 | let mut f0_coefficients = vec![F::zero(); n / 2]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let mut f1_coefficients = vec![F::zero(); n / 2]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let f0 = Polynomial::new(f0_coefficients); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let f1 = Polynomial::new(f1_coefficients); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let f0_squared = (f0.clone() * f0).reduce_by_cyclotomic(n / 2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let f1_squared = (f1.clone() * f1).reduce_by_cyclotomic(n / 2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let x = Polynomial::new(vec![F::zero(), F::one()]); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | f0_squared - (x * f1_squared).reduce_by_cyclotomic(n / 2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | .map(|i| Into::::into(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:337:40 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|i| Into::::into(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:444:16 [INFO] [stdout] | [INFO] [stdout] 443 | fn sub(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | self + (-rhs) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:471:27 [INFO] [stdout] | [INFO] [stdout] 469 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | Self::Output { [INFO] [stdout] 471 | coefficients: self.coefficients.iter().cloned().map(|a| -a).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:523:27 [INFO] [stdout] | [INFO] [stdout] 521 | fn mul(self, other: F) -> Self::Output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | Polynomial { [INFO] [stdout] 523 | coefficients: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 524 | | .coefficients [INFO] [stdout] 525 | | .iter() [INFO] [stdout] 526 | | .cloned() [INFO] [stdout] 527 | | .map(|i| i * other.clone()) [INFO] [stdout] 528 | | .collect_vec(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:527:30 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|i| i * other.clone()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:537:27 [INFO] [stdout] | [INFO] [stdout] 535 | fn mul(self, other: F) -> Self::Output { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 536 | Polynomial { [INFO] [stdout] 537 | coefficients: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 538 | | .coefficients [INFO] [stdout] 539 | | .iter() [INFO] [stdout] 540 | | .cloned() [INFO] [stdout] 541 | | .map(|i| i * other.clone()) [INFO] [stdout] 542 | | .collect_vec(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:541:30 [INFO] [stdout] | [INFO] [stdout] 541 | .map(|i| i * other.clone()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falcon-rust` (lib) due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `power_of_two_inverse` is never used [INFO] [stdout] --> src/cyclotomic_fourier.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) trait CyclotomicFourier [INFO] [stdout] | ----------------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn power_of_two_inverse(n: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:77:23 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|(a, b)| a.clone() + b.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|(s, (l, h))| s.clone() - (l.clone() + h.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|(s, (l, h))| s.clone() - (l.clone() + h.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn map G>(&self, closure: C) -> Polynomial { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Polynomial::::new(self.coefficients.iter().map(closure).collect_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:252:22 [INFO] [stdout] | [INFO] [stdout] 241 | let mut f0_coefficients = vec![F::zero(); n / 2]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let mut f1_coefficients = vec![F::zero(); n / 2]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let f0 = Polynomial::new(f0_coefficients); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let f1 = Polynomial::new(f1_coefficients); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let f0_squared = (f0.clone() * f0).reduce_by_cyclotomic(n / 2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let f1_squared = (f1.clone() * f1).reduce_by_cyclotomic(n / 2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let x = Polynomial::new(vec![F::zero(), F::one()]); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | f0_squared - (x * f1_squared).reduce_by_cyclotomic(n / 2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:329:40 [INFO] [stdout] | [INFO] [stdout] 329 | .map(|i| Into::::into(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:337:40 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|i| Into::::into(i.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:444:16 [INFO] [stdout] | [INFO] [stdout] 443 | fn sub(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | self + (-rhs) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:471:27 [INFO] [stdout] | [INFO] [stdout] 469 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | Self::Output { [INFO] [stdout] 471 | coefficients: self.coefficients.iter().cloned().map(|a| -a).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:523:27 [INFO] [stdout] | [INFO] [stdout] 521 | fn mul(self, other: F) -> Self::Output { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | Polynomial { [INFO] [stdout] 523 | coefficients: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 524 | | .coefficients [INFO] [stdout] 525 | | .iter() [INFO] [stdout] 526 | | .cloned() [INFO] [stdout] 527 | | .map(|i| i * other.clone()) [INFO] [stdout] 528 | | .collect_vec(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:527:30 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|i| i * other.clone()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:537:27 [INFO] [stdout] | [INFO] [stdout] 535 | fn mul(self, other: F) -> Self::Output { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 536 | Polynomial { [INFO] [stdout] 537 | coefficients: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 538 | | .coefficients [INFO] [stdout] 539 | | .iter() [INFO] [stdout] 540 | | .cloned() [INFO] [stdout] 541 | | .map(|i| i * other.clone()) [INFO] [stdout] 542 | | .collect_vec(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polynomial.rs:541:30 [INFO] [stdout] | [INFO] [stdout] 541 | .map(|i| i * other.clone()) [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falcon-rust` (lib test) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3d760dcc787465e9f6898029623f79cf6917d3ce53184319f90ace5ee48bb6b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d760dcc787465e9f6898029623f79cf6917d3ce53184319f90ace5ee48bb6b0", kill_on_drop: false }` [INFO] [stdout] 3d760dcc787465e9f6898029623f79cf6917d3ce53184319f90ace5ee48bb6b0