[INFO] fetching crate falco_plugin 0.2.0... [INFO] checking falco_plugin-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate falco_plugin 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate falco_plugin 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate falco_plugin 0.2.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate falco_plugin 0.2.0 [INFO] tweaked toml for crates.io crate falco_plugin 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate falco_plugin 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `async_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `extract2_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `extract_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `parse_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `source_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `static_source_plugin` example target) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab9466c74392d4704ba946a58ce576f1125a724514bad77444bc916c4bd01a5c [INFO] running `Command { std: "docker" "start" "-a" "ab9466c74392d4704ba946a58ce576f1125a724514bad77444bc916c4bd01a5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab9466c74392d4704ba946a58ce576f1125a724514bad77444bc916c4bd01a5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab9466c74392d4704ba946a58ce576f1125a724514bad77444bc916c4bd01a5c", kill_on_drop: false }` [INFO] [stdout] ab9466c74392d4704ba946a58ce576f1125a724514bad77444bc916c4bd01a5c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 721b73878a4d957eb44ad2312e0965e6dbc35657324415c5f8097757c2d1ce19 [INFO] running `Command { std: "docker" "start" "-a" "721b73878a4d957eb44ad2312e0965e6dbc35657324415c5f8097757c2d1ce19", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `async_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `extract2_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `extract_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `parse_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `source_plugin` example target) [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `static_source_plugin` example target) [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling schemars v0.8.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking falco_plugin_api v0.1.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling falco_event_derive v0.1.1 [INFO] [stderr] Compiling falco_plugin_derive v0.1.1 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Compiling schemars_derive v0.8.16 [INFO] [stderr] Checking falco_event v0.1.1 [INFO] [stderr] Checking falco_plugin v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/mod.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(plugin: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | error_buf: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/mod.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(plugin: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | string_storage: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/wrappers.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 116 | let config = P::ConfigType::from_str(init_config).map_err(|_| FailureReason::Failure)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | P::new(init_input, config).map(|plugin| Box::into_raw(Box::new(PluginWrapper::new(plugin)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/wrappers.rs:126:63 [INFO] [stdout] | [INFO] [stdout] 126 | P::new(init_input, config).map(|plugin| Box::into_raw(Box::new(PluginWrapper::new(plugin)))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/mod.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(plugin: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | error_buf: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/mod.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(plugin: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | string_storage: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/wrappers.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 116 | let config = P::ConfigType::from_str(init_config).map_err(|_| FailureReason::Failure)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | P::new(init_input, config).map(|plugin| Box::into_raw(Box::new(PluginWrapper::new(plugin)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/base/wrappers.rs:126:63 [INFO] [stdout] | [INFO] [stdout] 126 | P::new(init_input, config).map(|plugin| Box::into_raw(Box::new(PluginWrapper::new(plugin)))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/schema.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 71 | let target: T = serde_json::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(Json(target)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/schema.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 71 | let target: T = serde_json::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(Json(target)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/tables/table.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 177 | mut func: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | / move |s: *mut ss_plugin_table_entry_t| { [INFO] [stdout] 190 | | // Do not call the destructor on TableEntryReader: we do not have [INFO] [stdout] 191 | | // our own refcount for it, just borrowing [INFO] [stdout] 192 | | let mut entry = ManuallyDrop::new(TableEntryReader { [INFO] [stdout] ... | [INFO] [stdout] 200 | | func(&mut entry) [INFO] [stdout] 201 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/tables/table.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 209 | mut func: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | / move |s: *mut ss_plugin_table_entry_t| { [INFO] [stdout] 222 | | // Do not call the destructor on TableEntryReader: we do not have [INFO] [stdout] 223 | | // our own refcount for it, just borrowing [INFO] [stdout] 224 | | let mut entry = ManuallyDrop::new( [INFO] [stdout] ... | [INFO] [stdout] 235 | | func(&mut entry) [INFO] [stdout] 236 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/tables/table.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 177 | mut func: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | / move |s: *mut ss_plugin_table_entry_t| { [INFO] [stdout] 190 | | // Do not call the destructor on TableEntryReader: we do not have [INFO] [stdout] 191 | | // our own refcount for it, just borrowing [INFO] [stdout] 192 | | let mut entry = ManuallyDrop::new(TableEntryReader { [INFO] [stdout] ... | [INFO] [stdout] 200 | | func(&mut entry) [INFO] [stdout] 201 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/tables/table.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 209 | mut func: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | / move |s: *mut ss_plugin_table_entry_t| { [INFO] [stdout] 222 | | // Do not call the destructor on TableEntryReader: we do not have [INFO] [stdout] 223 | | // our own refcount for it, just borrowing [INFO] [stdout] 224 | | let mut entry = ManuallyDrop::new( [INFO] [stdout] ... | [INFO] [stdout] 235 | | func(&mut entry) [INFO] [stdout] 236 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falco_plugin` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `falco_plugin` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "721b73878a4d957eb44ad2312e0965e6dbc35657324415c5f8097757c2d1ce19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "721b73878a4d957eb44ad2312e0965e6dbc35657324415c5f8097757c2d1ce19", kill_on_drop: false }` [INFO] [stdout] 721b73878a4d957eb44ad2312e0965e6dbc35657324415c5f8097757c2d1ce19