[INFO] fetching crate falco_event 0.1.1... [INFO] checking falco_event-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate falco_event 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate falco_event 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate falco_event 0.1.1 [INFO] finished tweaking crates.io crate falco_event 0.1.1 [INFO] tweaked toml for crates.io crate falco_event 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f06b9b9dec180a83f968dc672e5651221357a238595aac57ccd9c935a0416fb [INFO] running `Command { std: "docker" "start" "-a" "6f06b9b9dec180a83f968dc672e5651221357a238595aac57ccd9c935a0416fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f06b9b9dec180a83f968dc672e5651221357a238595aac57ccd9c935a0416fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f06b9b9dec180a83f968dc672e5651221357a238595aac57ccd9c935a0416fb", kill_on_drop: false }` [INFO] [stdout] 6f06b9b9dec180a83f968dc672e5651221357a238595aac57ccd9c935a0416fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21b6112f7bd606a21947d75c7b2913d2b11da186091439273d3d1222b48748a4 [INFO] running `Command { std: "docker" "start" "-a" "21b6112f7bd606a21947d75c7b2913d2b11da186091439273d3d1222b48748a4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking falco_plugin_api v0.1.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking hexdump v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling falco_event_derive v0.1.1 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking falco_event v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 54 | let params = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Event { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | metadata: self.metadata.clone(), [INFO] [stdout] 63 | | params, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:75:36 [INFO] [stdout] | [INFO] [stdout] 75 | std::iter::from_fn(move || buf.read_uint::(size).ok().map(|s| s as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 91 | let mut lengths = Self::lengths::(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | [INFO] [stdout] 93 | Ok(std::iter::from_fn(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | let len = lengths.next()?; [INFO] [stdout] 95 | | if len > params.len() { [INFO] [stdout] 96 | | // truncated event, do not return the param fragment, if any [INFO] [stdout] ... | [INFO] [stdout] 101 | | Some(Ok(param)) [INFO] [stdout] 102 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 91 | let mut lengths = Self::lengths::(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Some(Ok(param)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields/to_bytes.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&self, _writer: W) -> std::io::Result<()> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Err(std::io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | std::io::ErrorKind::InvalidData, [INFO] [stdout] 34 | | "field cannot be empty when writing", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 54 | let params = unsafe { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Event { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | metadata: self.metadata.clone(), [INFO] [stdout] 63 | | params, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:75:36 [INFO] [stdout] | [INFO] [stdout] 75 | std::iter::from_fn(move || buf.read_uint::(size).ok().map(|s| s as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 91 | let mut lengths = Self::lengths::(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | [INFO] [stdout] 93 | Ok(std::iter::from_fn(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | let len = lengths.next()?; [INFO] [stdout] 95 | | if len > params.len() { [INFO] [stdout] 96 | | // truncated event, do not return the param fragment, if any [INFO] [stdout] ... | [INFO] [stdout] 101 | | Some(Ok(param)) [INFO] [stdout] 102 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/raw_event.rs:101:18 [INFO] [stdout] | [INFO] [stdout] 91 | let mut lengths = Self::lengths::(lengths); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Some(Ok(param)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fields/to_bytes.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 31 | fn write(&self, _writer: W) -> std::io::Result<()> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Err(std::io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 33 | | std::io::ErrorKind::InvalidData, [INFO] [stdout] 34 | | "field cannot be empty when writing", [INFO] [stdout] 35 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falco_event` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `falco_event` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "21b6112f7bd606a21947d75c7b2913d2b11da186091439273d3d1222b48748a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21b6112f7bd606a21947d75c7b2913d2b11da186091439273d3d1222b48748a4", kill_on_drop: false }` [INFO] [stdout] 21b6112f7bd606a21947d75c7b2913d2b11da186091439273d3d1222b48748a4