[INFO] fetching crate fahrenheit 4.5.4... [INFO] checking fahrenheit-4.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fahrenheit 4.5.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fahrenheit 4.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fahrenheit 4.5.4 [INFO] finished tweaking crates.io crate fahrenheit 4.5.4 [INFO] tweaked toml for crates.io crate fahrenheit 4.5.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate fahrenheit 4.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f9e1a00259888110786bd84c9ee824f427979433db567938869ed5a5e333e49 [INFO] running `Command { std: "docker" "start" "-a" "4f9e1a00259888110786bd84c9ee824f427979433db567938869ed5a5e333e49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f9e1a00259888110786bd84c9ee824f427979433db567938869ed5a5e333e49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f9e1a00259888110786bd84c9ee824f427979433db567938869ed5a5e333e49", kill_on_drop: false }` [INFO] [stdout] 4f9e1a00259888110786bd84c9ee824f427979433db567938869ed5a5e333e49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1cdfd9aa200ab818dd8dac4531ebccbceb4d62498aeed694e271ef2065d562d [INFO] running `Command { std: "docker" "start" "-a" "d1cdfd9aa200ab818dd8dac4531ebccbceb4d62498aeed694e271ef2065d562d", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking fahrenheit v4.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn run + Send + 'static>(f: F) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | REACTOR.with(|reactor| reactor.run(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn spawn + Send + 'static>(f: F) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | REACTOR.with(|reactor| reactor.do_spawn(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 150 | let w = Arc::new(Token(counter)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | self.counter.set(counter + 1); [INFO] [stdout] 152 | (counter, futures::task::waker(w)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_listener.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn bind(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let inner = TcpListener::bind(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(AsyncTcpListener(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_listener.rs:50:70 [INFO] [stdout] | [INFO] [stdout] 50 | REACTOR.with(|reactor| reactor.add_read_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn connect(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let inner = TcpStream::connect(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(AsyncTcpStream(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn from_std(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | stream.set_nonblocking(true)?; [INFO] [stdout] 31 | Ok(AsyncTcpStream(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:59:70 [INFO] [stdout] | [INFO] [stdout] 59 | REACTOR.with(|reactor| reactor.add_read_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:82:71 [INFO] [stdout] | [INFO] [stdout] 82 | REACTOR.with(|reactor| reactor.add_write_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn run + Send + 'static>(f: F) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | REACTOR.with(|reactor| reactor.run(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fahrenheit` (lib test) due to 10 previous errors [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn spawn + Send + 'static>(f: F) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | REACTOR.with(|reactor| reactor.do_spawn(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 150 | let w = Arc::new(Token(counter)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | self.counter.set(counter + 1); [INFO] [stdout] 152 | (counter, futures::task::waker(w)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_listener.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn bind(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let inner = TcpListener::bind(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(AsyncTcpListener(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_listener.rs:50:70 [INFO] [stdout] | [INFO] [stdout] 50 | REACTOR.with(|reactor| reactor.add_read_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn connect(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let inner = TcpStream::connect(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(AsyncTcpStream(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn from_std(stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | stream.set_nonblocking(true)?; [INFO] [stdout] 31 | Ok(AsyncTcpStream(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:59:70 [INFO] [stdout] | [INFO] [stdout] 59 | REACTOR.with(|reactor| reactor.add_read_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_tcp_stream.rs:82:71 [INFO] [stdout] | [INFO] [stdout] 82 | REACTOR.with(|reactor| reactor.add_write_interest(fd, waker.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fahrenheit` (lib) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "d1cdfd9aa200ab818dd8dac4531ebccbceb4d62498aeed694e271ef2065d562d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1cdfd9aa200ab818dd8dac4531ebccbceb4d62498aeed694e271ef2065d562d", kill_on_drop: false }` [INFO] [stdout] d1cdfd9aa200ab818dd8dac4531ebccbceb4d62498aeed694e271ef2065d562d