[INFO] fetching crate factorio-mod-api 0.3.0... [INFO] checking factorio-mod-api-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate factorio-mod-api 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate factorio-mod-api 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate factorio-mod-api 0.3.0 [INFO] finished tweaking crates.io crate factorio-mod-api 0.3.0 [INFO] tweaked toml for crates.io crate factorio-mod-api 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 148 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed55afc1782f738e100011ac268e001703172ae6fcca9c21c6bd6daf1ff6c68e [INFO] running `Command { std: "docker" "start" "-a" "ed55afc1782f738e100011ac268e001703172ae6fcca9c21c6bd6daf1ff6c68e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed55afc1782f738e100011ac268e001703172ae6fcca9c21c6bd6daf1ff6c68e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed55afc1782f738e100011ac268e001703172ae6fcca9c21c6bd6daf1ff6c68e", kill_on_drop: false }` [INFO] [stdout] ed55afc1782f738e100011ac268e001703172ae6fcca9c21c6bd6daf1ff6c68e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0355853dfcc4c769f2cb6efdd6294d7e01bc6173d3e08bf40324dd27f6c53b5 [INFO] running `Command { std: "docker" "start" "-a" "d0355853dfcc4c769f2cb6efdd6294d7e01bc6173d3e08bf40324dd27f6c53b5", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking elsa v1.10.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex-macro v0.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking factorio-mod-api v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn with_client(client: reqwest::Client) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(ModPortalClient { client, specs: FrozenMap::new() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 223 | let caps = re [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(ModDependency { [INFO] [stdout] | ____________^ [INFO] [stdout] 228 | | flavor: caps [INFO] [stdout] 229 | | .name("prefix") [INFO] [stdout] 230 | | .map(|prefix| ModDependencyFlavor::from_str(prefix.as_str()).unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 236 | | .transpose()?, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorio-mod-api` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn with_client(client: reqwest::Client) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(ModPortalClient { client, specs: FrozenMap::new() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 223 | let caps = re [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(ModDependency { [INFO] [stdout] | ____________^ [INFO] [stdout] 228 | | flavor: caps [INFO] [stdout] 229 | | .name("prefix") [INFO] [stdout] 230 | | .map(|prefix| ModDependencyFlavor::from_str(prefix.as_str()).unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 236 | | .transpose()?, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorio-mod-api` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "d0355853dfcc4c769f2cb6efdd6294d7e01bc6173d3e08bf40324dd27f6c53b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0355853dfcc4c769f2cb6efdd6294d7e01bc6173d3e08bf40324dd27f6c53b5", kill_on_drop: false }` [INFO] [stdout] d0355853dfcc4c769f2cb6efdd6294d7e01bc6173d3e08bf40324dd27f6c53b5