[INFO] fetching crate factorio-exporter 0.9.0... [INFO] checking factorio-exporter-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate factorio-exporter 0.9.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate factorio-exporter 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate factorio-exporter 0.9.0 [INFO] finished tweaking crates.io crate factorio-exporter 0.9.0 [INFO] tweaked toml for crates.io crate factorio-exporter 0.9.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive_builder v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.11.2 (latest: v0.20.1) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2096cf69d7124c6d2da28dc233109af2e1c39ecf758af6b8bf671ad9d9233cee [INFO] running `Command { std: "docker" "start" "-a" "2096cf69d7124c6d2da28dc233109af2e1c39ecf758af6b8bf671ad9d9233cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2096cf69d7124c6d2da28dc233109af2e1c39ecf758af6b8bf671ad9d9233cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2096cf69d7124c6d2da28dc233109af2e1c39ecf758af6b8bf671ad9d9233cee", kill_on_drop: false }` [INFO] [stdout] 2096cf69d7124c6d2da28dc233109af2e1c39ecf758af6b8bf671ad9d9233cee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff7c0561082739ed4dfa9317aa38a65246a4b4746a0187dda2489483402df0c5 [INFO] running `Command { std: "docker" "start" "-a" "ff7c0561082739ed4dfa9317aa38a65246a4b4746a0187dda2489483402df0c5", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking regex-macro v0.2.0 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking factorio-exporter v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(raw: RawApi) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | classes: raw.classes.into_iter().map(|class| (class.name.clone(), class)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(raw: RawApi) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | concepts: raw [INFO] [stdout] | _______________________^ [INFO] [stdout] 83 | | .concepts [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|concept| (concept.name.clone(), concept)) [INFO] [stdout] 86 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 130 | fn from(raw: RawClass) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | attributes: raw.attributes.into_iter().map(|attr| (attr.name.clone(), attr)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exporter.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let temp_dir = tempfile::Builder::new().prefix(MOD_NAME).tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let mod_controller = ModController::new(temp_dir.path().join(MODS_DIR)); [INFO] [stdout] 65 | Ok(FactorioExporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | factorio_binary, [INFO] [stdout] 67 | | api, [INFO] [stdout] 68 | | locale, [INFO] [stdout] ... | [INFO] [stdout] 71 | | export_icons, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorio-exporter` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(raw: RawApi) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | classes: raw.classes.into_iter().map(|class| (class.name.clone(), class)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(raw: RawApi) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | concepts: raw [INFO] [stdout] | _______________________^ [INFO] [stdout] 83 | | .concepts [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|concept| (concept.name.clone(), concept)) [INFO] [stdout] 86 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 130 | fn from(raw: RawClass) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | attributes: raw.attributes.into_iter().map(|attr| (attr.name.clone(), attr)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exporter.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let temp_dir = tempfile::Builder::new().prefix(MOD_NAME).tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let mod_controller = ModController::new(temp_dir.path().join(MODS_DIR)); [INFO] [stdout] 65 | Ok(FactorioExporter { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | factorio_binary, [INFO] [stdout] 67 | | api, [INFO] [stdout] 68 | | locale, [INFO] [stdout] ... | [INFO] [stdout] 71 | | export_icons, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorio-exporter` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "ff7c0561082739ed4dfa9317aa38a65246a4b4746a0187dda2489483402df0c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff7c0561082739ed4dfa9317aa38a65246a4b4746a0187dda2489483402df0c5", kill_on_drop: false }` [INFO] [stdout] ff7c0561082739ed4dfa9317aa38a65246a4b4746a0187dda2489483402df0c5