[INFO] fetching crate factorial 0.4.0... [INFO] checking factorial-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate factorial 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate factorial 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate factorial 0.4.0 [INFO] finished tweaking crates.io crate factorial 0.4.0 [INFO] tweaked toml for crates.io crate factorial 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate factorial 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f21767af25dd3ac67ccb95b88d7359273e0409639b6483cf9a8cba95f9d7f04e [INFO] running `Command { std: "docker" "start" "-a" "f21767af25dd3ac67ccb95b88d7359273e0409639b6483cf9a8cba95f9d7f04e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f21767af25dd3ac67ccb95b88d7359273e0409639b6483cf9a8cba95f9d7f04e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f21767af25dd3ac67ccb95b88d7359273e0409639b6483cf9a8cba95f9d7f04e", kill_on_drop: false }` [INFO] [stdout] f21767af25dd3ac67ccb95b88d7359273e0409639b6483cf9a8cba95f9d7f04e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3d8c78c00258728373ece7bd77043a5347c73860abe3d4b642c4bec499f860f [INFO] running `Command { std: "docker" "start" "-a" "d3d8c78c00258728373ece7bd77043a5347c73860abe3d4b642c4bec499f860f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking hamming v0.1.3 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking primal-bit v0.3.1 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking primal-estimate v0.3.2 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking primal-sieve v0.3.6 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking factorial v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v4.4.8 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:26 [INFO] [stdout] | [INFO] [stdout] 105 | let res = self.odd_factorial(sieve)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | res.checked_mul(&T::from_u8(2)?.shl(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:29 [INFO] [stdout] | [INFO] [stdout] 158 | let two = T::from_u8(2).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let tmp = (self.clone() / two).odd_factorial(sieve)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let tmp_sq = tmp.checked_mul(&tmp)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | tmp_sq.checked_mul(&self.prime_swing(sieve)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 168 | let two = T::from_u8(2).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let tmp = (self.clone() / two).odd_factorial_array()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let tmp_sq = tmp.checked_mul(&tmp)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | tmp_sq.checked_mul(&T::from_u128(array::SMALL_ODD_SWING[self.to_usize()?])?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 182 | let res = self.odd_factorial_array()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | res.checked_mul(&T::from_u8(2)?.shl(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorial` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d3d8c78c00258728373ece7bd77043a5347c73860abe3d4b642c4bec499f860f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3d8c78c00258728373ece7bd77043a5347c73860abe3d4b642c4bec499f860f", kill_on_drop: false }` [INFO] [stdout] d3d8c78c00258728373ece7bd77043a5347c73860abe3d4b642c4bec499f860f