[INFO] fetching crate eznet 0.2.0... [INFO] checking eznet-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eznet 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate eznet 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eznet 0.2.0 [INFO] finished tweaking crates.io crate eznet 0.2.0 [INFO] tweaked toml for crates.io crate eznet 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate eznet 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e2ceeaca2a6a6f528aa82865754ab4746fcdc46e2e0a79d96ae63171fb790df [INFO] running `Command { std: "docker" "start" "-a" "4e2ceeaca2a6a6f528aa82865754ab4746fcdc46e2e0a79d96ae63171fb790df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e2ceeaca2a6a6f528aa82865754ab4746fcdc46e2e0a79d96ae63171fb790df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e2ceeaca2a6a6f528aa82865754ab4746fcdc46e2e0a79d96ae63171fb790df", kill_on_drop: false }` [INFO] [stdout] 4e2ceeaca2a6a6f528aa82865754ab4746fcdc46e2e0a79d96ae63171fb790df [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df9215ec15caf9c322fcc85574ebb97f051d7f66a86062751c2178be9941b3a7 [INFO] running `Command { std: "docker" "start" "-a" "df9215ec15caf9c322fcc85574ebb97f051d7f66a86062751c2178be9941b3a7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling serde_derive v1.0.138 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling serde v1.0.138 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking rustls-pemfile v0.2.1 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking rustls-native-certs v0.6.1 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking pem v1.0.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking yasna v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rcgen v0.9.0 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling futures-macro v0.3.19 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking futures-executor v0.3.19 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking quinn-proto v0.8.3 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking quinn-udp v0.1.0 [INFO] [stderr] Checking quinn v0.8.3 [INFO] [stderr] Checking eznet v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 24 | let cert = rcgen::generate_simple_self_signed(vec!["localhost".into()]).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | ServerConfig::with_single_cert(cert_chain, priv_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:6:56 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 97 | let crypto = rustls::ClientConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | ClientConfig::new(Arc::new(crypto)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 129 | pub(crate) fn new(conn: NewConnection, endpoint: Endpoint) -> Self { [INFO] [stdout] | ------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let NewConnection { [INFO] [stdout] 131 | connection, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | uni_streams, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | datagrams, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let (worker_send, recv) = mpsc::channel(256); [INFO] [stdout] | ----------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let (send, worker_recv) = mpsc::channel(256); [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | let (should_stop, worker_should_stop_1) = broadcast::channel(1); [INFO] [stdout] | ----------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let worker_should_stop_2 = worker_should_stop_1.resubscribe(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let write_worker = tokio::spawn(writer_worker_job( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let read_worker = tokio::spawn(reader_worker_job( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | inner: Some(SocketInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 161 | | endpoint, [INFO] [stdout] 162 | | connection, [INFO] [stdout] ... | [INFO] [stdout] 169 | | should_stop, [INFO] [stdout] 170 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 176 | fn encode_packet(bytes: Bytes, header: PacketHeader) -> Bytes { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut packet = BytesMut::new().writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | bincode::serialize_into(&mut packet, &Packet { header, bytes }).unwrap(); [INFO] [stdout] 179 | packet.into_inner().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eznet` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/listener.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 24 | let cert = rcgen::generate_simple_self_signed(vec!["localhost".into()]).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | ServerConfig::with_single_cert(cert_chain, priv_key).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:6:56 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 97 | let crypto = rustls::ClientConfig::builder() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | ClientConfig::new(Arc::new(crypto)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:160:20 [INFO] [stdout] | [INFO] [stdout] 129 | pub(crate) fn new(conn: NewConnection, endpoint: Endpoint) -> Self { [INFO] [stdout] | ------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let NewConnection { [INFO] [stdout] 131 | connection, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | uni_streams, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | datagrams, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let (worker_send, recv) = mpsc::channel(256); [INFO] [stdout] | ----------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let (send, worker_recv) = mpsc::channel(256); [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | let (should_stop, worker_should_stop_1) = broadcast::channel(1); [INFO] [stdout] | ----------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let worker_should_stop_2 = worker_should_stop_1.resubscribe(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let write_worker = tokio::spawn(writer_worker_job( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let read_worker = tokio::spawn(reader_worker_job( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | inner: Some(SocketInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 161 | | endpoint, [INFO] [stdout] 162 | | connection, [INFO] [stdout] ... | [INFO] [stdout] 169 | | should_stop, [INFO] [stdout] 170 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 176 | fn encode_packet(bytes: Bytes, header: PacketHeader) -> Bytes { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut packet = BytesMut::new().writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | bincode::serialize_into(&mut packet, &Packet { header, bytes }).unwrap(); [INFO] [stdout] 179 | packet.into_inner().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eznet` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "df9215ec15caf9c322fcc85574ebb97f051d7f66a86062751c2178be9941b3a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df9215ec15caf9c322fcc85574ebb97f051d7f66a86062751c2178be9941b3a7", kill_on_drop: false }` [INFO] [stdout] df9215ec15caf9c322fcc85574ebb97f051d7f66a86062751c2178be9941b3a7