[INFO] fetching crate ezhttp 0.1.6... [INFO] checking ezhttp-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ezhttp 0.1.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ezhttp 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ezhttp 0.1.6 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ezhttp 0.1.6 [INFO] tweaked toml for crates.io crate ezhttp 0.1.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ezhttp 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2e179866c78592e90dfb497df7e95629f06309cbe3a69032665b9c8025d5c9e [INFO] running `Command { std: "docker" "start" "-a" "a2e179866c78592e90dfb497df7e95629f06309cbe3a69032665b9c8025d5c9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2e179866c78592e90dfb497df7e95629f06309cbe3a69032665b9c8025d5c9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2e179866c78592e90dfb497df7e95629f06309cbe3a69032665b9c8025d5c9e", kill_on_drop: false }` [INFO] [stdout] a2e179866c78592e90dfb497df7e95629f06309cbe3a69032665b9c8025d5c9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03ed65cd87ea9c7c55a535285d6aaff262c1f38021fa3fe47b8f2c034b721598 [INFO] running `Command { std: "docker" "start" "-a" "03ed65cd87ea9c7c55a535285d6aaff262c1f38021fa3fe47b8f2c034b721598", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rusty_pool v0.7.0 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking ezhttp v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/mod.rs:196:39 [INFO] [stdout] | [INFO] [stdout] 196 | Box::new(move |a, b| Box::pin(handler_connection(a, b))), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/headers.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 23 | fn from(value: Vec<(T, U)>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Headers { [INFO] [stdout] 25 | entries: value [INFO] [stdout] | ______________________^ [INFO] [stdout] 26 | | .into_iter() [INFO] [stdout] 27 | | .map(|v| (v.0.to_string(), v.1.to_string())) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/handler.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | Box::new(move |a, b| Box::pin($handler(a, b))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ezhttp/starter.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(http_server: T, host: &str) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | handler: pin_handler!(handler_connection), [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `pin_handler` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/handler.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 47 | Box::new(move |a, b| Box::pin($handler(a, b))) [INFO] [stdout] | - - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/ezhttp/starter.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | handler: pin_handler!(handler_connection), [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `pin_handler` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/starter.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn start(self) -> RunningHttpServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let running_clone = running.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | [INFO] [stdout] 139 | let thread = if self.threads == 0 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | RunningHttpServer::new(thread, running.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/starter.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn start(self) -> RunningHttpServer { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] 137 | let running_clone = running.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | / start_server_with_threadpool( [INFO] [stdout] 164 | | self.http_server, [INFO] [stdout] 165 | | &self.host, [INFO] [stdout] 166 | | self.timeout, [INFO] [stdout] ... | [INFO] [stdout] 169 | | running_clone, [INFO] [stdout] 170 | | ).await [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ezhttp` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/mod.rs:196:39 [INFO] [stdout] | [INFO] [stdout] 196 | Box::new(move |a, b| Box::pin(handler_connection(a, b))), [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/headers.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 23 | fn from(value: Vec<(T, U)>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Headers { [INFO] [stdout] 25 | entries: value [INFO] [stdout] | ______________________^ [INFO] [stdout] 26 | | .into_iter() [INFO] [stdout] 27 | | .map(|v| (v.0.to_string(), v.1.to_string())) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/handler.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | Box::new(move |a, b| Box::pin($handler(a, b))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/ezhttp/starter.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(http_server: T, host: &str) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | handler: pin_handler!(handler_connection), [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `pin_handler` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/handler.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 47 | Box::new(move |a, b| Box::pin($handler(a, b))) [INFO] [stdout] | - - ^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/ezhttp/starter.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 46 | handler: pin_handler!(handler_connection), [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `pin_handler` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/starter.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn start(self) -> RunningHttpServer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let running_clone = running.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | [INFO] [stdout] 139 | let thread = if self.threads == 0 { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | RunningHttpServer::new(thread, running.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ezhttp/starter.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn start(self) -> RunningHttpServer { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let running = Arc::new(AtomicBool::new(true)); [INFO] [stdout] 137 | let running_clone = running.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | / start_server_with_threadpool( [INFO] [stdout] 164 | | self.http_server, [INFO] [stdout] 165 | | &self.host, [INFO] [stdout] 166 | | self.timeout, [INFO] [stdout] ... | [INFO] [stdout] 169 | | running_clone, [INFO] [stdout] 170 | | ).await [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ezhttp` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "03ed65cd87ea9c7c55a535285d6aaff262c1f38021fa3fe47b8f2c034b721598", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03ed65cd87ea9c7c55a535285d6aaff262c1f38021fa3fe47b8f2c034b721598", kill_on_drop: false }` [INFO] [stdout] 03ed65cd87ea9c7c55a535285d6aaff262c1f38021fa3fe47b8f2c034b721598