[INFO] fetching crate ez-audi 0.3.0... [INFO] checking ez-audi-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ez-audi 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ez-audi 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ez-audi 0.3.0 [INFO] finished tweaking crates.io crate ez-audi 0.3.0 [INFO] tweaked toml for crates.io crate ez-audi 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ez-audi 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00f7355cd5169c98bc5b40451d7768ff8f948649643cb070996a204c98ccc373 [INFO] running `Command { std: "docker" "start" "-a" "00f7355cd5169c98bc5b40451d7768ff8f948649643cb070996a204c98ccc373", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00f7355cd5169c98bc5b40451d7768ff8f948649643cb070996a204c98ccc373", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00f7355cd5169c98bc5b40451d7768ff8f948649643cb070996a204c98ccc373", kill_on_drop: false }` [INFO] [stdout] 00f7355cd5169c98bc5b40451d7768ff8f948649643cb070996a204c98ccc373 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b73029c3cec24a7d3dc3a1223335a350d94edc8d27f0f14088eaccf66f7dcae8 [INFO] running `Command { std: "docker" "start" "-a" "b73029c3cec24a7d3dc3a1223335a350d94edc8d27f0f14088eaccf66f7dcae8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking ez-audi v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn create_stream(&self, metadata: &impl AudioMetadataTrait, samples: Arc>>) -> Error { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let data_callback = move |samples_out: &mut [T], _info: &_| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let stream_err = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let stream = match stream_err { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(stream.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|r| r.unwrap().collect::>()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:108:14 [INFO] [stdout] | [INFO] [stdout] 106 | let inner_device = cpal::default_host().default_output_device()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Some(Device::new(inner_device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 113 | let devices = Device::list_cpal_devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / devices.into_iter() [INFO] [stdout] 117 | | .map(|d| d.name()) [INFO] [stdout] 118 | | .filter(|r| r.is_ok()) [INFO] [stdout] 119 | | .map(|r| r.unwrap()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:131:14 [INFO] [stdout] | [INFO] [stdout] 125 | let devices = Device::list_cpal_devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let the_device = devices.into_iter() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Some(Device::new(the_device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:61:41 [INFO] [stdout] | [INFO] [stdout] 61 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 61 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 61 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 67 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 67 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 67 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 73 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 73 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:103:45 [INFO] [stdout] | [INFO] [stdout] 102 | fn from(value: PoisonError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Self::PoisonedMutex("".to_string(), Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ez-audi` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn create_stream(&self, metadata: &impl AudioMetadataTrait, samples: Arc>>) -> Error { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let data_callback = move |samples_out: &mut [T], _info: &_| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let stream_err = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let stream = match stream_err { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(stream.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:98:22 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|r| r.unwrap().collect::>()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:108:14 [INFO] [stdout] | [INFO] [stdout] 106 | let inner_device = cpal::default_host().default_output_device()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Some(Device::new(inner_device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 113 | let devices = Device::list_cpal_devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / devices.into_iter() [INFO] [stdout] 117 | | .map(|d| d.name()) [INFO] [stdout] 118 | | .filter(|r| r.is_ok()) [INFO] [stdout] 119 | | .map(|r| r.unwrap()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpal_abstraction/device.rs:131:14 [INFO] [stdout] | [INFO] [stdout] 125 | let devices = Device::list_cpal_devices(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | let the_device = devices.into_iter() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Some(Device::new(the_device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:61:41 [INFO] [stdout] | [INFO] [stdout] 61 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 61 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 61 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 67 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 67 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 67 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/errors.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | Some(s) => Some(&**s.clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Box` does not implement `Clone`, so calling `clone` on `&Box` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 73 - Some(s) => Some(&**s.clone()), [INFO] [stdout] 73 + Some(s) => Some(&**s), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:103:45 [INFO] [stdout] | [INFO] [stdout] 102 | fn from(value: PoisonError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Self::PoisonedMutex("".to_string(), Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ez-audi` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b73029c3cec24a7d3dc3a1223335a350d94edc8d27f0f14088eaccf66f7dcae8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b73029c3cec24a7d3dc3a1223335a350d94edc8d27f0f14088eaccf66f7dcae8", kill_on_drop: false }` [INFO] [stdout] b73029c3cec24a7d3dc3a1223335a350d94edc8d27f0f14088eaccf66f7dcae8