[INFO] fetching crate extsort-iter 0.3.1... [INFO] checking extsort-iter-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate extsort-iter 0.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate extsort-iter 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate extsort-iter 0.3.1 [INFO] finished tweaking crates.io crate extsort-iter 0.3.1 [INFO] tweaked toml for crates.io crate extsort-iter 0.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a2293793f2e2726f60a1bc01f242c5a07b9776e26d98fbfdc26892277e57864 [INFO] running `Command { std: "docker" "start" "-a" "8a2293793f2e2726f60a1bc01f242c5a07b9776e26d98fbfdc26892277e57864", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a2293793f2e2726f60a1bc01f242c5a07b9776e26d98fbfdc26892277e57864", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a2293793f2e2726f60a1bc01f242c5a07b9776e26d98fbfdc26892277e57864", kill_on_drop: false }` [INFO] [stdout] 8a2293793f2e2726f60a1bc01f242c5a07b9776e26d98fbfdc26892277e57864 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ee6d806914cdc629eef0cbca97824638913173296cb4950fa47920752a0223d [INFO] running `Command { std: "docker" "start" "-a" "3ee6d806914cdc629eef0cbca97824638913173296cb4950fa47920752a0223d", kill_on_drop: false }` [INFO] [stderr] Checking extsort-iter v0.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stdout] warning: unexpected `cfg` condition value: `docsrs` [INFO] [stdout] --> src/extension_trait/mod.rs:1:38 [INFO] [stdout] | [INFO] [stdout] 1 | #[cfg(any(feature = "parallel_sort", feature = "docsrs"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `compression`, `compression_lz4_flex`, `default`, and `parallel_sort` [INFO] [stdout] = help: consider adding `docsrs` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `docsrs` [INFO] [stdout] --> src/extension_trait/mod.rs:8:38 [INFO] [stdout] | [INFO] [stdout] 8 | #[cfg(any(feature = "parallel_sort", feature = "docsrs"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `compression`, `compression_lz4_flex`, `default`, and `parallel_sort` [INFO] [stdout] = help: consider adding `docsrs` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `docsrs` [INFO] [stdout] --> src/sorter/buffer_cleaner/mod.rs:7:38 [INFO] [stdout] | [INFO] [stdout] 7 | #[cfg(any(feature = "parallel_sort", feature = "docsrs"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `compression`, `compression_lz4_flex`, `default`, and `parallel_sort` [INFO] [stdout] = help: consider adding `docsrs` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_trait/sequential.rs:103:28 [INFO] [stdout] | [INFO] [stdout] 96 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | options: ExtsortConfig, [INFO] [stdout] 98 | comparator: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | run(self, options, FuncOrderer::new(comparator)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_trait/sequential.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 107 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | options: ExtsortConfig, [INFO] [stdout] 109 | key_extractor: F, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | run(self, options, KeyOrderer::new(key_extractor)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run/file_run.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn create_buffer_run(source: Vec) -> ExternalRun> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | source: Box::new(io::Cursor::new(&[])), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run/split_backing/mod.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(mut backing: T) -> io::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let segment_end = backing.seek(SeekFrom::End(0))?; [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | backing: Arc::new(Mutex::new(BackingWrapper::new(backing))), [INFO] [stdout] 26 | | segment_end, [INFO] [stdout] 27 | | current_index: 0, [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run/split_backing/mod.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | Ok(SplitViewWrite { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | backing: self.backing.clone(), [INFO] [stdout] 34 | | length: 0, [INFO] [stdout] 35 | | segment_start, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sorter/mod.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 125 | mut source: S, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | mut buffer_cleaner: C, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut sort_buffer = buffer_cleaner.get_buffer(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let finalize_response = buffer_cleaner.finalize()?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Ok(ResultIterator::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | finalize_response.tapes, [INFO] [stdout] 181 | | finalize_response.orderer, [INFO] [stdout] 182 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tape/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 29 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / self.plain_tapes [INFO] [stdout] 43 | | .into_iter() [INFO] [stdout] 44 | | .map(|t| t.box_backing(self.compression_choice)) [INFO] [stdout] 45 | | .chain( [INFO] [stdout] ... | [INFO] [stdout] 49 | | ) [INFO] [stdout] 50 | | .map(|t| ExternalRun::from_tape(t, read_buffer_items)) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tape/mod.rs:191:22 [INFO] [stdout] | [INFO] [stdout] 189 | fn box_backing(self, compression_choice: CompressionCodec) -> Tape> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Tape { [INFO] [stdout] 191 | backing: compression_choice.get_reader(self.backing), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `extsort-iter` (lib) due to 9 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3ee6d806914cdc629eef0cbca97824638913173296cb4950fa47920752a0223d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ee6d806914cdc629eef0cbca97824638913173296cb4950fa47920752a0223d", kill_on_drop: false }` [INFO] [stdout] 3ee6d806914cdc629eef0cbca97824638913173296cb4950fa47920752a0223d