[INFO] fetching crate extargsparse_codegen 0.1.4... [INFO] checking extargsparse_codegen-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate extargsparse_codegen 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate extargsparse_codegen 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate extargsparse_codegen 0.1.4 [INFO] finished tweaking crates.io crate extargsparse_codegen 0.1.4 [INFO] tweaked toml for crates.io crate extargsparse_codegen 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] daf6c147c2f9a043f5f70cee91306387c366973328894c4a53289c117c1fde65 [INFO] running `Command { std: "docker" "start" "-a" "daf6c147c2f9a043f5f70cee91306387c366973328894c4a53289c117c1fde65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "daf6c147c2f9a043f5f70cee91306387c366973328894c4a53289c117c1fde65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "daf6c147c2f9a043f5f70cee91306387c366973328894c4a53289c117c1fde65", kill_on_drop: false }` [INFO] [stdout] daf6c147c2f9a043f5f70cee91306387c366973328894c4a53289c117c1fde65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b591d1d0002078ba336158ef8852291f9fc17b2076513fc7b86f403b02cdd5f3 [INFO] running `Command { std: "docker" "start" "-a" "b591d1d0002078ba336158ef8852291f9fc17b2076513fc7b86f403b02cdd5f3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking extargsparse_codegen v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:449:35 [INFO] [stdout] | [INFO] [stdout] 449 | retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 449 - retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] 449 + retv.set_funcnames(&k,&v,input)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 + #[derive(Clone)] [INFO] [stdout] 253 | pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:460:33 [INFO] [stdout] | [INFO] [stdout] 460 | retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] 460 + retv.set_funcnames(&k,&v,input)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 + #[derive(Clone)] [INFO] [stdout] 253 | pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:501:2 [INFO] [stdout] | [INFO] [stdout] 491 | pub fn extargs_map_function(_args :TokenStream , input :TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | let mut code :String = "".to_string(); [INFO] [stdout] 493 | let nargs = _args.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | code.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:841:5 [INFO] [stdout] | [INFO] [stdout] 772 | pub fn argset_impl(item :TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 773 | em_log_trace!("item\n{}",item.to_string()); [INFO] [stdout] 774 | let co :syn::DeriveInput; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 841 | cc.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `extargsparse_codegen` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:449:35 [INFO] [stdout] | [INFO] [stdout] 449 | retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 449 - retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] 449 + retv.set_funcnames(&k,&v,input)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 + #[derive(Clone)] [INFO] [stdout] 253 | pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:460:33 [INFO] [stdout] | [INFO] [stdout] 460 | retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ParseBuffer<'_>` does not implement `Clone`, so calling `clone` on `&ParseBuffer<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 460 - retv.set_funcnames(&k,&v,input.clone())?; [INFO] [stdout] 460 + retv.set_funcnames(&k,&v,input)?; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ParseBuffer<'_>`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/parse.rs:252:1 [INFO] [stdout] | [INFO] [stdout] 252 + #[derive(Clone)] [INFO] [stdout] 253 | pub struct ParseBuffer<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:501:2 [INFO] [stdout] | [INFO] [stdout] 491 | pub fn extargs_map_function(_args :TokenStream , input :TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | let mut code :String = "".to_string(); [INFO] [stdout] 493 | let nargs = _args.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | code.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:841:5 [INFO] [stdout] | [INFO] [stdout] 772 | pub fn argset_impl(item :TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 773 | em_log_trace!("item\n{}",item.to_string()); [INFO] [stdout] 774 | let co :syn::DeriveInput; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 841 | cc.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `extargsparse_codegen` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b591d1d0002078ba336158ef8852291f9fc17b2076513fc7b86f403b02cdd5f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b591d1d0002078ba336158ef8852291f9fc17b2076513fc7b86f403b02cdd5f3", kill_on_drop: false }` [INFO] [stdout] b591d1d0002078ba336158ef8852291f9fc17b2076513fc7b86f403b02cdd5f3