[INFO] fetching crate exonum-proto 1.0.0... [INFO] checking exonum-proto-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate exonum-proto 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate exonum-proto 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate exonum-proto 1.0.0 [INFO] finished tweaking crates.io crate exonum-proto 1.0.0 [INFO] tweaked toml for crates.io crate exonum-proto 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding base64-serde v0.5.1 (latest: v0.7.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding darling v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding protobuf v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding protobuf-codegen v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding protobuf-convert v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding strsim v0.9.3 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 490ad0cb100cddd21d69539918b14daef9e48e51ca5f7bfaeab4141fb2cc4908 [INFO] running `Command { std: "docker" "start" "-a" "490ad0cb100cddd21d69539918b14daef9e48e51ca5f7bfaeab4141fb2cc4908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "490ad0cb100cddd21d69539918b14daef9e48e51ca5f7bfaeab4141fb2cc4908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "490ad0cb100cddd21d69539918b14daef9e48e51ca5f7bfaeab4141fb2cc4908", kill_on_drop: false }` [INFO] [stdout] 490ad0cb100cddd21d69539918b14daef9e48e51ca5f7bfaeab4141fb2cc4908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc506f71451d4c4d2e14f6214ba7919b8ff1797b421ec9cc987cca75bcdf386b [INFO] running `Command { std: "docker" "start" "-a" "bc506f71451d4c4d2e14f6214ba7919b8ff1797b421ec9cc987cca75bcdf386b", kill_on_drop: false }` [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling protoc v2.28.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking base64-serde v0.5.1 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling exonum-derive v1.0.0 [INFO] [stderr] Compiling protobuf-codegen v2.28.0 [INFO] [stderr] Compiling protoc-rust v2.28.0 [INFO] [stderr] Compiling exonum-build v1.0.1 [INFO] [stderr] Compiling protobuf-convert v0.4.0 [INFO] [stderr] Compiling exonum-proto v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/exonum-proto-2f89160322367ac4/out/bit_vec.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> /opt/rustwide/target/debug/build/exonum-proto-2f89160322367ac4/out/bit_vec.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | fn from_pb(pb: Self::ProtoStruct) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / pb.into_iter() [INFO] [stdout] 150 | | .map(ProtobufConvert::from_pb) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:35 [INFO] [stdout] | [INFO] [stdout] 189 | self.iter().map(|(k, v)| (k.clone(), v.to_pb())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 189 | self.iter().map(|(k, v)| (k.clone(), v.to_pb())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 191 | fn from_pb(mut pb: Self::ProtoStruct) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | / pb.drain() [INFO] [stdout] 193 | | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exonum-proto` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | fn from_pb(pb: Self::ProtoStruct) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / pb.into_iter() [INFO] [stdout] 150 | | .map(ProtobufConvert::from_pb) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:35 [INFO] [stdout] | [INFO] [stdout] 189 | self.iter().map(|(k, v)| (k.clone(), v.to_pb())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 189 | self.iter().map(|(k, v)| (k.clone(), v.to_pb())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 191 | fn from_pb(mut pb: Self::ProtoStruct) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | / pb.drain() [INFO] [stdout] 193 | | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:27 [INFO] [stdout] | [INFO] [stdout] 193 | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | .map(|(k, v)| ProtobufConvert::from_pb(v).map(|v| (k, v))) [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exonum-proto` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "bc506f71451d4c4d2e14f6214ba7919b8ff1797b421ec9cc987cca75bcdf386b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc506f71451d4c4d2e14f6214ba7919b8ff1797b421ec9cc987cca75bcdf386b", kill_on_drop: false }` [INFO] [stdout] bc506f71451d4c4d2e14f6214ba7919b8ff1797b421ec9cc987cca75bcdf386b