[INFO] fetching crate exchange-rate 0.1.3... [INFO] checking exchange-rate-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate exchange-rate 0.1.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate exchange-rate 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate exchange-rate 0.1.3 [INFO] finished tweaking crates.io crate exchange-rate 0.1.3 [INFO] tweaked toml for crates.io crate exchange-rate 0.1.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7cdc3c661726ecc05e2dbed9765ac66e47217e86c71531e1504b8d33968f480c [INFO] running `Command { std: "docker" "start" "-a" "7cdc3c661726ecc05e2dbed9765ac66e47217e86c71531e1504b8d33968f480c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7cdc3c661726ecc05e2dbed9765ac66e47217e86c71531e1504b8d33968f480c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cdc3c661726ecc05e2dbed9765ac66e47217e86c71531e1504b8d33968f480c", kill_on_drop: false }` [INFO] [stdout] 7cdc3c661726ecc05e2dbed9765ac66e47217e86c71531e1504b8d33968f480c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80ab1f2083fa93ba7e29594c260fe7275467003e72ac232891e8b50841d02ba4 [INFO] running `Command { std: "docker" "start" "-a" "80ab1f2083fa93ba7e29594c260fe7275467003e72ac232891e8b50841d02ba4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking safe-graph v0.1.6 [INFO] [stderr] Checking floyd-warshall-alg v0.1.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking exchange-rate v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn node_to_index(&mut self, s: N) -> I { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | match self.node_to_index.entry(s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request/exchange_rate_request.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 146 | let source_exchange = values[&SourceExchange].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let source_currency = values[&SourceCurrency].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let destination_exchange = values[&DestinationExchange].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let destination_currency = values[&DestinationCurrency].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Ok(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | source_exchange.unwrap(), [INFO] [stdout] 185 | | source_currency.unwrap(), [INFO] [stdout] 186 | | destination_exchange.unwrap(), [INFO] [stdout] 187 | | destination_currency.unwrap(), [INFO] [stdout] 188 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request/price_update.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 163 | let forward_factor = values[&ForwardFactor].parse::(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let backward_factor = values[&BackwardFactor].parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let exchange = values[&Exchange].to_uppercase().parse::(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let source_currency = values[&SourceCurrency].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let destination_currency = values[&DestinationCurrency].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | timestamp.unwrap(), [INFO] [stdout] 211 | | exchange.unwrap(), [INFO] [stdout] 212 | | source_currency.unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 215 | | backward_factor.unwrap(), [INFO] [stdout] 216 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exchange-rate` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 138 | fn node_to_index(&mut self, s: N) -> I { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | match self.node_to_index.entry(s.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request/exchange_rate_request.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 146 | let source_exchange = values[&SourceExchange].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let source_currency = values[&SourceCurrency].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let destination_exchange = values[&DestinationExchange].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let destination_currency = values[&DestinationCurrency].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Ok(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | source_exchange.unwrap(), [INFO] [stdout] 185 | | source_currency.unwrap(), [INFO] [stdout] 186 | | destination_exchange.unwrap(), [INFO] [stdout] 187 | | destination_currency.unwrap(), [INFO] [stdout] 188 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request/price_update.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 163 | let forward_factor = values[&ForwardFactor].parse::(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let backward_factor = values[&BackwardFactor].parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let exchange = values[&Exchange].to_uppercase().parse::(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let source_currency = values[&SourceCurrency].to_uppercase().parse::(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let destination_currency = values[&DestinationCurrency].to_uppercase().parse::(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(Self::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | timestamp.unwrap(), [INFO] [stdout] 211 | | exchange.unwrap(), [INFO] [stdout] 212 | | source_currency.unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 215 | | backward_factor.unwrap(), [INFO] [stdout] 216 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exchange-rate` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "80ab1f2083fa93ba7e29594c260fe7275467003e72ac232891e8b50841d02ba4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80ab1f2083fa93ba7e29594c260fe7275467003e72ac232891e8b50841d02ba4", kill_on_drop: false }` [INFO] [stdout] 80ab1f2083fa93ba7e29594c260fe7275467003e72ac232891e8b50841d02ba4