[INFO] fetching crate excavator 0.4.0... [INFO] checking excavator-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate excavator 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate excavator 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate excavator 0.4.0 [INFO] finished tweaking crates.io crate excavator 0.4.0 [INFO] tweaked toml for crates.io crate excavator 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate excavator 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abba72833e559e63048f1aa82959bef9cd06a21b1affec4614ee94240216f7cf [INFO] running `Command { std: "docker" "start" "-a" "abba72833e559e63048f1aa82959bef9cd06a21b1affec4614ee94240216f7cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abba72833e559e63048f1aa82959bef9cd06a21b1affec4614ee94240216f7cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abba72833e559e63048f1aa82959bef9cd06a21b1affec4614ee94240216f7cf", kill_on_drop: false }` [INFO] [stdout] abba72833e559e63048f1aa82959bef9cd06a21b1affec4614ee94240216f7cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0173169caca4b8c9fbee50f3791e55d9b176ef3e1f6d09d808992c8803827951 [INFO] running `Command { std: "docker" "start" "-a" "0173169caca4b8c9fbee50f3791e55d9b176ef3e1f6d09d808992c8803827951", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking rusqlite v0.24.2 [INFO] [stderr] Checking excavator v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities/facebook.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use facebook_last_location::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the name `Coordinate` in the type namespace is first re-exported here [INFO] [stdout] 9 | pub use facebook_location_history::*; [INFO] [stdout] | ---------------------------- but the name `Coordinate` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities/facebook.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use facebook_last_location::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the name `Coordinate` in the type namespace is first re-exported here [INFO] [stdout] 9 | pub use facebook_location_history::*; [INFO] [stdout] | ---------------------------- but the name `Coordinate` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use facebook::*; [INFO] [stdout] | ^^^^^^^^^^^ the name `Coordinate` in the type namespace is first re-exported here [INFO] [stdout] 5 | pub use google::*; [INFO] [stdout] | --------- but the name `Coordinate` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use facebook::*; [INFO] [stdout] | ^^^^^^^^^^^ the name `LocationHistory` in the type namespace is first re-exported here [INFO] [stdout] 5 | pub use google::*; [INFO] [stdout] | --------- but the name `LocationHistory` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use facebook::*; [INFO] [stdout] | ^^^^^^^^^^^ the name `Coordinate` in the type namespace is first re-exported here [INFO] [stdout] 5 | pub use google::*; [INFO] [stdout] | --------- but the name `Coordinate` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/activities.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use facebook::*; [INFO] [stdout] | ^^^^^^^^^^^ the name `LocationHistory` in the type namespace is first re-exported here [INFO] [stdout] 5 | pub use google::*; [INFO] [stdout] | --------- but the name `LocationHistory` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | / conn.execute( [INFO] [stdout] 69 | | "INSERT INTO activity_sub_title [INFO] [stdout] 70 | | (a_uuid, name, url) values (?1, ?2, ?3)", [INFO] [stdout] 71 | | params![ [INFO] [stdout] ... | [INFO] [stdout] 75 | | ] [INFO] [stdout] 76 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | / conn.execute( [INFO] [stdout] 83 | | "INSERT INTO activity_location_info [INFO] [stdout] 84 | | (a_uuid, name, url, source) [INFO] [stdout] 85 | | VALUES (?1, ?2, ?3, ?4)", [INFO] [stdout] ... | [INFO] [stdout] 91 | | ] [INFO] [stdout] 92 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | / conn.execute( [INFO] [stdout] 99 | | "INSERT INTO activity_details (a_uuid, name) [INFO] [stdout] 100 | | VALUES (?1, ?2)", [INFO] [stdout] 101 | | params![ [INFO] [stdout] 102 | | &my_uuid.to_string(), &detail.name.to_string() [INFO] [stdout] 103 | | ] [INFO] [stdout] 104 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / conn.execute( [INFO] [stdout] 110 | | "INSERT INTO activity_products (a_uuid,name) [INFO] [stdout] 111 | | VALUES (?1, ?2)", [INFO] [stdout] 112 | | params![ [INFO] [stdout] 113 | | &my_uuid.to_string(), &product.to_string() [INFO] [stdout] 114 | | ] [INFO] [stdout] 115 | | ).ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | / conn.execute( [INFO] [stdout] 69 | | "INSERT INTO activity_sub_title [INFO] [stdout] 70 | | (a_uuid, name, url) values (?1, ?2, ?3)", [INFO] [stdout] 71 | | params![ [INFO] [stdout] ... | [INFO] [stdout] 75 | | ] [INFO] [stdout] 76 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | / conn.execute( [INFO] [stdout] 83 | | "INSERT INTO activity_location_info [INFO] [stdout] 84 | | (a_uuid, name, url, source) [INFO] [stdout] 85 | | VALUES (?1, ?2, ?3, ?4)", [INFO] [stdout] ... | [INFO] [stdout] 91 | | ] [INFO] [stdout] 92 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | / conn.execute( [INFO] [stdout] 99 | | "INSERT INTO activity_details (a_uuid, name) [INFO] [stdout] 100 | | VALUES (?1, ?2)", [INFO] [stdout] 101 | | params![ [INFO] [stdout] 102 | | &my_uuid.to_string(), &detail.name.to_string() [INFO] [stdout] 103 | | ] [INFO] [stdout] 104 | | ).ok() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activities/google/my_activity.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | / conn.execute( [INFO] [stdout] 110 | | "INSERT INTO activity_products (a_uuid,name) [INFO] [stdout] 111 | | VALUES (?1, ?2)", [INFO] [stdout] 112 | | params![ [INFO] [stdout] 113 | | &my_uuid.to_string(), &product.to_string() [INFO] [stdout] 114 | | ] [INFO] [stdout] 115 | | ).ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `excavator` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `excavator` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0173169caca4b8c9fbee50f3791e55d9b176ef3e1f6d09d808992c8803827951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0173169caca4b8c9fbee50f3791e55d9b176ef3e1f6d09d808992c8803827951", kill_on_drop: false }` [INFO] [stdout] 0173169caca4b8c9fbee50f3791e55d9b176ef3e1f6d09d808992c8803827951