[INFO] fetching crate exc-symbol 0.7.3... [INFO] checking exc-symbol-0.7.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate exc-symbol 0.7.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate exc-symbol 0.7.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate exc-symbol 0.7.3 [INFO] finished tweaking crates.io crate exc-symbol 0.7.3 [INFO] tweaked toml for crates.io crate exc-symbol 0.7.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding smol_str v0.1.24 (latest: v0.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70573072c7d85ba2f073f3ecd1cc318c754a37c7b862b8752d6b11ec7dadef9d [INFO] running `Command { std: "docker" "start" "-a" "70573072c7d85ba2f073f3ecd1cc318c754a37c7b862b8752d6b11ec7dadef9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70573072c7d85ba2f073f3ecd1cc318c754a37c7b862b8752d6b11ec7dadef9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70573072c7d85ba2f073f3ecd1cc318c754a37c7b862b8752d6b11ec7dadef9d", kill_on_drop: false }` [INFO] [stdout] 70573072c7d85ba2f073f3ecd1cc318c754a37c7b862b8752d6b11ec7dadef9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edf485ebafceb45840aae6f442067da8443d1e8f157ce7f5b932718286240308 [INFO] running `Command { std: "docker" "start" "-a" "edf485ebafceb45840aae6f442067da8443d1e8f157ce7f5b932718286240308", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling rust_decimal_macros v1.36.0 [INFO] [stderr] Checking smol_str v0.1.24 [INFO] [stderr] Checking positions v0.2.1 [INFO] [stderr] Checking exc-symbol v0.7.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 87 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let date = date.format(&format).ok()?; [INFO] [stdout] 89 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 90 | | Symbol::derivative( [INFO] [stdout] 91 | | &format!("{}{date}", Self::FUTURES), [INFO] [stdout] 92 | | &format!("{base}-{quote}"), [INFO] [stdout] 93 | | ) [INFO] [stdout] 94 | | .expect("must be valid"), [INFO] [stdout] 95 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 114 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let date = date.format(&format).ok()?; [INFO] [stdout] 116 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 117 | | Symbol::derivative( [INFO] [stdout] 118 | | &format!("{}{date}{}{price}", Self::OPTIONS, Self::PUT), [INFO] [stdout] 119 | | &format!("{base}-{quote}"), [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | .expect("must be valid"), [INFO] [stdout] 122 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 128 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let date = date.format(&format).ok()?; [INFO] [stdout] 130 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | Symbol::derivative( [INFO] [stdout] 132 | | &format!("{}{date}{}{price}", Self::OPTIONS, Self::CALL), [INFO] [stdout] 133 | | &format!("{base}-{quote}",), [INFO] [stdout] 134 | | ) [INFO] [stdout] 135 | | .expect("must be valid"), [INFO] [stdout] 136 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 249 | let (base, quote, _) = self.to_parts(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Instrument::try_with_symbol(self.0.clone(), &base, "e).expect("must be valid") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | let symbol = Symbol::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | Self::from_symbol(&symbol).ok_or(ParseExcSymbolError::InvalidFormat) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exc-symbol` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 87 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let date = date.format(&format).ok()?; [INFO] [stdout] 89 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 90 | | Symbol::derivative( [INFO] [stdout] 91 | | &format!("{}{date}", Self::FUTURES), [INFO] [stdout] 92 | | &format!("{base}-{quote}"), [INFO] [stdout] 93 | | ) [INFO] [stdout] 94 | | .expect("must be valid"), [INFO] [stdout] 95 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 114 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let date = date.format(&format).ok()?; [INFO] [stdout] 116 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 117 | | Symbol::derivative( [INFO] [stdout] 118 | | &format!("{}{date}{}{price}", Self::OPTIONS, Self::PUT), [INFO] [stdout] 119 | | &format!("{base}-{quote}"), [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | .expect("must be valid"), [INFO] [stdout] 122 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 128 | let format = Self::formatting_date_format(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let date = date.format(&format).ok()?; [INFO] [stdout] 130 | Some(Self( [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | Symbol::derivative( [INFO] [stdout] 132 | | &format!("{}{date}{}{price}", Self::OPTIONS, Self::CALL), [INFO] [stdout] 133 | | &format!("{base}-{quote}",), [INFO] [stdout] 134 | | ) [INFO] [stdout] 135 | | .expect("must be valid"), [INFO] [stdout] 136 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 249 | let (base, quote, _) = self.to_parts(); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Instrument::try_with_symbol(self.0.clone(), &base, "e).expect("must be valid") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | let symbol = Symbol::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | Self::from_symbol(&symbol).ok_or(ParseExcSymbolError::InvalidFormat) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exc-symbol` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "edf485ebafceb45840aae6f442067da8443d1e8f157ce7f5b932718286240308", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edf485ebafceb45840aae6f442067da8443d1e8f157ce7f5b932718286240308", kill_on_drop: false }` [INFO] [stdout] edf485ebafceb45840aae6f442067da8443d1e8f157ce7f5b932718286240308