[INFO] fetching crate eventsourced-postgres 0.14.1... [INFO] checking eventsourced-postgres-0.14.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eventsourced-postgres 0.14.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate eventsourced-postgres 0.14.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eventsourced-postgres 0.14.1 [INFO] finished tweaking crates.io crate eventsourced-postgres 0.14.1 [INFO] tweaked toml for crates.io crate eventsourced-postgres 0.14.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 139 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bollard-stubs v1.42.0-rc.3 (latest: v1.42.0-rc.8) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding serde_with v1.14.0 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v1.5.2 (latest: v3.9.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding testcontainers v0.15.0 (latest: v0.22.0) [INFO] [stderr] Adding testcontainers-modules v0.3.7 (latest: v0.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00f51d81f2645303fde67d758ad037aa2bb3ac676a79323ba6d27d36fc23e0ed [INFO] running `Command { std: "docker" "start" "-a" "00f51d81f2645303fde67d758ad037aa2bb3ac676a79323ba6d27d36fc23e0ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00f51d81f2645303fde67d758ad037aa2bb3ac676a79323ba6d27d36fc23e0ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00f51d81f2645303fde67d758ad037aa2bb3ac676a79323ba6d27d36fc23e0ed", kill_on_drop: false }` [INFO] [stdout] 00f51d81f2645303fde67d758ad037aa2bb3ac676a79323ba6d27d36fc23e0ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7937e0be2940f255eace865ddd4e129bcdb43aada0b07be666da921b96c9ff74 [INFO] running `Command { std: "docker" "start" "-a" "7937e0be2940f255eace865ddd4e129bcdb43aada0b07be666da921b96c9ff74", kill_on_drop: false }` [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking error-ext v0.2.2 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking postgres-types v0.2.7 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking bb8 v0.8.5 [INFO] [stderr] Checking eventsourced v0.27.0 [INFO] [stderr] Checking tokio-postgres v0.7.11 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking bb8-postgres v0.8.1 [INFO] [stderr] Checking eventsourced-postgres v0.14.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 96 | row.and_then(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let bytes = Bytes::copy_from_slice(bytes); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | / from_bytes(bytes) [INFO] [stdout] 103 | | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:103:60 [INFO] [stdout] | [INFO] [stdout] 103 | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 136 | row.and_then(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let bytes = Bytes::copy_from_slice(bytes); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / from_bytes(bytes) [INFO] [stdout] 143 | | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:143:60 [INFO] [stdout] | [INFO] [stdout] 143 | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 160 | .and_then(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | // If there is no seq_no there is one row with a NULL column, hence use `try_get`. [INFO] [stdout] 162 | / row.try_get::<_, i64>(0) [INFO] [stdout] 163 | | .ok() [INFO] [stdout] 164 | | .map(|seq_no| { [INFO] [stdout] 165 | | (seq_no as u64) [INFO] [stdout] 166 | | .try_into() [INFO] [stdout] 167 | | .map_err(|_| Error::ZeroNonZeroU64) [INFO] [stdout] 168 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:207:68 [INFO] [stdout] | [INFO] [stdout] 207 | let bytes = to_bytes(event).map_err(|error| Error::ToBytes(Box::new(error)))?; [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event_log.rs:237:17 [INFO] [stdout] | [INFO] [stdout] 235 | .and_then(|row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | // If there is no seq_no there is one row with a NULL column, hence use `try_get`. [INFO] [stdout] 237 | / row.try_get::<_, i64>(0) [INFO] [stdout] 238 | | .ok() [INFO] [stdout] 239 | | .map(|seq_no| { [INFO] [stdout] 240 | | (seq_no as u64) [INFO] [stdout] 241 | | .try_into() [INFO] [stdout] 242 | | .map_err(|_| Error::ZeroNonZeroU64) [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot_store.rs:94:69 [INFO] [stdout] | [INFO] [stdout] 94 | let bytes = to_bytes(state).map_err(|source| Error::ToBytes(Box::new(source)))?; [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot_store.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 109 | from_bytes: FromBytes, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | .map(move |row| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let bytes = Bytes::copy_from_slice(bytes); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | / from_bytes(bytes) [INFO] [stdout] 134 | | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot_store.rs:134:56 [INFO] [stdout] | [INFO] [stdout] 134 | .map_err(|source| Error::FromBytes(Box::new(source))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eventsourced-postgres` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7937e0be2940f255eace865ddd4e129bcdb43aada0b07be666da921b96c9ff74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7937e0be2940f255eace865ddd4e129bcdb43aada0b07be666da921b96c9ff74", kill_on_drop: false }` [INFO] [stdout] 7937e0be2940f255eace865ddd4e129bcdb43aada0b07be666da921b96c9ff74