[INFO] fetching crate evegfx-macros 0.3.0... [INFO] checking evegfx-macros-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate evegfx-macros 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate evegfx-macros 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate evegfx-macros 0.3.0 [INFO] finished tweaking crates.io crate evegfx-macros 0.3.0 [INFO] tweaked toml for crates.io crate evegfx-macros 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitvec v0.19.6 (latest: v1.0.1) [INFO] [stderr] Adding funty v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding memchr v2.3.4 (latest: v2.7.4) [INFO] [stderr] Adding nom v6.2.2 (latest: v7.1.3) [INFO] [stderr] Adding radium v0.5.3 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wyz v0.2.0 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a37c4d1b0aececb3631699b72f052fad90328cc4a3abb74d05923fb263b533b6 [INFO] running `Command { std: "docker" "start" "-a" "a37c4d1b0aececb3631699b72f052fad90328cc4a3abb74d05923fb263b533b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a37c4d1b0aececb3631699b72f052fad90328cc4a3abb74d05923fb263b533b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a37c4d1b0aececb3631699b72f052fad90328cc4a3abb74d05923fb263b533b6", kill_on_drop: false }` [INFO] [stdout] a37c4d1b0aececb3631699b72f052fad90328cc4a3abb74d05923fb263b533b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e66aba104d5f246cde2f2cb34f31b38a75cdce45b43bb71b35520de3d2851d9c [INFO] running `Command { std: "docker" "start" "-a" "e66aba104d5f246cde2f2cb34f31b38a75cdce45b43bb71b35520de3d2851d9c", kill_on_drop: false }` [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling nom v6.2.2 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking evegfx-macros v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn eve_format(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let call = parse_macro_input!(input as EVEFormat); [INFO] [stdout] | ---- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let fmt = call.fmt; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let args = call.args; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut arg_elems: Punctuated = Punctuated::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let int_variant_path: ExprPath = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | syn::parse_str("::evegfx::commands::strfmt::Argument::Int").unwrap(); [INFO] [stdout] 28 | let uint_variant_path: ExprPath = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | syn::parse_str("::evegfx::commands::strfmt::Argument::UInt").unwrap(); [INFO] [stdout] 30 | let char_variant_path: ExprPath = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | syn::parse_str("::evegfx::commands::strfmt::Argument::Char").unwrap(); [INFO] [stdout] 32 | let string_variant_path: ExprPath = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let mut args: Punctuated = Punctuated::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / if needs_fmt { [INFO] [stdout] 146 | | quote!( [INFO] [stdout] 147 | | ::evegfx::commands::strfmt::Message::new(#args) [INFO] [stdout] 148 | | ) [INFO] [stdout] ... | [INFO] [stdout] 152 | | ) [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | let mut remain = fmt_src.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 157 | fn enum_variant_expr(path: ExprPath, val: Expr) -> syn::Expr { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut args: Punctuated = Punctuated::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | args.push(val); [INFO] [stdout] 160 | syn::Expr::Call(syn::ExprCall { [INFO] [stdout] | _____________________^ [INFO] [stdout] 161 | | attrs: Vec::new(), [INFO] [stdout] 162 | | func: Box::new(Expr::Path(path)), [INFO] [stdout] 163 | | args: args, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:26 [INFO] [stdout] | [INFO] [stdout] 177 | fn array_slice_expr(elems: Punctuated) -> syn::Expr { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | syn::Expr::Reference(syn::ExprReference { [INFO] [stdout] | __________________________^ [INFO] [stdout] 179 | | attrs: Vec::new(), [INFO] [stdout] 180 | | and_token: syn::token::And { [INFO] [stdout] 181 | | spans: [Span::call_site()], [INFO] [stdout] ... | [INFO] [stdout] 191 | | raw: std::default::Default::default(), [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 202 | let fmt: LitStr = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let args: Punctuated = if let Ok(_) = input.parse::() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(EVEFormat { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | fmt: fmt, [INFO] [stdout] 211 | | args: args, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `evegfx-macros` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn eve_format(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let call = parse_macro_input!(input as EVEFormat); [INFO] [stdout] | ---- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let fmt = call.fmt; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let args = call.args; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut arg_elems: Punctuated = Punctuated::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let int_variant_path: ExprPath = [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | syn::parse_str("::evegfx::commands::strfmt::Argument::Int").unwrap(); [INFO] [stdout] 28 | let uint_variant_path: ExprPath = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | syn::parse_str("::evegfx::commands::strfmt::Argument::UInt").unwrap(); [INFO] [stdout] 30 | let char_variant_path: ExprPath = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | syn::parse_str("::evegfx::commands::strfmt::Argument::Char").unwrap(); [INFO] [stdout] 32 | let string_variant_path: ExprPath = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let mut args: Punctuated = Punctuated::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / if needs_fmt { [INFO] [stdout] 146 | | quote!( [INFO] [stdout] 147 | | ::evegfx::commands::strfmt::Message::new(#args) [INFO] [stdout] 148 | | ) [INFO] [stdout] ... | [INFO] [stdout] 152 | | ) [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:35:29 [INFO] [stdout] | [INFO] [stdout] 35 | let mut remain = fmt_src.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:160:21 [INFO] [stdout] | [INFO] [stdout] 157 | fn enum_variant_expr(path: ExprPath, val: Expr) -> syn::Expr { [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut args: Punctuated = Punctuated::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | args.push(val); [INFO] [stdout] 160 | syn::Expr::Call(syn::ExprCall { [INFO] [stdout] | _____________________^ [INFO] [stdout] 161 | | attrs: Vec::new(), [INFO] [stdout] 162 | | func: Box::new(Expr::Path(path)), [INFO] [stdout] 163 | | args: args, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }, [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:178:26 [INFO] [stdout] | [INFO] [stdout] 177 | fn array_slice_expr(elems: Punctuated) -> syn::Expr { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | syn::Expr::Reference(syn::ExprReference { [INFO] [stdout] | __________________________^ [INFO] [stdout] 179 | | attrs: Vec::new(), [INFO] [stdout] 180 | | and_token: syn::token::And { [INFO] [stdout] 181 | | spans: [Span::call_site()], [INFO] [stdout] ... | [INFO] [stdout] 191 | | raw: std::default::Default::default(), [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 202 | let fmt: LitStr = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let args: Punctuated = if let Ok(_) = input.parse::() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(EVEFormat { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | fmt: fmt, [INFO] [stdout] 211 | | args: args, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `evegfx-macros` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e66aba104d5f246cde2f2cb34f31b38a75cdce45b43bb71b35520de3d2851d9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e66aba104d5f246cde2f2cb34f31b38a75cdce45b43bb71b35520de3d2851d9c", kill_on_drop: false }` [INFO] [stdout] e66aba104d5f246cde2f2cb34f31b38a75cdce45b43bb71b35520de3d2851d9c