[INFO] fetching crate eugene 0.6.2... [INFO] checking eugene-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eugene 0.6.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate eugene 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eugene 0.6.2 [INFO] finished tweaking crates.io crate eugene 0.6.2 [INFO] tweaked toml for crates.io crate eugene 0.6.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate eugene 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d55ed35839413f1e7d46613e04dcbe0604362ba3fd6dc804efe1b92c76c94fd7 [INFO] running `Command { std: "docker" "start" "-a" "d55ed35839413f1e7d46613e04dcbe0604362ba3fd6dc804efe1b92c76c94fd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d55ed35839413f1e7d46613e04dcbe0604362ba3fd6dc804efe1b92c76c94fd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d55ed35839413f1e7d46613e04dcbe0604362ba3fd6dc804efe1b92c76c94fd7", kill_on_drop: false }` [INFO] [stdout] d55ed35839413f1e7d46613e04dcbe0604362ba3fd6dc804efe1b92c76c94fd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] afdfb9517fa6103684f3b06ddff6db02ac894d0668beeef8532cef7a0b029a07 [INFO] running `Command { std: "docker" "start" "-a" "afdfb9517fa6103684f3b06ddff6db02ac894d0668beeef8532cef7a0b029a07", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Compiling eugene v0.6.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.2 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking postgres v0.19.7 [INFO] [stderr] Compiling pg_query v5.1.0 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 139 | f: impl FnOnce(&mut Transaction) -> Result, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Result { [INFO] [stdout] 141 | self.with_client(|client| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 142 | | let mut tx = client.transaction()?; [INFO] [stdout] 143 | | let result = f(&mut tx)?; [INFO] [stdout] 144 | | if commit { [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok(result) [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 80 | let current_locks = query_pg_locks_in_current_transaction(tx)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(current_locks [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | .into_iter() [INFO] [stdout] 83 | | .filter(|lock| relevant_objects.contains(&lock.target_oid())) [INFO] [stdout] 84 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 120 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / rows.into_iter() [INFO] [stdout] 124 | | .map(|row| { [INFO] [stdout] 125 | | let table_oid: Oid = row.try_get(0)?; [INFO] [stdout] 126 | | let attnum: i16 = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok((identifier, metadata)) [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 176 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | / rows.into_iter() [INFO] [stdout] 181 | | .map(|row| { [INFO] [stdout] 182 | | let schema_name: String = row.try_get(0)?; [INFO] [stdout] 183 | | let table_name: String = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 202 | | Ok((con_oid, constraint)) [INFO] [stdout] 203 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 222 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | / rows.into_iter() [INFO] [stdout] 227 | | .map(|row| { [INFO] [stdout] 228 | | let schema: String = row.try_get(0)?; [INFO] [stdout] 229 | | let object_name: String = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 234 | | .ok_or_else(|| InvalidLockError::InvalidRelKind(rel_kind).into()) [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 249 | let rows = tx.query(query, &[&tracked_objects])?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | / rows.into_iter() [INFO] [stdout] 251 | | .map(|row| { [INFO] [stdout] 252 | | let oid: Oid = row.try_get(0)?; [INFO] [stdout] 253 | | let relfilenode: u32 = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 269 | | )) [INFO] [stdout] 270 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/tracer.rs:267:24 [INFO] [stdout] | [INFO] [stdout] 257 | trace_targets: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | all_locks: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/tracer.rs:272:30 [INFO] [stdout] | [INFO] [stdout] 257 | trace_targets: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | created_objects: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:210:24 [INFO] [stdout] | [INFO] [stdout] 210 | .ok_or_else(|| NotFound.with_context(format!("{path:?}")))? [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:212:24 [INFO] [stdout] | [INFO] [stdout] 212 | .ok_or_else(|| NotValidUtf8.with_context(format!("{path:?}")))?; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:215:22 [INFO] [stdout] | [INFO] [stdout] 215 | .map_err(|e| PathParseError.with_context(format!("{path:?} {e:?}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comments.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | Lazy::new(|| Regex::new(r"-- eugene: ([^\n]+)").expect("Failed to compile regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_scripts.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 66 | let each = delimited( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | many_till(each, eof)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_scripts.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | .map_err(|e| InnerError::ScriptParsingError(format!("{e:?}")).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 26 | let dbpath = Builder::new().prefix("eugene-temp-postgres").tempdir()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let mut pwfile = tempfile::NamedTempFile::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut initdb = Command::new("initdb"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut pg = Command::new("pg_ctl"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut child = pg.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let stdout = child [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let reader = spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let logger = spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(TempServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | dbpath: Some(dbpath), [INFO] [stdout] 111 | | child, [INFO] [stdout] 112 | | reader: Some(reader), [INFO] [stdout] ... | [INFO] [stdout] 120 | | ), [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:76:28 [INFO] [stdout] | [INFO] [stdout] 76 | .ok_or_else(|| InnerError::MissingStdout.with_context("Unable to take stdout"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 131 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | InnerError::MissingRequiredCommand(command.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | fn from(e: E) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: e.into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 50 | fn with_context>(self, ctx: S) -> Error { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | inner: self.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.map_err(|e| e.into().with_context(ctx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.map_err(|e| e.into().with_context(ctx)) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.map_err(|e| e.with_context(ctx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 27 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | InnerError::NoGitExecutableError [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | fn git_ref_exists>(gitref: &str, cwd: P) -> crate::Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / Command::new("git") [INFO] [stdout] 36 | | .arg("rev-parse") [INFO] [stdout] 37 | | .arg("--verify") [INFO] [stdout] 38 | | .arg(gitref) [INFO] [stdout] ... | [INFO] [stdout] 44 | | )) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | InnerError::GitError.with_context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | fn git_status>(cwd: P) -> crate::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let cwd = cwd.as_ref(); [INFO] [stdout] 76 | / Command::new("git") [INFO] [stdout] 77 | | .arg("status") [INFO] [stdout] 78 | | .arg("--porcelain") [INFO] [stdout] 79 | | .current_dir(cwd) [INFO] [stdout] ... | [INFO] [stdout] 84 | | )) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 81 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | InnerError::GitError.with_context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eugene` (lib) due to 28 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 139 | f: impl FnOnce(&mut Transaction) -> Result, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> Result { [INFO] [stdout] 141 | self.with_client(|client| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 142 | | let mut tx = client.transaction()?; [INFO] [stdout] 143 | | let result = f(&mut tx)?; [INFO] [stdout] 144 | | if commit { [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok(result) [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 80 | let current_locks = query_pg_locks_in_current_transaction(tx)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(current_locks [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | .into_iter() [INFO] [stdout] 83 | | .filter(|lock| relevant_objects.contains(&lock.target_oid())) [INFO] [stdout] 84 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 120 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / rows.into_iter() [INFO] [stdout] 124 | | .map(|row| { [INFO] [stdout] 125 | | let table_oid: Oid = row.try_get(0)?; [INFO] [stdout] 126 | | let attnum: i16 = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 150 | | Ok((identifier, metadata)) [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 176 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | / rows.into_iter() [INFO] [stdout] 181 | | .map(|row| { [INFO] [stdout] 182 | | let schema_name: String = row.try_get(0)?; [INFO] [stdout] 183 | | let table_name: String = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 202 | | Ok((con_oid, constraint)) [INFO] [stdout] 203 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 222 | let rows = tx [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | / rows.into_iter() [INFO] [stdout] 227 | | .map(|row| { [INFO] [stdout] 228 | | let schema: String = row.try_get(0)?; [INFO] [stdout] 229 | | let object_name: String = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 234 | | .ok_or_else(|| InvalidLockError::InvalidRelKind(rel_kind).into()) [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/queries.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 249 | let rows = tx.query(query, &[&tracked_objects])?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | / rows.into_iter() [INFO] [stdout] 251 | | .map(|row| { [INFO] [stdout] 252 | | let oid: Oid = row.try_get(0)?; [INFO] [stdout] 253 | | let relfilenode: u32 = row.try_get(1)?; [INFO] [stdout] ... | [INFO] [stdout] 269 | | )) [INFO] [stdout] 270 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/tracer.rs:267:24 [INFO] [stdout] | [INFO] [stdout] 257 | trace_targets: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | all_locks: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracing/tracer.rs:272:30 [INFO] [stdout] | [INFO] [stdout] 257 | trace_targets: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | created_objects: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:210:24 [INFO] [stdout] | [INFO] [stdout] 210 | .ok_or_else(|| NotFound.with_context(format!("{path:?}")))? [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:212:24 [INFO] [stdout] | [INFO] [stdout] 212 | .ok_or_else(|| NotValidUtf8.with_context(format!("{path:?}")))?; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/script_discovery.rs:215:22 [INFO] [stdout] | [INFO] [stdout] 215 | .map_err(|e| PathParseError.with_context(format!("{path:?} {e:?}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comments.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | Lazy::new(|| Regex::new(r"-- eugene: ([^\n]+)").expect("Failed to compile regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_doc_snapshots.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | .ok_or_else(|| InnerError::NotFound.with_context("No file name"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_doc_snapshots.rs:224:21 [INFO] [stdout] | [INFO] [stdout] 224 | .map(|hint| write_traces(hint.id).map(|changed| (hint.id.to_string(), changed))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_scripts.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 66 | let each = delimited( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | many_till(each, eof)(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_scripts.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | .map_err(|e| InnerError::ScriptParsingError(format!("{e:?}")).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 26 | let dbpath = Builder::new().prefix("eugene-temp-postgres").tempdir()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let mut pwfile = tempfile::NamedTempFile::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut initdb = Command::new("initdb"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let mut pg = Command::new("pg_ctl"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let mut child = pg.spawn()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let stdout = child [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let reader = spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let logger = spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(TempServer { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | dbpath: Some(dbpath), [INFO] [stdout] 111 | | child, [INFO] [stdout] 112 | | reader: Some(reader), [INFO] [stdout] ... | [INFO] [stdout] 120 | | ), [INFO] [stdout] 121 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:76:28 [INFO] [stdout] | [INFO] [stdout] 76 | .ok_or_else(|| InnerError::MissingStdout.with_context("Unable to take stdout"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 131 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | InnerError::MissingRequiredCommand(command.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tempserver.rs:213:42 [INFO] [stdout] | [INFO] [stdout] 213 | .with_client(|client| Ok(client.query("SELECT 1 + 1", &[]).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 19 | fn from(e: E) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | inner: e.into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 50 | fn with_context>(self, ctx: S) -> Error { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | inner: self.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:63:22 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.map_err(|e| e.into().with_context(ctx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 62 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.map_err(|e| e.into().with_context(ctx)) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn with_context>(self, ctx: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.map_err(|e| e.with_context(ctx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 27 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | InnerError::NoGitExecutableError [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 34 | fn git_ref_exists>(gitref: &str, cwd: P) -> crate::Result<()> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / Command::new("git") [INFO] [stdout] 36 | | .arg("rev-parse") [INFO] [stdout] 37 | | .arg("--verify") [INFO] [stdout] 38 | | .arg(gitref) [INFO] [stdout] ... | [INFO] [stdout] 44 | | )) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 41 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | InnerError::GitError.with_context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | fn git_status>(cwd: P) -> crate::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let cwd = cwd.as_ref(); [INFO] [stdout] 76 | / Command::new("git") [INFO] [stdout] 77 | | .arg("status") [INFO] [stdout] 78 | | .arg("--porcelain") [INFO] [stdout] 79 | | .current_dir(cwd) [INFO] [stdout] ... | [INFO] [stdout] 84 | | )) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 81 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | InnerError::GitError.with_context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:260:26 [INFO] [stdout] | [INFO] [stdout] 258 | fn new(restore: F) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | Self { [INFO] [stdout] 260 | restore: Some(Box::new(restore)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eugene` (lib test) due to 32 previous errors [INFO] running `Command { std: "docker" "inspect" "afdfb9517fa6103684f3b06ddff6db02ac894d0668beeef8532cef7a0b029a07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afdfb9517fa6103684f3b06ddff6db02ac894d0668beeef8532cef7a0b029a07", kill_on_drop: false }` [INFO] [stdout] afdfb9517fa6103684f3b06ddff6db02ac894d0668beeef8532cef7a0b029a07