[INFO] fetching crate etternaonline_api 0.2.0... [INFO] checking etternaonline_api-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate etternaonline_api 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate etternaonline_api 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate etternaonline_api 0.2.0 [INFO] finished tweaking crates.io crate etternaonline_api 0.2.0 [INFO] tweaked toml for crates.io crate etternaonline_api 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cookie v0.14.4 (latest: v0.18.1) [INFO] [stderr] Adding cookie_store v0.12.0 (latest: v0.21.0) [INFO] [stderr] Adding idna v0.2.3 (latest: v1.0.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding permutation v0.2.5 (latest: v0.4.1) [INFO] [stderr] Adding publicsuffix v1.5.6 (latest: v2.2.3) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding rustls v0.19.1 (latest: v0.23.12) [INFO] [stderr] Adding sct v0.6.1 (latest: v0.7.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding sha1 v0.6.1 (latest: v0.10.6) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding standback v0.2.17 (latest: v0.4.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding time v0.2.27 (latest: v0.3.36) [INFO] [stderr] Adding time-macros v0.1.1 (latest: v0.2.18) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding ureq v1.5.5 (latest: v2.10.1) [INFO] [stderr] Adding webpki v0.21.4 (latest: v0.22.4) [INFO] [stderr] Adding webpki-roots v0.21.1 (latest: v0.26.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53a1c2c9dd9c9b1dc247c68347993ab2c830cc0f79bb0b1c82b1d452305f627c [INFO] running `Command { std: "docker" "start" "-a" "53a1c2c9dd9c9b1dc247c68347993ab2c830cc0f79bb0b1c82b1d452305f627c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53a1c2c9dd9c9b1dc247c68347993ab2c830cc0f79bb0b1c82b1d452305f627c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53a1c2c9dd9c9b1dc247c68347993ab2c830cc0f79bb0b1c82b1d452305f627c", kill_on_drop: false }` [INFO] [stdout] 53a1c2c9dd9c9b1dc247c68347993ab2c830cc0f79bb0b1c82b1d452305f627c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a50c99b6159ecb9b5523977d243481ce95e25555495b28424a6d433048fef45b [INFO] running `Command { std: "docker" "start" "-a" "a50c99b6159ecb9b5523977d243481ce95e25555495b28424a6d433048fef45b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling const_fn v0.4.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cookie v0.14.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking permutation v0.2.5 [INFO] [stderr] Checking thiserror_lite v0.1.0 [INFO] [stderr] Checking twoway v0.2.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking etterna v0.1.0 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking cookie_store v0.12.0 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking ureq v1.5.5 [INFO] [stderr] Checking etternaonline_api v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `i32_` is never used [INFO] [stdout] --> src/extension_traits.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) trait JsonValueExt: Sized { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 90 | fn i32_(&self) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_traits.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | action: impl FnOnce(&'val serde_json::Value) -> Option, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | ) -> Result { [INFO] [stdout] 24 | match action(self.get()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_traits.rs:81:56 [INFO] [stdout] | [INFO] [stdout] 81 | let how_were_retrieving_it = |j: &serde_json::Value| j.as_str()?.parse::().ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/mod.rs:119:10 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(initial_authorization: T) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | lock: std::sync::RwLock::new(initial_authorization), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `i32_` is never used [INFO] [stdout] --> src/extension_traits.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) trait JsonValueExt: Sized { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 90 | fn i32_(&self) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_traits.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | action: impl FnOnce(&'val serde_json::Value) -> Option, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | ) -> Result { [INFO] [stdout] 24 | match action(self.get()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension_traits.rs:81:56 [INFO] [stdout] | [INFO] [stdout] 81 | let how_were_retrieving_it = |j: &serde_json::Value| j.as_str()?.parse::().ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/mod.rs:119:10 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(initial_authorization: T) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | lock: std::sync::RwLock::new(initial_authorization), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etternaonline_api` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `etternaonline_api` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a50c99b6159ecb9b5523977d243481ce95e25555495b28424a6d433048fef45b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a50c99b6159ecb9b5523977d243481ce95e25555495b28424a6d433048fef45b", kill_on_drop: false }` [INFO] [stdout] a50c99b6159ecb9b5523977d243481ce95e25555495b28424a6d433048fef45b