[INFO] fetching crate ethers_signer 0.2.2... [INFO] checking ethers_signer-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ethers_signer 0.2.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ethers_signer 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ethers_signer 0.2.2 [INFO] finished tweaking crates.io crate ethers_signer 0.2.2 [INFO] tweaked toml for crates.io crate ethers_signer 0.2.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 217 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding base16ct v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding crypto-bigint v0.4.9 (latest: v0.5.5) [INFO] [stderr] Adding der v0.6.1 (latest: v0.7.9) [INFO] [stderr] Adding ecdsa v0.15.1 (latest: v0.16.9) [INFO] [stderr] Adding elliptic-curve v0.12.3 (latest: v0.13.8) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding ff v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding group v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding k256 v0.12.0 (latest: v0.13.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (latest: v0.12.2) [INFO] [stderr] Adding pkcs8 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rfc6979 v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding scrypt v0.10.0 (latest: v0.11.0) [INFO] [stderr] Adding sec1 v0.3.0 (latest: v0.7.3) [INFO] [stderr] Adding signature v2.0.0 (latest: v2.2.0) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding spki v0.6.0 (latest: v0.7.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8395d49a1185dbd25ca6c83f2e9f74ef67556e2c2d956c661a893b2cc335dc52 [INFO] running `Command { std: "docker" "start" "-a" "8395d49a1185dbd25ca6c83f2e9f74ef67556e2c2d956c661a893b2cc335dc52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8395d49a1185dbd25ca6c83f2e9f74ef67556e2c2d956c661a893b2cc335dc52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8395d49a1185dbd25ca6c83f2e9f74ef67556e2c2d956c661a893b2cc335dc52", kill_on_drop: false }` [INFO] [stdout] 8395d49a1185dbd25ca6c83f2e9f74ef67556e2c2d956c661a893b2cc335dc52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed11f6e4d4fb1262c0eacae320e5ccee48ab227cbc9d493b428ea21e2af0da49 [INFO] running `Command { std: "docker" "start" "-a" "ed11f6e4d4fb1262c0eacae320e5ccee48ab227cbc9d493b428ea21e2af0da49", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.0.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking async-timer-rs v0.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking scrypt v0.10.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking ecdsa v0.15.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking k256 v0.12.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking serde_ethabi v0.2.2 [INFO] [stderr] Checking serde_ethrlp v0.2.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking completeq-rs v0.1.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking jsonrpc-rs v0.1.6 [INFO] [stderr] Checking ethers_primitives v0.2.2 [INFO] [stderr] Checking serde_eip712 v0.2.2 [INFO] [stderr] Checking ethers_wallet v0.2.2 [INFO] [stderr] Checking ethers_eip2718 v0.2.2 [INFO] [stderr] Checking ethers_eip712 v0.2.2 [INFO] [stderr] Checking ethers_signer v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:42:48 [INFO] [stdout] | [INFO] [stdout] 42 | let executor = INSTANCE.get_or_init(|| ThreadPool::new().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 67 | fn try_into_signer(self) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let (client_output, dispatcher_input) = mpsc::channel(20); [INFO] [stdout] | ------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let (dispatcher_output, client_input) = mpsc::channel(20); [INFO] [stdout] | ----------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let client_transport = LocalWalletChannel { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Signer::new(jsonrpc_rs::Client::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | format!("local_wallet_{}", address.to_checksum_string()), [INFO] [stdout] 125 | | client_transport, [INFO] [stdout] 126 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 87 | let wallet = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | sign_transaction(wallet.clone(), tx) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 94 | let wallet = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | sign_typed_data(wallet.clone(), typed_data) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet.rs:104:71 [INFO] [stdout] | [INFO] [stdout] 101 | let wallet = self.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | server.async_handle("signer_decrypt", move |data| decrypt(wallet.clone(), data)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ethers_signer` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ed11f6e4d4fb1262c0eacae320e5ccee48ab227cbc9d493b428ea21e2af0da49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed11f6e4d4fb1262c0eacae320e5ccee48ab227cbc9d493b428ea21e2af0da49", kill_on_drop: false }` [INFO] [stdout] ed11f6e4d4fb1262c0eacae320e5ccee48ab227cbc9d493b428ea21e2af0da49