[INFO] fetching crate etherip 0.1.1... [INFO] checking etherip-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate etherip 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate etherip 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate etherip 0.1.1 [INFO] finished tweaking crates.io crate etherip 0.1.1 [INFO] tweaked toml for crates.io crate etherip 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate etherip 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0a09d518c0eba526ed3e6230fba0387313af3c7bcaf5a848fb802219cfb0268 [INFO] running `Command { std: "docker" "start" "-a" "f0a09d518c0eba526ed3e6230fba0387313af3c7bcaf5a848fb802219cfb0268", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0a09d518c0eba526ed3e6230fba0387313af3c7bcaf5a848fb802219cfb0268", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0a09d518c0eba526ed3e6230fba0387313af3c7bcaf5a848fb802219cfb0268", kill_on_drop: false }` [INFO] [stdout] f0a09d518c0eba526ed3e6230fba0387313af3c7bcaf5a848fb802219cfb0268 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b5ff4672c4e30ab8874cb9370c94a1e819dbb0f08fea2d1a375f95fd882f865 [INFO] running `Command { std: "docker" "start" "-a" "8b5ff4672c4e30ab8874cb9370c94a1e819dbb0f08fea2d1a375f95fd882f865", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling libc v0.2.156 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking syslog v6.1.1 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking etherip v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn new(protocol: P) -> std::io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let socket = RawIpSocket::new(protocol.protocol_number())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 212 | | inner: AsyncFd::with_interest(socket, Interest::READABLE | Interest::WRITABLE)?, [INFO] [stdout] 213 | | protocol, [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:219:8 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new_with_fragment_config(protocol: P, fragment_config: FragmentConfig) -> std::io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let socket = RawIpSocket::new_with_fragment_config(protocol.protocol_number(), fragment_config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 220 | | inner: AsyncFd::with_interest(socket, Interest::READABLE | Interest::WRITABLE)?, [INFO] [stdout] 221 | | protocol, [INFO] [stdout] 222 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 301 | let inner = IpSocket::new(EtherIp ())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 303 | | inner, [INFO] [stdout] 304 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 174 | let tap = RawTap::new(ifname)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let inner = AsyncFd::with_interest(tap, Interest::READABLE | Interest::WRITABLE)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etherip` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn new(protocol: P) -> std::io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | let socket = RawIpSocket::new(protocol.protocol_number())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 212 | | inner: AsyncFd::with_interest(socket, Interest::READABLE | Interest::WRITABLE)?, [INFO] [stdout] 213 | | protocol, [INFO] [stdout] 214 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:219:8 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new_with_fragment_config(protocol: P, fragment_config: FragmentConfig) -> std::io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let socket = RawIpSocket::new_with_fragment_config(protocol.protocol_number(), fragment_config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 220 | | inner: AsyncFd::with_interest(socket, Interest::READABLE | Interest::WRITABLE)?, [INFO] [stdout] 221 | | protocol, [INFO] [stdout] 222 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 301 | let inner = IpSocket::new(EtherIp ())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 303 | | inner, [INFO] [stdout] 304 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 174 | let tap = RawTap::new(ifname)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let inner = AsyncFd::with_interest(tap, Interest::READABLE | Interest::WRITABLE)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etherip` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "8b5ff4672c4e30ab8874cb9370c94a1e819dbb0f08fea2d1a375f95fd882f865", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b5ff4672c4e30ab8874cb9370c94a1e819dbb0f08fea2d1a375f95fd882f865", kill_on_drop: false }` [INFO] [stdout] 8b5ff4672c4e30ab8874cb9370c94a1e819dbb0f08fea2d1a375f95fd882f865