[INFO] fetching crate ethereum-trie-memory 0.5.0... [INFO] checking ethereum-trie-memory-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ethereum-trie-memory 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ethereum-trie-memory 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ethereum-trie-memory 0.5.0 [INFO] finished tweaking crates.io crate ethereum-trie-memory 0.5.0 [INFO] tweaked toml for crates.io crate ethereum-trie-memory 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.2.0 (latest: v0.10.4) [INFO] [stderr] Adding byte-tools v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding digest v0.6.1 (latest: v0.10.7) [INFO] [stderr] Adding elastic-array-plus v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding generic-array v0.8.4 (latest: v1.1.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding sha3 v0.6.0 (latest: v0.10.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e52938261506a676dd8e48c3277347cb68d08dfe7bd8a7cf6773fb37f577e6b3 [INFO] running `Command { std: "docker" "start" "-a" "e52938261506a676dd8e48c3277347cb68d08dfe7bd8a7cf6773fb37f577e6b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e52938261506a676dd8e48c3277347cb68d08dfe7bd8a7cf6773fb37f577e6b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e52938261506a676dd8e48c3277347cb68d08dfe7bd8a7cf6773fb37f577e6b3", kill_on_drop: false }` [INFO] [stdout] e52938261506a676dd8e48c3277347cb68d08dfe7bd8a7cf6773fb37f577e6b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58c46c7c67e32207dcd414ccdb6a0d3eb892602bbf18cca87c391f73706da5c7 [INFO] running `Command { std: "docker" "start" "-a" "58c46c7c67e32207dcd414ccdb6a0d3eb892602bbf18cca87c391f73706da5c7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking ethereum-hexutil v0.2.3 [INFO] [stderr] Checking elastic-array-plus v0.9.1 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking generic-array v0.8.4 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking digest v0.6.1 [INFO] [stderr] Checking ethereum-rlp v0.2.3 [INFO] [stderr] Checking sha3 v0.6.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking ethereum-bigint v0.2.9 [INFO] [stderr] Checking ethereum-trie v0.5.0 [INFO] [stderr] Checking ethereum-trie-memory v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseHandle` [INFO] [stdout] --> src/memory.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | use trie::{DatabaseHandle, Change, insert, delete, build, get, EMPTY_TRIE_HASH}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rlp` [INFO] [stdout] --> src/mutable.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `trie::merkle::MerkleNode` [INFO] [stdout] --> src/cache.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use trie::merkle::MerkleNode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rlp::Rlp` [INFO] [stdout] --> src/cache.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::Rlp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseHandle` [INFO] [stdout] --> src/memory.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | use trie::{DatabaseHandle, Change, insert, delete, build, get, EMPTY_TRIE_HASH}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `trie::merkle::MerkleNode` [INFO] [stdout] --> src/memory.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | use trie::merkle::MerkleNode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rlp::Rlp` [INFO] [stdout] --> src/memory.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | use rlp::Rlp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::UnsafeCell` [INFO] [stdout] --> src/memory.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | use std::cell::UnsafeCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hexutil::read_hex` [INFO] [stdout] --> src/memory.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | use hexutil::read_hex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rlp` [INFO] [stdout] --> src/mutable.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `trie::merkle::MerkleNode` [INFO] [stdout] --> src/cache.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use trie::merkle::MerkleNode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rlp::Rlp` [INFO] [stdout] --> src/cache.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::Rlp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cache.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut map = self.map.borrow_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cache.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let mut map = self.map.borrow_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(db: D) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | cache: Cache::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | FixedTrieMut(AnyTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | AnySecureTrieMut(SecureTrieMut::new(trie)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | FixedSecureTrieMut(AnySecureTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/cache.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | unsafe { Box::from_raw(ptr); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | unsafe { let _ = Box::from_raw(ptr); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/memory.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 134 | for (key, value) in &map { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ethereum-trie-memory` (lib) due to 5 previous errors; 8 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/memory.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let mut btrie = MemoryTrieMut::build(&map); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cache.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let mut map = self.map.borrow_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cache.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let mut map = self.map.borrow_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(db: D) -> Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | cache: Cache::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | FixedTrieMut(AnyTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | AnySecureTrieMut(SecureTrieMut::new(trie)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | FixedSecureTrieMut(AnySecureTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/cache.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | unsafe { Box::from_raw(ptr); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | unsafe { let _ = Box::from_raw(ptr); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ethereum-trie-memory` (lib test) due to 5 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "58c46c7c67e32207dcd414ccdb6a0d3eb892602bbf18cca87c391f73706da5c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58c46c7c67e32207dcd414ccdb6a0d3eb892602bbf18cca87c391f73706da5c7", kill_on_drop: false }` [INFO] [stdout] 58c46c7c67e32207dcd414ccdb6a0d3eb892602bbf18cca87c391f73706da5c7