[INFO] fetching crate ether 0.1.4... [INFO] checking ether-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ether 0.1.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ether 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ether 0.1.4 [INFO] finished tweaking crates.io crate ether 0.1.4 [INFO] tweaked toml for crates.io crate ether 0.1.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding glob v0.2.11 (latest: v0.3.1) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcf4cc71c59872b3413e0617682a0b6b29761f3ee514d7f6137c842df103491b [INFO] running `Command { std: "docker" "start" "-a" "fcf4cc71c59872b3413e0617682a0b6b29761f3ee514d7f6137c842df103491b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcf4cc71c59872b3413e0617682a0b6b29761f3ee514d7f6137c842df103491b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcf4cc71c59872b3413e0617682a0b6b29761f3ee514d7f6137c842df103491b", kill_on_drop: false }` [INFO] [stdout] fcf4cc71c59872b3413e0617682a0b6b29761f3ee514d7f6137c842df103491b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de13e032a5228c7ec3c640404194969e5eb79e904770b638bc8624dc189f2130 [INFO] running `Command { std: "docker" "start" "-a" "de13e032a5228c7ec3c640404194969e5eb79e904770b638bc8624dc189f2130", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking ether v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | let file = try!(open()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | try!(pselect(self.file, Some(self.fd_set), None, self.timeout)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | try!(pselect(self.file, None, Some(self.fd_set), self.timeout)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | try!(self.file.write_all(packet)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | let file = try!(open()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | try!(pselect(self.file, Some(self.fd_set), None, self.timeout)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 258 | try!(pselect(self.file, None, Some(self.fd_set), self.timeout)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/tap/tap.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | try!(self.file.write_all(packet)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | k: libc::uint32_t, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:92:42 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn BPF_STMT(code: c_ushort, k: libc::uint32_t) -> bpf_insn { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:101:42 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn BPF_JUMP(code: c_ushort, k: libc::uint32_t, jt: c_uchar, jf: c_uchar) -> bpf_insn { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:89:14 [INFO] [stdout] | [INFO] [stdout] 89 | k: libc::uint32_t, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:92:42 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn BPF_STMT(code: c_ushort, k: libc::uint32_t) -> bpf_insn { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/tap/bindings/bpf.rs:101:42 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn BPF_JUMP(code: c_ushort, k: libc::uint32_t, jt: c_uchar, jf: c_uchar) -> bpf_insn { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 67 | fn new(buffer: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | reader: BufReader::new(buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(capture: R) -> PacketCapture { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | PacketCapture { capture: Buffer::new(capture) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn parse(mut self) -> io::Result<(Header, Records)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Ok((Header::parse(&mut self.capture)?, Records { capture: self.capture })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap/tap.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 98 | let file = try!(open()); [INFO] [stdout] | ---- ------------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Tap { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | fd_set: fd_set, [INFO] [stdout] 174 | | config: config, [INFO] [stdout] 175 | | file: file, [INFO] [stdout] 176 | | }) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 67 | fn new(buffer: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | reader: BufReader::new(buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(capture: R) -> PacketCapture { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | PacketCapture { capture: Buffer::new(capture) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pcap/pcap.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn parse(mut self) -> io::Result<(Header, Records)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Ok((Header::parse(&mut self.capture)?, Records { capture: self.capture })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap/tap.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 98 | let file = try!(open()); [INFO] [stdout] | ---- ------------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Tap { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | fd_set: fd_set, [INFO] [stdout] 174 | | config: config, [INFO] [stdout] 175 | | file: file, [INFO] [stdout] 176 | | }) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ether` (lib test) due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ether` (lib) due to 5 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "de13e032a5228c7ec3c640404194969e5eb79e904770b638bc8624dc189f2130", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de13e032a5228c7ec3c640404194969e5eb79e904770b638bc8624dc189f2130", kill_on_drop: false }` [INFO] [stdout] de13e032a5228c7ec3c640404194969e5eb79e904770b638bc8624dc189f2130