[INFO] fetching crate eth_event_stream 0.1.0... [INFO] checking eth_event_stream-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate eth_event_stream 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate eth_event_stream 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate eth_event_stream 0.1.0 [INFO] finished tweaking crates.io crate eth_event_stream 0.1.0 [INFO] tweaked toml for crates.io crate eth_event_stream 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate eth_event_stream 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76ca1de3e8571d193b410d031c1f26dad44f54013bfac8139208e4eacec43430 [INFO] running `Command { std: "docker" "start" "-a" "76ca1de3e8571d193b410d031c1f26dad44f54013bfac8139208e4eacec43430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76ca1de3e8571d193b410d031c1f26dad44f54013bfac8139208e4eacec43430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76ca1de3e8571d193b410d031c1f26dad44f54013bfac8139208e4eacec43430", kill_on_drop: false }` [INFO] [stdout] 76ca1de3e8571d193b410d031c1f26dad44f54013bfac8139208e4eacec43430 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad26dae3b6af347e6c3a93b1ca23c54b4ec335a0e1cb924a92245988eb45aead [INFO] running `Command { std: "docker" "start" "-a" "ad26dae3b6af347e6c3a93b1ca23c54b4ec335a0e1cb924a92245988eb45aead", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling pin-project-lite v0.2.9 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling smallvec v1.8.1 [INFO] [stderr] Compiling itoa v1.0.2 [INFO] [stderr] Compiling futures-sink v0.3.21 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Compiling futures-io v0.3.21 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Compiling signal-hook-registry v1.4.0 [INFO] [stderr] Compiling socket2 v0.4.4 [INFO] [stderr] Compiling num_cpus v1.13.1 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling slab v0.4.6 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling http v0.2.8 [INFO] [stderr] Compiling rustc-hex v2.1.0 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling tracing-core v0.1.28 [INFO] [stderr] Compiling secp256k1-sys v0.4.2 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling tinyvec_macros v0.1.0 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling matches v0.1.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling funty v1.1.0 [INFO] [stderr] Compiling tap v1.0.1 [INFO] [stderr] Compiling wyz v0.2.0 [INFO] [stderr] Compiling tracing v0.1.35 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling rlp v0.5.1 [INFO] [stderr] Compiling bitvec v0.20.4 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Compiling openssl-probe v0.1.5 [INFO] [stderr] Compiling block-padding v0.2.1 [INFO] [stderr] Compiling byte-slice-cast v1.2.1 [INFO] [stderr] Compiling ryu v1.0.10 [INFO] [stderr] Compiling arrayvec v0.7.2 [INFO] [stderr] Compiling fixed-hash v0.7.0 [INFO] [stderr] Compiling form_urlencoded v1.0.1 [INFO] [stderr] Compiling block-buffer v0.9.0 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Compiling impl-rlp v0.3.0 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling unicode-bidi v0.3.8 [INFO] [stderr] Compiling cpufeatures v0.2.2 [INFO] [stderr] Compiling try-lock v0.2.3 [INFO] [stderr] Compiling httpdate v1.0.2 [INFO] [stderr] Compiling opaque-debug v0.3.0 [INFO] [stderr] Compiling want v0.3.0 [INFO] [stderr] Compiling uint v0.9.3 [INFO] [stderr] Checking unicode-normalization v0.1.20 [INFO] [stderr] Compiling crypto-common v0.1.3 [INFO] [stderr] Compiling block-buffer v0.10.2 [INFO] [stderr] Compiling http-body v0.4.5 [INFO] [stderr] Compiling base64 v0.13.0 [INFO] [stderr] Compiling tower-service v0.3.2 [INFO] [stderr] Compiling digest v0.10.3 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling keccak v0.1.2 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling mime v0.3.16 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling sha-1 v0.10.0 [INFO] [stderr] Compiling sha-1 v0.9.8 [INFO] [stderr] Compiling headers-core v0.2.0 [INFO] [stderr] Compiling sha3 v0.9.1 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling ipnet v2.5.0 [INFO] [stderr] Compiling headers v0.3.7 [INFO] [stderr] Compiling secp256k1 v0.21.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling futures-timer v3.0.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking clap_lex v0.2.3 [INFO] [stderr] Compiling nom v7.1.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling clap_derive v3.2.6 [INFO] [stderr] Compiling tokio v1.19.2 [INFO] [stderr] Compiling thiserror v1.0.31 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking clap v3.2.6 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking soketto v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking web3-async-native-tls v0.4.0 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking tokio-retry v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking impl-serde v0.3.2 [INFO] [stderr] Checking serde_json v1.0.81 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ethbloom v0.11.1 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Checking jsonrpc-core v18.0.0 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling parity-scale-codec-derive v2.3.1 [INFO] [stderr] Compiling parity-scale-codec v2.3.1 [INFO] [stderr] Compiling hyper v0.14.19 [INFO] [stderr] Compiling impl-codec v0.5.1 [INFO] [stderr] Compiling primitive-types v0.10.1 [INFO] [stderr] Compiling ethereum-types v0.12.1 [INFO] [stderr] Compiling ethabi v16.0.0 [INFO] [stderr] Compiling hyper-tls v0.5.0 [INFO] [stderr] Compiling reqwest v0.11.11 [INFO] [stderr] Compiling web3 v0.18.0 [INFO] [stderr] Compiling eth_event_macro v0.1.0 [INFO] [stderr] Checking eth_event_stream v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/sink.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::cmp::{self, max, Ord}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/sink.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | use std::cmp::{self, max, Ord}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Log` [INFO] [stdout] --> src/stream.rs:312:32 [INFO] [stdout] | [INFO] [stdout] 312 | use web3::types::{Address, Log}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `put_sync` is never used [INFO] [stdout] --> src/sink.rs:299:8 [INFO] [stdout] | [INFO] [stdout] 153 | impl Sink { [INFO] [stdout] | ------------------------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 299 | fn put_sync(&mut self, source_key: &A, block_key: u64, log_key: u128, data: D) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_feed/pubsub.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(init: A) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let (s, _rx) = watch::channel(init); [INFO] [stdout] | - --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | PubSub { [INFO] [stdout] 17 | arc: Arc::new(s), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn new_threadsafe(sources: Vec, from_block: u64) -> Arc> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Arc::new(Mutex::new(Sink::new(sources, from_block))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:150:51 [INFO] [stdout] | [INFO] [stdout] 150 | let res = Retry::spawn(retry_strategy, || self.web3.eth().block_number()).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eth_event_stream` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_feed/pubsub.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(init: A) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let (s, _rx) = watch::channel(init); [INFO] [stdout] | - --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | PubSub { [INFO] [stdout] 17 | arc: Arc::new(s), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn new_threadsafe(sources: Vec, from_block: u64) -> Arc> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Arc::new(Mutex::new(Sink::new(sources, from_block))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:150:51 [INFO] [stdout] | [INFO] [stdout] 150 | let res = Retry::spawn(retry_strategy, || self.web3.eth().block_number()).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:357:57 [INFO] [stdout] | [INFO] [stdout] 354 | let (mut stream, sink, to_block) = test_stream().await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 357 | tokio::spawn(async move { stream.block_stream().await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `eth_event_stream` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ad26dae3b6af347e6c3a93b1ca23c54b4ec335a0e1cb924a92245988eb45aead", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad26dae3b6af347e6c3a93b1ca23c54b4ec335a0e1cb924a92245988eb45aead", kill_on_drop: false }` [INFO] [stdout] ad26dae3b6af347e6c3a93b1ca23c54b4ec335a0e1cb924a92245988eb45aead