[INFO] fetching crate etcommon-trie 0.4.0... [INFO] checking etcommon-trie-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate etcommon-trie 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate etcommon-trie 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate etcommon-trie 0.4.0 [INFO] finished tweaking crates.io crate etcommon-trie 0.4.0 [INFO] tweaked toml for crates.io crate etcommon-trie 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.2.0 (latest: v0.10.4) [INFO] [stderr] Adding byte-tools v0.2.0 (latest: v0.3.1) [INFO] [stderr] Adding digest v0.6.1 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.8.4 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding sha3 v0.6.0 (latest: v0.10.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9d78bcfb7a2a0db1574b8c32d4c527c72398e21de419a7de971e68d4ae4be00 [INFO] running `Command { std: "docker" "start" "-a" "e9d78bcfb7a2a0db1574b8c32d4c527c72398e21de419a7de971e68d4ae4be00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9d78bcfb7a2a0db1574b8c32d4c527c72398e21de419a7de971e68d4ae4be00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9d78bcfb7a2a0db1574b8c32d4c527c72398e21de419a7de971e68d4ae4be00", kill_on_drop: false }` [INFO] [stdout] e9d78bcfb7a2a0db1574b8c32d4c527c72398e21de419a7de971e68d4ae4be00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4758c7cf88e44786dea833f83f9a96fa916c667036e467a4b5a91bcb8992d2b4 [INFO] running `Command { std: "docker" "start" "-a" "4758c7cf88e44786dea833f83f9a96fa916c667036e467a4b5a91bcb8992d2b4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking elastic-array-plus v0.10.0 [INFO] [stderr] Checking etcommon-hexutil v0.2.4 [INFO] [stderr] Checking generic-array v0.8.4 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking digest v0.6.1 [INFO] [stderr] Checking etcommon-rlp v0.2.5 [INFO] [stderr] Checking sha3 v0.6.0 [INFO] [stderr] Checking etcommon-bigint v0.2.10 [INFO] [stderr] Checking etcommon-trie v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/lib.rs:13:28 [INFO] [stdout] | [INFO] [stdout] 13 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decodable`, `Encodable`, and `Prototype` [INFO] [stdout] --> src/merkle/nibble.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/merkle/nibble.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Formatter` and `self` [INFO] [stdout] --> src/merkle/nibble.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::fmt::{self, Debug, Formatter}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use super::nibble::{self, Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Keccak256` [INFO] [stdout] --> src/merkle/node.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | use sha3::{Digest, Keccak256}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:163:32 [INFO] [stdout] | [INFO] [stdout] 163 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleType`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/mod.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | use self::nibble::{Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/ops/insert.rs:2:39 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/insert.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `self` [INFO] [stdout] --> src/ops/delete.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/delete.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NibbleSlice` [INFO] [stdout] --> src/ops/build.rs:2:39 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rlp` and `self` [INFO] [stdout] --> src/ops/build.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `Nibble`, and `self` [INFO] [stdout] --> src/ops/get.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Change` [INFO] [stdout] --> src/ops/get.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | use {Change, DatabaseHandle}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/get.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `merkle::MerkleNode` [INFO] [stdout] --> src/memory.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | use merkle::MerkleNode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rlp::Rlp` [INFO] [stdout] --> src/memory.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | use rlp::Rlp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::UnsafeCell` [INFO] [stdout] --> src/memory.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | use std::cell::UnsafeCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rlp` [INFO] [stdout] --> src/mutable.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/lib.rs:13:28 [INFO] [stdout] | [INFO] [stdout] 13 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Decodable`, `Encodable`, and `Prototype` [INFO] [stdout] --> src/merkle/nibble.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/merkle/nibble.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Formatter` and `self` [INFO] [stdout] --> src/merkle/nibble.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | use std::fmt::{self, Debug, Formatter}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/merkle/node.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use super::nibble::{self, Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `NibbleType`, `NibbleVec`, and `Nibble` [INFO] [stdout] --> src/merkle/mod.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | use self::nibble::{Nibble, NibbleVec, NibbleSlice, NibbleType}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `Nibble` [INFO] [stdout] --> src/ops/insert.rs:2:39 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/insert.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice` and `self` [INFO] [stdout] --> src/ops/delete.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/delete.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NibbleSlice` [INFO] [stdout] --> src/ops/build.rs:2:39 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Rlp` and `self` [INFO] [stdout] --> src/ops/build.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `NibbleSlice`, `Nibble`, and `self` [INFO] [stdout] --> src/ops/get.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use merkle::nibble::{self, NibbleVec, NibbleSlice, Nibble}; [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Change` [INFO] [stdout] --> src/ops/get.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | use {Change, DatabaseHandle}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/ops/get.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rlp` [INFO] [stdout] --> src/mutable.rs:2:17 [INFO] [stdout] | [INFO] [stdout] 2 | use rlp::{self, Rlp}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hasher` [INFO] [stdout] --> src/merkle/nibble.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | use std::hash::{Hash, Hasher}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Decodable` [INFO] [stdout] --> src/merkle/node.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseHandle` [INFO] [stdout] --> src/ops/build.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use {Change, DatabaseHandle}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hasher` [INFO] [stdout] --> src/merkle/nibble.rs:6:23 [INFO] [stdout] | [INFO] [stdout] 6 | use std::hash::{Hash, Hasher}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Decodable` [INFO] [stdout] --> src/merkle/node.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use rlp::{self, RlpStream, Encodable, Decodable, Rlp, Prototype}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/merkle/node.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | use sha3::{Digest, Keccak256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DatabaseHandle` [INFO] [stdout] --> src/ops/build.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use {Change, DatabaseHandle}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/merkle/node.rs:63:55 [INFO] [stdout] | [INFO] [stdout] 63 | MerkleNode::Leaf(nibble.clone(), value.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:38:6 [INFO] [stdout] | [INFO] [stdout] 8 | anibble: NibbleVec, avalue: MerkleValue<'a>, bnibble: NibbleVec, bvalue: &'a [u8] [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let mut change = Change::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mut additional = None; [INFO] [stdout] 14 | let mut nodes = empty_nodes!(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | (MerkleNode::Branch(nodes, additional), change) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 47 | let mut change = Change::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut additional = None; [INFO] [stdout] 49 | let mut nodes = empty_nodes!(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | (MerkleNode::Branch(nodes, additional), change) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:172:11 [INFO] [stdout] | [INFO] [stdout] 171 | let new = MerkleNode::Leaf(nibble, value); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | (new, Change::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:56:40 [INFO] [stdout] | [INFO] [stdout] 56 | nodes.iter().filter(|v| v != &&MerkleValue::Empty).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | .filter(|&(_, v)| v != &MerkleValue::Empty).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | .map(|(i, v)| (i, v.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:14:54 [INFO] [stdout] | [INFO] [stdout] 14 | submap.insert(key[common_len..].into(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:32:68 [INFO] [stdout] | [INFO] [stdout] 32 | return (MerkleNode::Leaf(key.clone(), map.get(key).unwrap().clone()), change); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:72:39 [INFO] [stdout] | [INFO] [stdout] 72 | .map(|(_key, value)| value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | FixedTrieMut(AnyTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | AnySecureTrieMut(SecureTrieMut::new(trie)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | FixedSecureTrieMut(AnySecureTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/memory.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | for (key, value) in &map { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/memory.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | let mut btrie = MemoryTrieMut::build(&map); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etcommon-trie` (lib) due to 10 previous errors; 23 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/merkle/node.rs:63:55 [INFO] [stdout] | [INFO] [stdout] 63 | MerkleNode::Leaf(nibble.clone(), value.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:38:6 [INFO] [stdout] | [INFO] [stdout] 8 | anibble: NibbleVec, avalue: MerkleValue<'a>, bnibble: NibbleVec, bvalue: &'a [u8] [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let mut change = Change::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let mut additional = None; [INFO] [stdout] 14 | let mut nodes = empty_nodes!(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | (MerkleNode::Branch(nodes, additional), change) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 47 | let mut change = Change::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut additional = None; [INFO] [stdout] 49 | let mut nodes = empty_nodes!(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | (MerkleNode::Branch(nodes, additional), change) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/insert.rs:172:11 [INFO] [stdout] | [INFO] [stdout] 171 | let new = MerkleNode::Leaf(nibble, value); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | (new, Change::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:56:40 [INFO] [stdout] | [INFO] [stdout] 56 | nodes.iter().filter(|v| v != &&MerkleValue::Empty).count() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | .filter(|&(_, v)| v != &MerkleValue::Empty).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/delete.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | .map(|(i, v)| (i, v.clone())).unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:14:54 [INFO] [stdout] | [INFO] [stdout] 14 | submap.insert(key[common_len..].into(), value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:32:68 [INFO] [stdout] | [INFO] [stdout] 32 | return (MerkleNode::Leaf(key.clone(), map.get(key).unwrap().clone()), change); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&[u8]` instead of cloning the inner type [INFO] [stdout] --> src/ops/build.rs:72:39 [INFO] [stdout] | [INFO] [stdout] 72 | .map(|(_key, value)| value.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | FixedTrieMut(AnyTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | AnySecureTrieMut(SecureTrieMut::new(trie)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutable.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn new(trie: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | FixedSecureTrieMut(AnySecureTrieMut::new(trie), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etcommon-trie` (lib test) due to 10 previous errors; 31 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4758c7cf88e44786dea833f83f9a96fa916c667036e467a4b5a91bcb8992d2b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4758c7cf88e44786dea833f83f9a96fa916c667036e467a4b5a91bcb8992d2b4", kill_on_drop: false }` [INFO] [stdout] 4758c7cf88e44786dea833f83f9a96fa916c667036e467a4b5a91bcb8992d2b4