[INFO] fetching crate etc-os-release 0.1.0... [INFO] checking etc-os-release-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate etc-os-release 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate etc-os-release 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate etc-os-release 0.1.0 [INFO] finished tweaking crates.io crate etc-os-release 0.1.0 [INFO] tweaked toml for crates.io crate etc-os-release 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ed038077c34f2c0fe512d3d23666a235fdafeb062c6698e6d1bc9bfa1acf57e [INFO] running `Command { std: "docker" "start" "-a" "3ed038077c34f2c0fe512d3d23666a235fdafeb062c6698e6d1bc9bfa1acf57e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ed038077c34f2c0fe512d3d23666a235fdafeb062c6698e6d1bc9bfa1acf57e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ed038077c34f2c0fe512d3d23666a235fdafeb062c6698e6d1bc9bfa1acf57e", kill_on_drop: false }` [INFO] [stdout] 3ed038077c34f2c0fe512d3d23666a235fdafeb062c6698e6d1bc9bfa1acf57e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33838c6b12c1c108c47d02c3d6778b711c8d91f18cd24817b8730e42e023a418 [INFO] running `Command { std: "docker" "start" "-a" "33838c6b12c1c108c47d02c3d6778b711c8d91f18cd24817b8730e42e023a418", kill_on_drop: false }` [INFO] [stderr] Checking etc-os-release v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_reader(reader: impl io::Read) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let reader = BufReader::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | / reader [INFO] [stdout] 60 | | .lines() [INFO] [stdout] 61 | | .collect::>() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_reader(reader: impl io::Read) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let reader = BufReader::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | / reader [INFO] [stdout] 60 | | .lines() [INFO] [stdout] 61 | | .collect::>() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | fields: iter [INFO] [stdout] | _____________________^ [INFO] [stdout] 73 | | .into_iter() [INFO] [stdout] 74 | | .map(|entry| (entry.key().to_owned(), entry.value().to_owned())) [INFO] [stdout] 75 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 81 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | / iter.into_iter() [INFO] [stdout] 86 | | .filter_map(|line| { [INFO] [stdout] 87 | | OsReleaseLine::from_str(line) [INFO] [stdout] 88 | | .ok() [INFO] [stdout] 89 | | .and_then(|line| line.into_entry()) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 96 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / iter.into_iter() [INFO] [stdout] 101 | | .filter_map(|line| { [INFO] [stdout] 102 | | OsReleaseLine::from_str(&line) [INFO] [stdout] 103 | | .ok() [INFO] [stdout] 104 | | .and_then(|line| line.into_entry()) [INFO] [stdout] 105 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | fields: iter [INFO] [stdout] | _____________________^ [INFO] [stdout] 73 | | .into_iter() [INFO] [stdout] 74 | | .map(|entry| (entry.key().to_owned(), entry.value().to_owned())) [INFO] [stdout] 75 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 81 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | / iter.into_iter() [INFO] [stdout] 86 | | .filter_map(|line| { [INFO] [stdout] 87 | | OsReleaseLine::from_str(line) [INFO] [stdout] 88 | | .ok() [INFO] [stdout] 89 | | .and_then(|line| line.into_entry()) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/construct.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 96 | fn from_iter(iter: T) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / iter.into_iter() [INFO] [stdout] 101 | | .filter_map(|line| { [INFO] [stdout] 102 | | OsReleaseLine::from_str(&line) [INFO] [stdout] 103 | | .ok() [INFO] [stdout] 104 | | .and_then(|line| line.into_entry()) [INFO] [stdout] 105 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etc-os-release` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `etc-os-release` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "33838c6b12c1c108c47d02c3d6778b711c8d91f18cd24817b8730e42e023a418", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33838c6b12c1c108c47d02c3d6778b711c8d91f18cd24817b8730e42e023a418", kill_on_drop: false }` [INFO] [stdout] 33838c6b12c1c108c47d02c3d6778b711c8d91f18cd24817b8730e42e023a418