[INFO] fetching crate esvc-core 0.1.0... [INFO] checking esvc-core-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate esvc-core 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate esvc-core 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esvc-core 0.1.0 [INFO] finished tweaking crates.io crate esvc-core 0.1.0 [INFO] tweaked toml for crates.io crate esvc-core 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding serde_with v1.14.0 (latest: v3.9.0) [INFO] [stderr] Adding serde_with_macros v1.5.2 (latest: v3.9.0) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eccbe0a4c69db028531920f45111c218fefb84fa212ea7f392253ffbaaa2cebb [INFO] running `Command { std: "docker" "start" "-a" "eccbe0a4c69db028531920f45111c218fefb84fa212ea7f392253ffbaaa2cebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eccbe0a4c69db028531920f45111c218fefb84fa212ea7f392253ffbaaa2cebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eccbe0a4c69db028531920f45111c218fefb84fa212ea7f392253ffbaaa2cebb", kill_on_drop: false }` [INFO] [stdout] eccbe0a4c69db028531920f45111c218fefb84fa212ea7f392253ffbaaa2cebb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] afdfe538b1ebbcd585ee8c08ebba545d5599c16e3af180e76feb22be8f546fe8 [INFO] running `Command { std: "docker" "start" "-a" "afdfe538b1ebbcd585ee8c08ebba545d5599c16e3af180e76feb22be8f546fe8", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking esvc-traits v0.1.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking esvc-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: named argument `field__0` is not used by name [INFO] [stdout] --> src/graph.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #[error("hash collision @ {0} detected during insertion of {}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `field__0` is not used by name [INFO] [stdout] --> src/graph.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | #[error("hash collision @ {0} detected during insertion of {}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn ensure_event(&mut self, ev: Event) -> (Option>, Hash) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / match self.events.entry(h) { [INFO] [stdout] 151 | | Entry::Occupied(o) if o.get() == &ev => None, [INFO] [stdout] 152 | | Entry::Occupied(_) => Some(ev), [INFO] [stdout] 153 | | Entry::Vacant(v) => { [INFO] [stdout] ... | [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:336:12 [INFO] [stdout] | [INFO] [stdout] 300 | let ret = bases [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Ok(ret.1.map(|sts| Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 337 | | engine: self.engine, [INFO] [stdout] 338 | | sts, [INFO] [stdout] 339 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:312:33 [INFO] [stdout] | [INFO] [stdout] 312 | .try_fold(|| (true, None), { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:320:24 [INFO] [stdout] | [INFO] [stdout] 313 | |acc: (bool, Option<_>), (i, j)| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let mut this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | this.run_recursively(graph, i, j, IncludeSpec::IncludeAll)?; [INFO] [stdout] 319 | let elem = this.sts; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Ok(if acc.1.map(|prev| prev == elem).unwrap_or(true) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 321 | | (true, Some(elem)) [INFO] [stdout] 322 | | } else { [INFO] [stdout] 323 | | (false, None) [INFO] [stdout] 324 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:333:31 [INFO] [stdout] | [INFO] [stdout] 331 | |acc, (uacc, elem)| { [INFO] [stdout] | --- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let is_mrgb = uacc && acc.0 && acc.1.map(|prev| prev == elem).unwrap_or(true); [INFO] [stdout] 333 | (is_mrgb, if is_mrgb { Some(elem) } else { None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esvc-core` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn ensure_event(&mut self, ev: Event) -> (Option>, Hash) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / match self.events.entry(h) { [INFO] [stdout] 151 | | Entry::Occupied(o) if o.get() == &ev => None, [INFO] [stdout] 152 | | Entry::Occupied(_) => Some(ev), [INFO] [stdout] 153 | | Entry::Vacant(v) => { [INFO] [stdout] ... | [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:336:12 [INFO] [stdout] | [INFO] [stdout] 300 | let ret = bases [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Ok(ret.1.map(|sts| Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 337 | | engine: self.engine, [INFO] [stdout] 338 | | sts, [INFO] [stdout] 339 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:312:33 [INFO] [stdout] | [INFO] [stdout] 312 | .try_fold(|| (true, None), { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:320:24 [INFO] [stdout] | [INFO] [stdout] 313 | |acc: (bool, Option<_>), (i, j)| { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let mut this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | this.run_recursively(graph, i, j, IncludeSpec::IncludeAll)?; [INFO] [stdout] 319 | let elem = this.sts; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Ok(if acc.1.map(|prev| prev == elem).unwrap_or(true) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 321 | | (true, Some(elem)) [INFO] [stdout] 322 | | } else { [INFO] [stdout] 323 | | (false, None) [INFO] [stdout] 324 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workcache.rs:333:31 [INFO] [stdout] | [INFO] [stdout] 331 | |acc, (uacc, elem)| { [INFO] [stdout] | --- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let is_mrgb = uacc && acc.0 && acc.1.map(|prev| prev == elem).unwrap_or(true); [INFO] [stdout] 333 | (is_mrgb, if is_mrgb { Some(elem) } else { None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esvc-core` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "afdfe538b1ebbcd585ee8c08ebba545d5599c16e3af180e76feb22be8f546fe8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afdfe538b1ebbcd585ee8c08ebba545d5599c16e3af180e76feb22be8f546fe8", kill_on_drop: false }` [INFO] [stdout] afdfe538b1ebbcd585ee8c08ebba545d5599c16e3af180e76feb22be8f546fe8