[INFO] fetching crate essence_macros 0.2.1... [INFO] checking essence_macros-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate essence_macros 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate essence_macros 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate essence_macros 0.2.1 [INFO] finished tweaking crates.io crate essence_macros 0.2.1 [INFO] tweaked toml for crates.io crate essence_macros 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c1790eb2728a3fd962c0ef848795327234feb1f3433ec46c4e5c048430f4260 [INFO] running `Command { std: "docker" "start" "-a" "2c1790eb2728a3fd962c0ef848795327234feb1f3433ec46c4e5c048430f4260", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c1790eb2728a3fd962c0ef848795327234feb1f3433ec46c4e5c048430f4260", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c1790eb2728a3fd962c0ef848795327234feb1f3433ec46c4e5c048430f4260", kill_on_drop: false }` [INFO] [stdout] 2c1790eb2728a3fd962c0ef848795327234feb1f3433ec46c4e5c048430f4260 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2bafde2a7d22a14801dea3b6f3efbb363925ba2d5f710db49a75fe78c609961f [INFO] running `Command { std: "docker" "start" "-a" "2bafde2a7d22a14801dea3b6f3efbb363925ba2d5f710db49a75fe78c609961f", kill_on_drop: false }` [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking essence_macros v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | let mut pk = opts.pk; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_in` is never read [INFO] [stdout] --> src/models.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub struct FieldOpts { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | pub is_in: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldOpts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:99 [INFO] [stdout] | [INFO] [stdout] 83 | ...concerned_fields.iter().map(|&f| (&f.name, get_type_optioned(&f.field_type, f.bound, false))).unzip(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:235:59 [INFO] [stdout] | [INFO] [stdout] 235 | let pk_field = self.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `FieldOpts` does not implement `Clone`, so calling `clone` on `&FieldOpts` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 235 - let pk_field = self.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] 235 + let pk_field = self.iter().find(|x| x.pk).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `FieldOpts`, implement `Clone` for it [INFO] [stdout] --> src/models.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Clone)] [INFO] [stdout] 60 | pub struct FieldOpts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:144 [INFO] [stdout] | [INFO] [stdout] 240 | ...map(|&f| ((&f.name, f.db_col_name.as_str()), get_type_optioned(&f.field_type, true, true))).unzip(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:351:61 [INFO] [stdout] | [INFO] [stdout] 351 | let pk_field = field_opts.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `FieldOpts` does not implement `Clone`, so calling `clone` on `&FieldOpts` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 351 - let pk_field = field_opts.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] 351 + let pk_field = field_opts.iter().find(|x| x.pk).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `FieldOpts`, implement `Clone` for it [INFO] [stdout] --> src/models.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Clone)] [INFO] [stdout] 60 | pub struct FieldOpts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | let mut pk = opts.pk; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | name: field.clone().ident.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | db_col_name: val.rename.unwrap_or(field.clone().ident.unwrap().to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | field_type: field.clone().ty, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_in` is never read [INFO] [stdout] --> src/models.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub struct FieldOpts { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | pub is_in: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldOpts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:99 [INFO] [stdout] | [INFO] [stdout] 83 | ...concerned_fields.iter().map(|&f| (&f.name, get_type_optioned(&f.field_type, f.bound, false))).unzip(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `essence_macros` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:235:59 [INFO] [stdout] | [INFO] [stdout] 235 | let pk_field = self.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `FieldOpts` does not implement `Clone`, so calling `clone` on `&FieldOpts` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 235 - let pk_field = self.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] 235 + let pk_field = self.iter().find(|x| x.pk).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `FieldOpts`, implement `Clone` for it [INFO] [stdout] --> src/models.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Clone)] [INFO] [stdout] 60 | pub struct FieldOpts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:144 [INFO] [stdout] | [INFO] [stdout] 240 | ...map(|&f| ((&f.name, f.db_col_name.as_str()), get_type_optioned(&f.field_type, true, true))).unzip(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:351:61 [INFO] [stdout] | [INFO] [stdout] 351 | let pk_field = field_opts.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `FieldOpts` does not implement `Clone`, so calling `clone` on `&FieldOpts` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 351 - let pk_field = field_opts.iter().find(|x| x.pk).unwrap().clone(); [INFO] [stdout] 351 + let pk_field = field_opts.iter().find(|x| x.pk).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `FieldOpts`, implement `Clone` for it [INFO] [stdout] --> src/models.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Clone)] [INFO] [stdout] 60 | pub struct FieldOpts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | name: field.clone().ident.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | db_col_name: val.rename.unwrap_or(field.clone().ident.unwrap().to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | field_type: field.clone().ty, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `essence_macros` (lib) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2bafde2a7d22a14801dea3b6f3efbb363925ba2d5f710db49a75fe78c609961f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bafde2a7d22a14801dea3b6f3efbb363925ba2d5f710db49a75fe78c609961f", kill_on_drop: false }` [INFO] [stdout] 2bafde2a7d22a14801dea3b6f3efbb363925ba2d5f710db49a75fe78c609961f