[INFO] fetching crate esphome 0.1.0... [INFO] checking esphome-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate esphome 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate esphome 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esphome 0.1.0 [INFO] finished tweaking crates.io crate esphome 0.1.0 [INFO] tweaked toml for crates.io crate esphome 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate esphome 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fbea114476beec873fbbca4ab020278050e10f0db79099ea9d4608bfbfdb890 [INFO] running `Command { std: "docker" "start" "-a" "0fbea114476beec873fbbca4ab020278050e10f0db79099ea9d4608bfbfdb890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fbea114476beec873fbbca4ab020278050e10f0db79099ea9d4608bfbfdb890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fbea114476beec873fbbca4ab020278050e10f0db79099ea9d4608bfbfdb890", kill_on_drop: false }` [INFO] [stdout] 0fbea114476beec873fbbca4ab020278050e10f0db79099ea9d4608bfbfdb890 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d76c6a45dc76560559a387a7f4c8270336158a1d8bf6124f619f63f916db3b6 [INFO] running `Command { std: "docker" "start" "-a" "8d76c6a45dc76560559a387a7f4c8270336158a1d8bf6124f619f63f916db3b6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.75 [INFO] [stderr] Compiling protobuf v2.24.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.100 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling protobuf-codegen v2.24.1 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Compiling protobuf-codegen-pure v2.24.1 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Compiling esphome v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/api.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/api.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `key` are never read [INFO] [stdout] --> src/device.rs:231:2 [INFO] [stdout] | [INFO] [stdout] 230 | pub struct ServicesInfo { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 231 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 232 | key: u32 [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServicesInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_id`, `name`, `unique_id`, and `key` are never read [INFO] [stdout] --> src/device.rs:237:2 [INFO] [stdout] | [INFO] [stdout] 236 | pub struct EntityInfo { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 237 | object_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 238 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 239 | unique_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 240 | key: u32 [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EntityInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(self.receive_message_body(&header)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn connect(mut self) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let mut hr = api::HelloRequest::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let hr: HelloResponse = self.receive_message(MessageType::HelloResponse)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | Ok(Device::new(self, hr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn authenticate(mut self, password: &str) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut cr = api::ConnectRequest::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let cr: ConnectResponse = self.connection.receive_message(MessageType::ConnectResponse)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(AuthenticatedDevice::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:345:6 [INFO] [stdout] | [INFO] [stdout] 344 | ... let r: api::DeviceInfoResponse = self.device.connection.request(MessageType::DeviceInfoRequest, &api::DeviceInfoRequest::new(), Messa... [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | ... Ok(DeviceInfo::new(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esphome` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name` and `key` are never read [INFO] [stdout] --> src/device.rs:231:2 [INFO] [stdout] | [INFO] [stdout] 230 | pub struct ServicesInfo { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 231 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 232 | key: u32 [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServicesInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_id`, `name`, `unique_id`, and `key` are never read [INFO] [stdout] --> src/device.rs:237:2 [INFO] [stdout] | [INFO] [stdout] 236 | pub struct EntityInfo { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 237 | object_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 238 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 239 | unique_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 240 | key: u32 [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EntityInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:105:6 [INFO] [stdout] | [INFO] [stdout] 105 | Ok(self.receive_message_body(&header)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:151:6 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn connect(mut self) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let mut hr = api::HelloRequest::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let hr: HelloResponse = self.receive_message(MessageType::HelloResponse)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | Ok(Device::new(self, hr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn authenticate(mut self, password: &str) -> Result, Box> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut cr = api::ConnectRequest::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let cr: ConnectResponse = self.connection.receive_message(MessageType::ConnectResponse)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(AuthenticatedDevice::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:345:6 [INFO] [stdout] | [INFO] [stdout] 344 | ... let r: api::DeviceInfoResponse = self.device.connection.request(MessageType::DeviceInfoRequest, &api::DeviceInfoRequest::new(), Messa... [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | ... Ok(DeviceInfo::new(r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esphome` (lib) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8d76c6a45dc76560559a387a7f4c8270336158a1d8bf6124f619f63f916db3b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d76c6a45dc76560559a387a7f4c8270336158a1d8bf6124f619f63f916db3b6", kill_on_drop: false }` [INFO] [stdout] 8d76c6a45dc76560559a387a7f4c8270336158a1d8bf6124f619f63f916db3b6