[INFO] fetching crate esp32-wroom-rp 0.3.1... [INFO] checking esp32-wroom-rp-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate esp32-wroom-rp 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate esp32-wroom-rp 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esp32-wroom-rp 0.3.1 [INFO] finished tweaking crates.io crate esp32-wroom-rp 0.3.1 [INFO] tweaked toml for crates.io crate esp32-wroom-rp 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding bare-metal v0.2.5 (latest: v1.0.0) [INFO] [stderr] Adding bitfield v0.13.2 (latest: v0.16.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding critical-section v0.2.8 (latest: v1.1.3) [INFO] [stderr] Adding defmt-rtt v0.3.2 (latest: v0.4.1) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding embedded-hal-mock v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 668be6f5457ef0da1d646ae4a3a86eb8c53523b9b8c9ff64f036359d1a12220e [INFO] running `Command { std: "docker" "start" "-a" "668be6f5457ef0da1d646ae4a3a86eb8c53523b9b8c9ff64f036359d1a12220e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "668be6f5457ef0da1d646ae4a3a86eb8c53523b9b8c9ff64f036359d1a12220e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "668be6f5457ef0da1d646ae4a3a86eb8c53523b9b8c9ff64f036359d1a12220e", kill_on_drop: false }` [INFO] [stdout] 668be6f5457ef0da1d646ae4a3a86eb8c53523b9b8c9ff64f036359d1a12220e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18debfe859f6c7f52cf867a28be0b5966d94a9c0bb122a2607cffcbd7112b039 [INFO] running `Command { std: "docker" "start" "-a" "18debfe859f6c7f52cf867a28be0b5966d94a9c0bb122a2607cffcbd7112b039", kill_on_drop: false }` [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling cortex-m v0.7.7 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling defmt v0.3.8 [INFO] [stderr] Compiling defmt-macros v0.3.9 [INFO] [stderr] Checking vcell v0.1.3 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bitfield v0.13.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling bare-metal v0.2.5 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking ufmt-write v0.1.0 [INFO] [stderr] Compiling cortex-m-semihosting v0.5.0 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking volatile-register v0.2.2 [INFO] [stderr] Compiling cortex-m-rt v0.7.3 [INFO] [stderr] Compiling panic-probe v0.3.2 [INFO] [stderr] Compiling defmt-rtt v0.3.2 [INFO] [stderr] Checking bare-metal v1.0.0 [INFO] [stderr] Checking rtt-target v0.5.0 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Compiling cortex-m-rt-macros v0.7.0 [INFO] [stderr] Checking critical-section v0.2.8 [INFO] [stderr] Checking embedded-hal-mock v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling defmt-parser v0.3.4 [INFO] [stderr] Checking esp32-wroom-rp v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 154 | fn from(concrete_param: NinaByteParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 165 | fn from(concrete_param: NinaWordParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 176 | fn from(concrete_param: NinaSmallArrayParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:190:19 [INFO] [stdout] | [INFO] [stdout] 187 | fn from(concrete_param: NinaLargeArrayParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wifi.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn destroy(self) -> S { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | self.protocol_handler.into_inner().bus.into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esp32-wroom-rp` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 154 | fn from(concrete_param: NinaByteParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 165 | fn from(concrete_param: NinaWordParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 176 | fn from(concrete_param: NinaSmallArrayParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:190:19 [INFO] [stdout] | [INFO] [stdout] 187 | fn from(concrete_param: NinaLargeArrayParam) -> NinaAbstractParam { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | data: Vec::from_slice(concrete_param.data()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wifi.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn destroy(self) -> S { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | self.protocol_handler.into_inner().bus.into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esp32-wroom-rp` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "18debfe859f6c7f52cf867a28be0b5966d94a9c0bb122a2607cffcbd7112b039", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18debfe859f6c7f52cf867a28be0b5966d94a9c0bb122a2607cffcbd7112b039", kill_on_drop: false }` [INFO] [stdout] 18debfe859f6c7f52cf867a28be0b5966d94a9c0bb122a2607cffcbd7112b039